Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/squid/msntauth.conf.default %config /etc/squid/squid.conf.default %config /etc/squid/mime.conf.default %config /etc/squid/errorpage.css.default %config /etc/squid/cachemgr.conf.default [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in squid- sysvinit [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 522240 bytes in 10 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define __perl_requires %{SOURCE98} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4546560 bytes in /usr/share 4546560 squid-3.2.5-2.fc19.x86_64.rpm Rpmlint ------- Checking: squid-3.2.5-2.fc19.x86_64.rpm squid-sysvinit-3.2.5-2.fc19.x86_64.rpm squid.x86_64: W: name-repeated-in-summary C Squid squid.x86_64: W: spelling-error %description -l en_US lookups -> lockups, hookups, look ups squid.x86_64: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up squid.x86_64: W: spelling-error %description -l en_US dnsserver -> reservedness squid.x86_64: W: spelling-error %description -l en_US ftpget -> ftp get, ftp-get, forget squid.x86_64: W: conffile-without-noreplace-flag /etc/squid/errorpage.css.default squid.x86_64: W: conffile-without-noreplace-flag /etc/squid/mime.conf.default squid.x86_64: W: conffile-without-noreplace-flag /etc/squid/squid.conf.default squid.x86_64: W: conffile-without-noreplace-flag /etc/squid/cachemgr.conf.default squid.x86_64: W: conffile-without-noreplace-flag /etc/squid/msntauth.conf.default squid.x86_64: W: manual-page-warning /usr/share/man/man8/basic_ncsa_auth.8.gz 21: warning: macro `This' not defined squid.x86_64: E: incorrect-fsf-address /usr/share/doc/squid-3.2.5/COPYRIGHT squid.x86_64: E: incorrect-fsf-address /usr/share/doc/squid-3.2.5/README squid.x86_64: E: incorrect-fsf-address /usr/lib64/squid/basic_smb_auth.sh squid.x86_64: E: non-readable /etc/squid/squid.conf 0640L squid.x86_64: E: incorrect-fsf-address /usr/share/doc/squid-3.2.5/COPYING squid.x86_64: E: non-standard-dir-perm /var/spool/squid 0750L squid.x86_64: E: non-standard-dir-perm /var/log/squid 0750L squid.x86_64: E: incorrect-fsf-address /usr/lib64/squid/basic_pop3_auth squid.x86_64: W: no-manual-page-for-binary purge squid.x86_64: W: dangerous-command-in-%pre chown squid-sysvinit.x86_64: W: spelling-error Summary(en_US) SysV -> Sysop squid-sysvinit.x86_64: W: spelling-error Summary(en_US) initscript -> inscription, postscript squid-sysvinit.x86_64: W: spelling-error %description -l en_US initscritps -> inscriptions squid-sysvinit.x86_64: W: no-documentation squid-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/squid squid-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/squid squid-sysvinit.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/squid squid-sysvinit.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/squid squid-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/squid 2 packages and 0 specfiles checked; 10 errors, 20 warnings. Requires -------- squid-sysvinit (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/service squid squid (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/chkconfig /usr/bin/perl bash config(squid) libc.so.6()(64bit) libcap.so.2()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libecap.so.2()(64bit) libexpat.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) libltdl.so.7()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpthread.so.0()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libsasl2.so.2()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) perl(Data::Dumper) perl(FileHandle) perl(Getopt::Std) perl(IPC::Open2) perl(Net::POP3) perl(vars) rtld(GNU_HASH) shadow-utils systemd Provides -------- squid-sysvinit: squid-sysvinit squid-sysvinit(x86-64) squid: config(squid) squid squid(x86-64) MD5-sum check ------------- http://www.squid-cache.org/Versions/v3/3.2/squid-3.2.5.tar.bz2 : CHECKSUM(SHA256) this package : a823de016ca80680f979f3c74ba481775062b4de5924b21d58d1863254283912 CHECKSUM(SHA256) upstream package : a823de016ca80680f979f3c74ba481775062b4de5924b21d58d1863254283912 http://www.squid-cache.org/Versions/v3/3.2/squid-3.2.5.tar.bz2.asc : CHECKSUM(SHA256) this package : 662e717ceb92a609aa4b0e1b1ddf7085483081e1203fba01313479926ceaf022 CHECKSUM(SHA256) upstream package : 662e717ceb92a609aa4b0e1b1ddf7085483081e1203fba01313479926ceaf022 Generated by fedora-review 0.4.0 (ae19e1e) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn squid -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires