Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gio-querymodules is invoked as required Note: gio module file(s) in GConf2 See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GIO_modules - update-desktop-database is invoked when required Note: desktop file(s) in GConf2 See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in GConf2-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 3 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define libxml2_version 2.4.12 %define glib2_version 2.25.9 %define dbus_version 1.0.1 %define dbus_glib_version 0.74 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 7127040 bytes in /usr/share 952320 GConf2-devel-3.2.6-1.fc19.x86_64.rpm 6174720 GConf2-3.2.6-1.fc19.x86_64.rpm Rpmlint ------- Checking: GConf2-3.2.6-1.fc19.x86_64.rpm GConf2-devel-3.2.6-1.fc19.x86_64.rpm GConf2.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged GConf2.x86_64: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands GConf2.x86_64: W: spelling-error %description -l en_US workgroup -> work group, work-group, groundwork GConf2.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.gnome.GConf.Defaults.conf GConf2.x86_64: E: incorrect-fsf-address /usr/share/doc/GConf2-3.2.6/COPYING GConf2.x86_64: W: non-conffile-in-etc /etc/rpm/macros.gconf2 GConf2.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/gsettings-data-convert.desktop GConf2.x86_64: W: no-manual-page-for-binary gconf-merge-tree GConf2-devel.x86_64: W: spelling-error %description -l en_US GConf -> Confab GConf2-devel.x86_64: E: incorrect-fsf-address /usr/bin/gsettings-schema-convert 2 packages and 0 specfiles checked; 2 errors, 8 warnings. Requires -------- GConf2-devel (rpmlib, GLIBC filtered): /usr/bin/env /usr/bin/pkg-config GConf2 automake glib2-devel libgconf-2.so.4()(64bit) libxml2-devel pkgconfig pkgconfig(dbus-1) pkgconfig(gio-2.0) pkgconfig(glib-2.0) GConf2 (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig /usr/bin/killall config(GConf2) dbus libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libgconf-2.so.4()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libpolkit-gobject-1.so.0()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) Provides -------- GConf2-devel: GConf2-devel GConf2-devel(x86-64) pkgconfig(gconf-2.0) GConf2: GConf2 GConf2(x86-64) GConf2-gtk config(GConf2) libgconf-2.so.4()(64bit) libgconfbackend-oldxml.so()(64bit) libgconfbackend-xml.so()(64bit) libgsettingsgconfbackend.so()(64bit) Unversioned so-files -------------------- GConf2: /usr/lib64/GConf/2/libgconfbackend-oldxml.so GConf2: /usr/lib64/GConf/2/libgconfbackend-xml.so GConf2: /usr/lib64/gio/modules/libgsettingsgconfbackend.so Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn GConf2 -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires