Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Large documentation must go in a -doc subpackage. Note: Documentation size is 1167360 bytes in 21 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in NetworkManager-wimax , NetworkManager-devel , NetworkManager-glib , NetworkManager-glib-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define dbus_version 1.1 %define dbus_glib_version 0.94 %define glib2_version 2.24.0 %define wireless_tools_version 1:28-0pre9 %define libnl3_version 3.2.6 %define ppp_version 2.4.5 %define snapshot .git20121211 %define realversion 0.9.7.0 %define systemd_dir /lib/systemd/system %define systemd_dir %{_prefix}/lib/systemd/system [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 8519680 bytes in /usr/share 2600960 NetworkManager-0.9.7.0-13.git20121211.fc19.x86_64.rpm 1566720 NetworkManager-devel-0.9.7.0-13.git20121211.fc19.x86_64.rpm 4352000 NetworkManager-glib-devel-0.9.7.0-13.git20121211.fc19.x86_64.rpm Rpmlint ------- Checking: NetworkManager-0.9.7.0-13.git20121211.fc19.x86_64.rpm NetworkManager-wimax-0.9.7.0-13.git20121211.fc19.x86_64.rpm NetworkManager-devel-0.9.7.0-13.git20121211.fc19.x86_64.rpm NetworkManager-glib-0.9.7.0-13.git20121211.fc19.x86_64.rpm NetworkManager-glib-devel-0.9.7.0-13.git20121211.fc19.x86_64.rpm NetworkManager.x86_64: W: spelling-error %description -l en_US ethernet -> Ethernet, ether net, ether-net NetworkManager.x86_64: W: incoherent-version-in-changelog 0.9.7.0-13.git20121211 ['1:0.9.7.0-13.git20121211.fc19', '1:0.9.7.0-13.git20121211'] NetworkManager.x86_64: W: obsolete-not-provided dhcdbd NetworkManager.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/nm-dhcp-client.conf NetworkManager.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/nm-dispatcher.conf NetworkManager.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.NetworkManager.conf NetworkManager.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/nm-avahi-autoipd.conf NetworkManager.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/nm-ifcfg-rh.conf NetworkManager-wimax.x86_64: W: no-documentation NetworkManager-devel.x86_64: E: description-line-too-long C This package contains various headers accessing some NetworkManager functionality NetworkManager-glib.x86_64: W: summary-ended-with-dot C Libraries for adding NetworkManager support to applications that use glib. NetworkManager-glib.x86_64: E: description-line-too-long C This package contains the libraries that make it easier to use some NetworkManager NetworkManager-glib.x86_64: W: no-documentation NetworkManager-glib-devel.x86_64: W: summary-ended-with-dot C Header files for adding NetworkManager support to applications that use glib. NetworkManager-glib-devel.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure NetworkManager-glib-devel.x86_64: E: description-line-too-long C This package contains the header and pkg-config files for development applications using 5 packages and 0 specfiles checked; 3 errors, 13 warnings. Requires -------- NetworkManager-glib-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config NetworkManager-devel(x86-64) NetworkManager-glib(x86-64) dbus-glib-devel glib2-devel libnm-glib-vpn.so.1()(64bit) libnm-glib.so.4()(64bit) libnm-util.so.2()(64bit) pkgconfig pkgconfig(NetworkManager) pkgconfig(dbus-glib-1) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) NetworkManager (rpmlib, GLIBC filtered): /bin/sh /bin/systemctl NetworkManager-glib(x86-64) avahi-autoipd chkconfig config(NetworkManager) dbus dbus-glib dhclient dnsmasq glib2 iproute libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libdl.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgudev-1.0.so.0()(64bit) libm.so.6()(64bit) libnl-3.so.200()(64bit) libnl-genl-3.so.200()(64bit) libnl-route-3.so.200()(64bit) libnl3 libnm-glib.so.4()(64bit) libnm-util.so.2()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnssutil3.so()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpolkit-gobject-1.so.0()(64bit) libpthread.so.0()(64bit) libsmime3.so()(64bit) libssl3.so()(64bit) libsystemd-login.so.0()(64bit) libuuid.so.1()(64bit) ppp rtld(GNU_HASH) systemd-sysv udev wpa_supplicant NetworkManager-wimax (rpmlib, GLIBC filtered): NetworkManager(x86-64) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libdl.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgudev-1.0.so.0()(64bit) libiWmxSdk.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) wimax NetworkManager-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config NetworkManager(x86-64) dbus-devel dbus-glib pkgconfig NetworkManager-glib (rpmlib, GLIBC filtered): /sbin/ldconfig dbus dbus-glib libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libdl.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgudev-1.0.so.0()(64bit) libnm-util.so.2()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnss3.so(NSS_3.2)(64bit) libnss3.so(NSS_3.3)(64bit) libnssutil3.so()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpthread.so.0()(64bit) libsmime3.so()(64bit) libsmime3.so(NSS_3.2)(64bit) libsmime3.so(NSS_3.4)(64bit) libssl3.so()(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) rtld(GNU_HASH) Provides -------- NetworkManager-glib-devel: NetworkManager-glib-devel NetworkManager-glib-devel(x86-64) pkgconfig(libnm-glib) pkgconfig(libnm-glib-vpn) pkgconfig(libnm-util) NetworkManager: NetworkManager NetworkManager(x86-64) config(NetworkManager) libnm-settings-plugin-ifcfg-rh.so()(64bit) nm-pppd-plugin.so()(64bit) NetworkManager-wimax: NetworkManager-wimax NetworkManager-wimax(x86-64) libnm-device-plugin-wimax.so()(64bit) NetworkManager-devel: NetworkManager-devel NetworkManager-devel(x86-64) pkgconfig(NetworkManager) NetworkManager-glib: NetworkManager-glib NetworkManager-glib(x86-64) libnm-glib-vpn.so.1()(64bit) libnm-glib.so.4()(64bit) libnm-util.so.2()(64bit) Unversioned so-files -------------------- NetworkManager: /usr/lib64/NetworkManager/libnm-settings-plugin-ifcfg-rh.so NetworkManager: /usr/lib64/pppd/2.4.5/nm-pppd-plugin.so NetworkManager-wimax: /usr/lib64/NetworkManager/libnm-device-plugin-wimax.so Generated by fedora-review 0.4.0 (736af0d) last change: 2013-01-28 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn NetworkManager -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires