Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/a2ps.cfg [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Texinfo files are properly installed Note: Texinfo .info file(s) in a2ps [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 194560 bytes in 7 files. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3870720 bytes in /usr/share 3829760 a2ps-4.14-16.fc18.x86_64.rpm 20480 emacs-a2ps-el-4.14-16.fc18.x86_64.rpm 20480 emacs-a2ps-4.14-16.fc18.x86_64.rpm Rpmlint ------- Checking: a2ps-4.14-16.fc18.x86_64.rpm a2ps.x86_64: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings a2ps.x86_64: W: shared-lib-calls-exit /usr/lib64/liba2ps.so.1.0.0 exit@GLIBC_2.2.5 a2ps.x86_64: W: conffile-without-noreplace-flag /etc/a2ps.cfg a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/hp.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/coqv.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/php.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/encoding.map a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/small.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso4.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/ms-cp1250.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso8.edf a2ps.x86_64: E: incorrect-fsf-address /usr/bin/pdiff a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/prolog.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/cidl.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/csh.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ppd/level1.ppd a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/for77-free.ssh a2ps.x86_64: W: manual-page-warning /usr/share/man/man1/psmandup.1.gz 9: warning: macro `"' not defined a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso13.edf a2ps.x86_64: W: manual-page-warning /usr/share/man/man1/a2ps.1.gz 9: warning: macro `"' not defined a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso3.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/chlog.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/lace.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso15.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ppd/level2.ppd a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/autoconf.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/sml.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/koi8.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/diffcolor.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/dc_shell.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/awk.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/sheets.map a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/matlab.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/euc-jp.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/eiffel.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/for90-fixed.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/vba.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/a2psrc.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/68000.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/afm/fonts.map a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/yacc.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/clisp.ssh a2ps.x86_64: W: file-not-utf8 /usr/share/info/a2ps.info.gz a2ps.x86_64: E: incorrect-fsf-address /etc/a2ps.cfg a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/wdiff.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/elisp.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/scheme.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/vtcl.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/card.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/haskell.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/gray.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/tk.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/base.ps a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/pic16f84.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/mib.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso9.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/for77-fixed.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/tcsh.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/texscript.ssh a2ps.x86_64: W: manual-page-warning /usr/share/man/man1/fixps.1.gz 9: warning: macro `"' not defined a2ps.x86_64: E: incorrect-fsf-address /usr/bin/fixps a2ps.x86_64: W: manual-page-warning /usr/share/man/man1/pdiff.1.gz 9: warning: macro `"' not defined a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/gmake.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/java.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/ssh.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso1.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/eps.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/euc-kr.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/ascii.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/sather.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/for77kwds.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/objc.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/caml.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/color.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/color.hdr a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/ada.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/tclx.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/for-fixed.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/gray2.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/sed.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/gnuc.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/tiger.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso10.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/udiff.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso5.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/bold.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/diff.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/ocaml.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/for-free.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/texinfo.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/mail.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/for90-free.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/tcl.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/nasm.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/zsh.ssh a2ps.x86_64: W: manual-page-warning /usr/share/man/man1/card.1.gz 9: warning: macro `"' not defined a2ps.x86_64: E: incorrect-fsf-address /usr/bin/card a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/modula3.ssh a2ps.x86_64: W: manual-page-warning /usr/share/man/man1/psset.1.gz 9: warning: macro `"' not defined a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/csharp.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/cxx.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/bc.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/ibm-cp850.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/afm/make_fonts_map.sh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/ps.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/xs.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/fonts/pcfont.pfa a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/python.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/mly.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/bin/psset a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/pre.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/st.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/specc.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/fixed.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/symbols.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/oberon.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/c.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/shell.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/unity.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/asn1.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso7.edf a2ps.x86_64: E: incorrect-fsf-address /usr/bin/texi2dvi4a2ps a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/ppd.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/bw.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/pov.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/promela.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/is5rul.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/ms-cp1251.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/iso2.edf a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/html.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/ul.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/for90kwds.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/sdl88.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/perl.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/o2c.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/make.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/vrml.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/js.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/pascal.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/matlab4.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/lex.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/maple.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/claire.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/a2ps.hdr a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/pretex.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/ps/matrix.pro a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/rexx.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/cpp.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/idl.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/stratego.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/b.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/sheets/sh.ssh a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/mac.edf a2ps.x86_64: E: incorrect-fsf-address /usr/bin/psmandup a2ps.x86_64: E: incorrect-fsf-address /usr/share/a2ps/encoding/ibm-cp437.edf a2ps.x86_64: W: no-manual-page-for-binary fixnt a2ps.x86_64: W: no-manual-page-for-binary composeglyphs a2ps.x86_64: W: dangerous-command-in-%post mv 1 packages and 0 specfiles checked; 145 errors, 13 warnings. Requires -------- a2ps (rpmlib, GLIBC filtered): /bin/sh /sbin/install-info /sbin/ldconfig /usr/bin/perl ImageMagick bzip2 config(a2ps) coreutils file fileutils groff-perl gzip html2ps info liba2ps.so.1()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) psutils psutils-perl rtld(GNU_HASH) sh-utils tetex-dvips tetex-fonts tetex-latex texinfo-tex Provides -------- a2ps: a2ps a2ps(x86-64) a2ps-i18n config(a2ps) liba2ps.so.1()(64bit) MD5-sum check ------------- http://ftp.gnu.org/gnu/a2ps/a2ps-4.14.tar.gz : CHECKSUM(SHA256) this package : f3ae8d3d4564a41b6e2a21f237d2f2b104f48108591e8b83497500182a3ab3a4 CHECKSUM(SHA256) upstream package : f3ae8d3d4564a41b6e2a21f237d2f2b104f48108591e8b83497500182a3ab3a4 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn a2ps -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires