Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - No %config files under /usr. Note: %config(noreplace) /usr/share/alsa/alsa.conf.d/50-jack.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/50-pcm-oss.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/50-pulseaudio.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/99-pulseaudio-default.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/10-samplerate.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/50-upmix.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/97-vdownmix.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/50-arcamav.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/10-speex.conf%config(noreplace) /usr/share/alsa/alsa.conf.d/98-maemo.conf See: http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in alsa- plugins-jack , alsa-plugins-oss , alsa-plugins-pulseaudio , alsa-plugins- samplerate , alsa-plugins-upmix , alsa-plugins-vdownmix , alsa-plugins- usbstream , alsa-plugins-arcamav , alsa-plugins-speex , alsa-plugins- maemo [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 532480 bytes in 30 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define with_jack 0 %define with_jack 1 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: alsa-plugins-jack-1.0.26-2.fc19.x86_64.rpm alsa-plugins-oss-1.0.26-2.fc19.x86_64.rpm alsa-plugins-pulseaudio-1.0.26-2.fc19.x86_64.rpm alsa-plugins-samplerate-1.0.26-2.fc19.x86_64.rpm alsa-plugins-upmix-1.0.26-2.fc19.x86_64.rpm alsa-plugins-vdownmix-1.0.26-2.fc19.x86_64.rpm alsa-plugins-usbstream-1.0.26-2.fc19.x86_64.rpm alsa-plugins-arcamav-1.0.26-2.fc19.x86_64.rpm alsa-plugins-speex-1.0.26-2.fc19.x86_64.rpm alsa-plugins-maemo-1.0.26-2.fc19.x86_64.rpm alsa-plugins-jack.x86_64: W: spelling-error %description -l en_US jackd -> jacks, jack, jacked alsa-plugins-jack.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/50-jack.conf alsa-plugins-jack.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-jack-1.0.26/COPYING alsa-plugins-jack.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-jack-1.0.26/COPYING.GPL alsa-plugins-oss.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/50-pcm-oss.conf alsa-plugins-oss.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-oss-1.0.26/COPYING.GPL alsa-plugins-oss.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-oss-1.0.26/COPYING alsa-plugins-pulseaudio.x86_64: W: spelling-error Summary(en_US) backend -> backed, back end, back-end alsa-plugins-pulseaudio.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/99-pulseaudio-default.conf alsa-plugins-pulseaudio.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/50-pulseaudio.conf alsa-plugins-pulseaudio.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-pulseaudio-1.0.26/COPYING alsa-plugins-pulseaudio.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-pulseaudio-1.0.26/COPYING.GPL alsa-plugins-samplerate.x86_64: W: spelling-error %description -l en_US libsamplerate -> deliberateness alsa-plugins-samplerate.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d alsa-plugins-samplerate.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/10-samplerate.conf alsa-plugins-samplerate.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-samplerate-1.0.26/COPYING.GPL alsa-plugins-samplerate.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-samplerate-1.0.26/COPYING alsa-plugins-upmix.x86_64: W: spelling-error Summary(en_US) Upmixer -> Up mixer, Up-mixer, Mixer alsa-plugins-upmix.x86_64: W: spelling-error Summary(en_US) expander -> expanded, ex pander, ex-pander alsa-plugins-upmix.x86_64: W: spelling-error %description -l en_US upmixing -> up mixing, up-mixing, upcoming alsa-plugins-upmix.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/50-upmix.conf alsa-plugins-upmix.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-upmix-1.0.26/COPYING.GPL alsa-plugins-upmix.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-upmix-1.0.26/COPYING alsa-plugins-vdownmix.x86_64: W: spelling-error Summary(en_US) Downmixer -> Down mixer, Down-mixer, Downriver alsa-plugins-vdownmix.x86_64: W: spelling-error %description -l en_US downmixer -> down mixer, down-mixer, downriver alsa-plugins-vdownmix.x86_64: W: spelling-error %description -l en_US spacialization -> specialization, socialization, palatalization alsa-plugins-vdownmix.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/97-vdownmix.conf alsa-plugins-vdownmix.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-vdownmix-1.0.26/COPYING alsa-plugins-vdownmix.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-vdownmix-1.0.26/COPYING.GPL alsa-plugins-usbstream.x86_64: W: spelling-error %description -l en_US snd -> and, send, sand alsa-plugins-usbstream.x86_64: W: spelling-error %description -l en_US usb -> USB, sub, us alsa-plugins-usbstream.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-usbstream-1.0.26/COPYING alsa-plugins-usbstream.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-usbstream-1.0.26/COPYING.GPL alsa-plugins-arcamav.x86_64: W: spelling-error Summary(en_US) Arcam -> Ar cam, Ar-cam, Arc am alsa-plugins-arcamav.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/50-arcamav.conf alsa-plugins-arcamav.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-arcamav-1.0.26/COPYING.GPL alsa-plugins-arcamav.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-arcamav-1.0.26/COPYING alsa-plugins-speex.x86_64: W: spelling-error %description -l en_US resampler -> re sampler, re-sampler, res ampler alsa-plugins-speex.x86_64: W: spelling-error %description -l en_US pcm -> pm, cm, pct alsa-plugins-speex.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee alsa-plugins-speex.x86_64: W: spelling-error %description -l en_US denoise -> Denise, noise alsa-plugins-speex.x86_64: W: spelling-error %description -l en_US libspeex -> lisper alsa-plugins-speex.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/10-speex.conf alsa-plugins-speex.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-speex-1.0.26/COPYING.GPL alsa-plugins-speex.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-speex-1.0.26/COPYING alsa-plugins-maemo.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/alsa/alsa.conf.d/98-maemo.conf alsa-plugins-maemo.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-maemo-1.0.26/COPYING alsa-plugins-maemo.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-plugins-maemo-1.0.26/COPYING.GPL 10 packages and 0 specfiles checked; 20 errors, 28 warnings. Requires -------- alsa-plugins-speex (rpmlib, GLIBC filtered): config(alsa-plugins-speex) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound_module_rate_speexrate.so()(64bit) libc.so.6()(64bit) libspeexdsp.so.1()(64bit) rtld(GNU_HASH) speex alsa-plugins-arcamav (rpmlib, GLIBC filtered): config(alsa-plugins-arcamav) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) rtld(GNU_HASH) alsa-plugins-jack (rpmlib, GLIBC filtered): alsa-utils config(alsa-plugins-jack) jack-audio-connection-kit libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) libjack.so.0()(64bit) rtld(GNU_HASH) alsa-plugins-maemo (rpmlib, GLIBC filtered): config(alsa-plugins-maemo) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) alsa-plugins-usbstream (rpmlib, GLIBC filtered): libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) rtld(GNU_HASH) alsa-plugins-upmix (rpmlib, GLIBC filtered): alsa-utils config(alsa-plugins-upmix) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) rtld(GNU_HASH) alsa-plugins-pulseaudio (rpmlib, GLIBC filtered): alsa-utils config(alsa-plugins-pulseaudio) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) pulseaudio rtld(GNU_HASH) alsa-plugins-oss (rpmlib, GLIBC filtered): alsa-utils config(alsa-plugins-oss) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) rtld(GNU_HASH) alsa-plugins-vdownmix (rpmlib, GLIBC filtered): alsa-utils config(alsa-plugins-vdownmix) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) rtld(GNU_HASH) alsa-plugins-samplerate (rpmlib, GLIBC filtered): alsa-utils config(alsa-plugins-samplerate) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound_module_rate_samplerate.so()(64bit) libc.so.6()(64bit) libsamplerate.so.0()(64bit) libsamplerate.so.0(libsamplerate.so.0.0)(64bit) libsamplerate.so.0(libsamplerate.so.0.1)(64bit) rtld(GNU_HASH) Provides -------- alsa-plugins-speex: alsa-plugins-speex alsa-plugins-speex(x86-64) config(alsa-plugins-speex) libasound_module_pcm_speex.so()(64bit) libasound_module_rate_speexrate.so()(64bit) alsa-plugins-arcamav: alsa-plugins-arcamav alsa-plugins-arcamav(x86-64) config(alsa-plugins-arcamav) libasound_module_ctl_arcam_av.so()(64bit) alsa-plugins-jack: alsa-plugins-jack alsa-plugins-jack(x86-64) config(alsa-plugins-jack) libasound_module_pcm_jack.so()(64bit) alsa-plugins-maemo: alsa-plugins-maemo alsa-plugins-maemo(x86-64) config(alsa-plugins-maemo) libasound_module_ctl_dsp_ctl.so()(64bit) libasound_module_pcm_alsa_dsp.so()(64bit) alsa-plugins-usbstream: alsa-plugins-usbstream alsa-plugins-usbstream(x86-64) libasound_module_pcm_usb_stream.so()(64bit) alsa-plugins-upmix: alsa-plugins-upmix alsa-plugins-upmix(x86-64) config(alsa-plugins-upmix) libasound_module_pcm_upmix.so()(64bit) alsa-plugins-pulseaudio: alsa-plugins-pulseaudio alsa-plugins-pulseaudio(x86-64) config(alsa-plugins-pulseaudio) libasound_module_conf_pulse.so()(64bit) libasound_module_ctl_pulse.so()(64bit) libasound_module_pcm_pulse.so()(64bit) alsa-plugins-oss: alsa-plugins-oss alsa-plugins-oss(x86-64) config(alsa-plugins-oss) libasound_module_ctl_oss.so()(64bit) libasound_module_pcm_oss.so()(64bit) alsa-plugins-vdownmix: alsa-plugins-vdownmix alsa-plugins-vdownmix(x86-64) config(alsa-plugins-vdownmix) libasound_module_pcm_vdownmix.so()(64bit) alsa-plugins-samplerate: alsa-plugins-samplerate alsa-plugins-samplerate(x86-64) config(alsa-plugins-samplerate) libasound_module_rate_samplerate.so()(64bit) Unversioned so-files -------------------- alsa-plugins-jack: /usr/lib64/alsa-lib/libasound_module_pcm_jack.so alsa-plugins-oss: /usr/lib64/alsa-lib/libasound_module_ctl_oss.so alsa-plugins-oss: /usr/lib64/alsa-lib/libasound_module_pcm_oss.so alsa-plugins-pulseaudio: /usr/lib64/alsa-lib/libasound_module_conf_pulse.so alsa-plugins-pulseaudio: /usr/lib64/alsa-lib/libasound_module_ctl_pulse.so alsa-plugins-pulseaudio: /usr/lib64/alsa-lib/libasound_module_pcm_pulse.so alsa-plugins-samplerate: /usr/lib64/alsa-lib/libasound_module_rate_samplerate.so alsa-plugins-samplerate: /usr/lib64/alsa-lib/libasound_module_rate_samplerate_best.so alsa-plugins-samplerate: /usr/lib64/alsa-lib/libasound_module_rate_samplerate_linear.so alsa-plugins-samplerate: /usr/lib64/alsa-lib/libasound_module_rate_samplerate_medium.so alsa-plugins-samplerate: /usr/lib64/alsa-lib/libasound_module_rate_samplerate_order.so alsa-plugins-upmix: /usr/lib64/alsa-lib/libasound_module_pcm_upmix.so alsa-plugins-vdownmix: /usr/lib64/alsa-lib/libasound_module_pcm_vdownmix.so alsa-plugins-usbstream: /usr/lib64/alsa-lib/libasound_module_pcm_usb_stream.so alsa-plugins-arcamav: /usr/lib64/alsa-lib/libasound_module_ctl_arcam_av.so alsa-plugins-speex: /usr/lib64/alsa-lib/libasound_module_pcm_speex.so alsa-plugins-speex: /usr/lib64/alsa-lib/libasound_module_rate_speexrate.so alsa-plugins-speex: /usr/lib64/alsa-lib/libasound_module_rate_speexrate_best.so alsa-plugins-speex: /usr/lib64/alsa-lib/libasound_module_rate_speexrate_medium.so alsa-plugins-maemo: /usr/lib64/alsa-lib/libasound_module_ctl_dsp_ctl.so alsa-plugins-maemo: /usr/lib64/alsa-lib/libasound_module_pcm_alsa_dsp.so MD5-sum check ------------- ftp://ftp.alsa-project.org/pub/plugins/alsa-plugins-1.0.26.tar.bz2 : CHECKSUM(SHA256) this package : 03515134d2009db4dfb2769e0ab0e1fb517c8140ffdfd64a984be968e81c9f1f CHECKSUM(SHA256) upstream package : 03515134d2009db4dfb2769e0ab0e1fb517c8140ffdfd64a984be968e81c9f1f Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn alsa-plugins -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires