Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in alsa-tools See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in alsa-tools- firmware [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 276480 bytes in 25 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: alsa-tools-1.0.26.1-2.fc19.x86_64.rpm alsa-tools-firmware-1.0.26.1-2.fc19.x86_64.rpm alsa-tools.x86_64: W: spelling-error %description -l en_US soundcards -> sound cards, sound-cards, soundboards alsa-tools.x86_64: W: spelling-error %description -l en_US sscape -> escape, seascape alsa-tools.x86_64: W: spelling-error %description -l en_US ctl -> ct, cl, cal alsa-tools.x86_64: W: spelling-error %description -l en_US hda -> had, ha, Ida alsa-tools.x86_64: W: spelling-error %description -l en_US codec -> codex, code, codes alsa-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/hdspconf/COPYING alsa-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/envy24control/COPYING alsa-tools.x86_64: W: manual-page-warning /usr/share/man/man1/cspctl.1.gz 2: warning: macro `LO' not defined alsa-tools.x86_64: W: manual-page-warning /usr/share/man/man1/cspctl.1.gz 20: warning: macro `Sp' not defined alsa-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/sbiload/COPYING alsa-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/hdspmixer/COPYING alsa-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/as10k1/COPYING alsa-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/sb16_csp/COPYING alsa-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/echomixer/COPYING alsa-tools.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/rmedigicontrol/COPYING alsa-tools.x86_64: W: no-manual-page-for-binary as10k1 alsa-tools.x86_64: W: no-manual-page-for-binary hdspconf alsa-tools.x86_64: W: no-manual-page-for-binary hdajackretask alsa-tools.x86_64: W: no-manual-page-for-binary us428control alsa-tools.x86_64: W: no-manual-page-for-binary rmedigicontrol alsa-tools.x86_64: W: no-manual-page-for-binary echomixer alsa-tools.x86_64: W: no-manual-page-for-binary hdspmixer alsa-tools.x86_64: W: no-manual-page-for-binary sscape_ctl alsa-tools.x86_64: W: no-manual-page-for-binary hwmixvolume alsa-tools.x86_64: W: no-manual-page-for-binary sbiload alsa-tools.x86_64: W: no-manual-page-for-binary hda-verb alsa-tools-firmware.x86_64: W: spelling-error Summary(en_US) soundcards -> sound cards, sound-cards, soundboards alsa-tools-firmware.x86_64: W: spelling-error %description -l en_US miXart -> mix art, mix-art, minaret alsa-tools-firmware.x86_64: W: spelling-error %description -l en_US soundcards -> sound cards, sound-cards, soundboards alsa-tools-firmware.x86_64: E: incorrect-fsf-address /usr/share/doc/alsa-tools-1.0.26.1/hdsploader/COPYING alsa-tools-firmware.x86_64: W: no-manual-page-for-binary usx2yloader alsa-tools-firmware.x86_64: W: no-manual-page-for-binary vxloader alsa-tools-firmware.x86_64: W: no-manual-page-for-binary mixartloader alsa-tools-firmware.x86_64: W: no-manual-page-for-binary hdsploader 2 packages and 0 specfiles checked; 9 errors, 25 warnings. Requires -------- alsa-tools-firmware (rpmlib, GLIBC filtered): /bin/sh alsa-firmware fxload libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) udev alsa-tools (rpmlib, GLIBC filtered): /usr/bin/env libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.3)(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) python-alsa rtld(GNU_HASH) xorg-x11-fonts-misc Provides -------- alsa-tools-firmware: alsa-tools-firmware alsa-tools-firmware(x86-64) alsa-tools: alsa-tools alsa-tools(x86-64) Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn alsa-tools -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires