Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Old add_to_maven_depmap macro is not being used See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro - Pom files have correct add_maven_depmap call Note: No add_maven_depmap calls found but pom files present See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in ant-jmf, ant- swing, ant-antlr, ant-apache-bsf, ant-apache-resolver, ant-commons-logging, ant-commons-net, ant-apache-bcel, ant-apache-log4j, ant-apache-oro, ant- apache-regexp, ant-apache-xalan2, ant-javamail, ant-jdepend, ant-jsch, ant- junit, ant-testutil, ant-scripts, ant-manual See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Large documentation must go in a -doc subpackage. Note: Documentation size is 2918400 bytes in 236 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ant-jmf , ant-swing , ant-antlr , ant-apache-bsf , ant-apache-resolver , ant- commons-logging , ant-commons-net , ant-apache-bcel , ant-apache-log4j , ant-apache-oro , ant-apache-regexp , ant-apache-xalan2 , ant-javamail , ant-jdepend , ant-jsch , ant-junit , ant-testutil , ant-scripts , ant- manual , ant-javadoc [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Test run failed [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define with() %{expand:%%{?with_%{1}:1}%%{!?with_%{1}:0}} %define without() %{expand:%%{?with_%{1}:0}%%{!?with_%{1}:1}} %define bcond_with() %{expand:%%{?_with_%{1}:%%global with_%{1} 1}} %define bcond_without() %{expand:%%{!?_without_%{1}:%%global with_%{1} 1}} [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: ant-1.8.4-5.fc19.noarch.rpm ant-jmf-1.8.4-5.fc19.noarch.rpm ant-swing-1.8.4-5.fc19.noarch.rpm ant-antlr-1.8.4-5.fc19.noarch.rpm ant-apache-bsf-1.8.4-5.fc19.noarch.rpm ant-apache-resolver-1.8.4-5.fc19.noarch.rpm ant-commons-logging-1.8.4-5.fc19.noarch.rpm ant-commons-net-1.8.4-5.fc19.noarch.rpm ant-apache-bcel-1.8.4-5.fc19.noarch.rpm ant-apache-log4j-1.8.4-5.fc19.noarch.rpm ant-apache-oro-1.8.4-5.fc19.noarch.rpm ant-apache-regexp-1.8.4-5.fc19.noarch.rpm ant-apache-xalan2-1.8.4-5.fc19.noarch.rpm ant-javamail-1.8.4-5.fc19.noarch.rpm ant-jdepend-1.8.4-5.fc19.noarch.rpm ant-jsch-1.8.4-5.fc19.noarch.rpm ant-junit-1.8.4-5.fc19.noarch.rpm ant-testutil-1.8.4-5.fc19.noarch.rpm ant-scripts-1.8.4-5.fc19.noarch.rpm ant-manual-1.8.4-5.fc19.noarch.rpm ant-javadoc-1.8.4-5.fc19.noarch.rpm ant.noarch: E: devel-dependency java-devel ant.noarch: I: enchant-dictionary-not-found it ant.noarch: I: enchant-dictionary-not-found fr ant.noarch: W: spelling-error %description -l en_US apache -> Apache, apace ant.noarch: W: spelling-error %description -l en_US jakarta -> Jakarta ant.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml ant.noarch: W: no-manual-page-for-binary ant ant.noarch: W: no-manual-page-for-binary antRun ant-jmf.noarch: W: no-documentation ant-swing.noarch: W: no-documentation ant-antlr.noarch: W: no-documentation ant-apache-bsf.noarch: W: no-documentation ant-apache-resolver.noarch: W: no-documentation ant-commons-logging.noarch: W: no-documentation ant-commons-net.noarch: W: no-documentation ant-apache-bcel.noarch: W: no-documentation ant-apache-log4j.noarch: W: no-documentation ant-apache-oro.noarch: W: no-documentation ant-apache-regexp.noarch: W: no-documentation ant-apache-xalan2.noarch: W: no-documentation ant-javamail.noarch: W: no-documentation ant-jdepend.noarch: W: no-documentation ant-jsch.noarch: W: no-documentation ant-junit.noarch: W: no-documentation ant-testutil.noarch: W: no-documentation ant-scripts.noarch: W: no-documentation ant-scripts.noarch: W: no-manual-page-for-binary runant.py ant-scripts.noarch: W: no-manual-page-for-binary antRun.pl ant-scripts.noarch: W: no-manual-page-for-binary runant.pl ant-scripts.noarch: W: no-manual-page-for-binary complete-ant-cmd.pl ant-manual.noarch: W: file-not-utf8 /usr/share/doc/ant-manual-1.8.4/tutorial-tasks-filesets-properties.zip ant-manual.noarch: W: file-not-utf8 /usr/share/doc/ant-manual-1.8.4/tutorial-writing-tasks-src.zip ant-manual.noarch: W: dangling-symlink /usr/share/doc/ant-manual-1.8.4/api /usr/share/javadoc/ant 21 packages and 0 specfiles checked; 1 errors, 30 warnings. Requires -------- ant-testutil (rpmlib, GLIBC filtered): ant config(ant-testutil) junit ant-apache-oro (rpmlib, GLIBC filtered): ant config(ant-apache-oro) jakarta-oro ant-junit (rpmlib, GLIBC filtered): ant config(ant-junit) junit xalan-j2 ant-manual (rpmlib, GLIBC filtered): ant-javamail (rpmlib, GLIBC filtered): ant config(ant-javamail) javamail ant-commons-net (rpmlib, GLIBC filtered): ant apache-commons-net config(ant-commons-net) ant-antlr (rpmlib, GLIBC filtered): ant antlr config(ant-antlr) ant-commons-logging (rpmlib, GLIBC filtered): ant apache-commons-logging config(ant-commons-logging) ant-apache-bcel (rpmlib, GLIBC filtered): ant bcel config(ant-apache-bcel) ant-jmf (rpmlib, GLIBC filtered): ant ant-nodeps config(ant-jmf) ant-apache-regexp (rpmlib, GLIBC filtered): ant config(ant-apache-regexp) regexp ant-jdepend (rpmlib, GLIBC filtered): ant config(ant-jdepend) jdepend ant (rpmlib, GLIBC filtered): config(ant) java-devel jpackage-utils xerces-j2 ant-scripts (rpmlib, GLIBC filtered): /usr/bin/perl /usr/bin/python ant ant-javadoc (rpmlib, GLIBC filtered): jpackage-utils ant-apache-resolver (rpmlib, GLIBC filtered): ant config(ant-apache-resolver) xml-commons-resolver ant-apache-log4j (rpmlib, GLIBC filtered): ant config(ant-apache-log4j) log4j ant-jsch (rpmlib, GLIBC filtered): ant config(ant-jsch) jsch ant-apache-xalan2 (rpmlib, GLIBC filtered): ant config(ant-apache-xalan2) regexp xalan-j2 ant-apache-bsf (rpmlib, GLIBC filtered): ant bsf config(ant-apache-bsf) ant-swing (rpmlib, GLIBC filtered): ant config(ant-swing) Provides -------- ant-testutil: ant-testutil config(ant-testutil) ant-apache-oro: ant-apache-oro ant-jakarta-oro config(ant-apache-oro) ant-junit: ant-junit config(ant-junit) ant-manual: ant-manual ant-javamail: ant-javamail config(ant-javamail) ant-commons-net: ant-commons-net config(ant-commons-net) ant-antlr: ant-antlr config(ant-antlr) ant-commons-logging: ant-commons-logging config(ant-commons-logging) ant-apache-bcel: ant-apache-bcel ant-jakarta-bcel config(ant-apache-bcel) ant-jmf: ant-jmf config(ant-jmf) ant-apache-regexp: ant-apache-regexp ant-jakarta-regexp config(ant-apache-regexp) ant-jdepend: ant-jdepend config(ant-jdepend) ant: ant ant-nodeps ant-trax config(ant) mvn(org.apache.ant:ant) mvn(org.apache.ant:ant-antlr) mvn(org.apache.ant:ant-apache-bcel) mvn(org.apache.ant:ant-apache-bsf) mvn(org.apache.ant:ant-apache-log4j) mvn(org.apache.ant:ant-apache-oro) mvn(org.apache.ant:ant-apache-regexp) mvn(org.apache.ant:ant-apache-resolver) mvn(org.apache.ant:ant-apache-xalan2) mvn(org.apache.ant:ant-commons-logging) mvn(org.apache.ant:ant-commons-net) mvn(org.apache.ant:ant-javamail) mvn(org.apache.ant:ant-jdepend) mvn(org.apache.ant:ant-jmf) mvn(org.apache.ant:ant-jsch) mvn(org.apache.ant:ant-junit) mvn(org.apache.ant:ant-junit4) mvn(org.apache.ant:ant-launcher) mvn(org.apache.ant:ant-nodeps) mvn(org.apache.ant:ant-parent) mvn(org.apache.ant:ant-swing) mvn(org.apache.ant:ant-testutil) ant-scripts: ant-scripts ant-javadoc: ant-javadoc ant-apache-resolver: ant-apache-resolver config(ant-apache-resolver) ant-apache-log4j: ant-apache-log4j ant-jakarta-log4j config(ant-apache-log4j) ant-jsch: ant-jsch config(ant-jsch) ant-apache-xalan2: ant-apache-xalan2 config(ant-apache-xalan2) ant-apache-bsf: ant-apache-bsf config(ant-apache-bsf) ant-swing: ant-swing config(ant-swing) MD5-sum check ------------- http://www.apache.org/dist/ant/source/apache-ant-1.8.4-src.tar.bz2 : CHECKSUM(SHA256) this package : 5de65f7ba3f67e436ffffcdc0a73f591d1006e9fb41af8632c1f1f84d4a3e0b1 CHECKSUM(SHA256) upstream package : 5de65f7ba3f67e436ffffcdc0a73f591d1006e9fb41af8632c1f1f84d4a3e0b1 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn ant -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires