Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Pom files have correct add_maven_depmap call Note: No add_maven_depmap calls found but pom files present See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find license-header.jar in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Test run failed [x]: Fully versioned dependency in subpackages, if present. Maven: [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: apache-resource-bundles-2-9.fc19.noarch.rpm apache-resource-bundles.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- apache-resource-bundles (rpmlib, GLIBC filtered): java jpackage-utils Provides -------- apache-resource-bundles: apache-resource-bundles mvn(org.apache:apache-incubator-disclaimer-resource-bundle) mvn(org.apache:apache-jar-resource-bundle) mvn(org.apache:apache-license-header-resource-bundle) mvn(org.apache:apache-resource-bundles) MD5-sum check ------------- http://repo1.maven.org/maven2/org/apache/apache-jar-resource-bundle/1.4/apache-jar-resource-bundle-1.4.pom : CHECKSUM(SHA256) this package : 4be9d9971464ca35fd23cb2325a6a5805596c572ee06c824b54f26c97c05167a CHECKSUM(SHA256) upstream package : 4be9d9971464ca35fd23cb2325a6a5805596c572ee06c824b54f26c97c05167a http://repo1.maven.org/maven2/org/apache/apache-license-header-resource-bundle/1.1/apache-license-header-resource-bundle-1.1-sources.jar : CHECKSUM(SHA256) this package : ec7e1424897ad4f8f4a8520f086c16e22657684ae24881235509ec4e57aa62a8 CHECKSUM(SHA256) upstream package : ec7e1424897ad4f8f4a8520f086c16e22657684ae24881235509ec4e57aa62a8 http://repo1.maven.org/maven2/org/apache/apache-resource-bundles/2/apache-resource-bundles-2.pom : CHECKSUM(SHA256) this package : 3b2fe045e96987b6a7f4dc44780a7b7676cc0f673947272d14c92c474eef3a34 CHECKSUM(SHA256) upstream package : 3b2fe045e96987b6a7f4dc44780a7b7676cc0f673947272d14c92c474eef3a34 http://repo1.maven.org/maven2/org/apache/apache-jar-resource-bundle/1.4/apache-jar-resource-bundle-1.4-sources.jar : CHECKSUM(SHA256) this package : adb7d1efac653be3d9e2f83896b27c7445bc592385632d3aa6aaa77987e1ffcf CHECKSUM(SHA256) upstream package : adb7d1efac653be3d9e2f83896b27c7445bc592385632d3aa6aaa77987e1ffcf http://repo1.maven.org/maven2/org/apache/apache-incubator-disclaimer-resource-bundle/1.1/apache-incubator-disclaimer-resource-bundle-1.1.pom : CHECKSUM(SHA256) this package : d408103eada1400f34253c7d4630cca00734eb006e7206e2a928ffd603292e74 CHECKSUM(SHA256) upstream package : d408103eada1400f34253c7d4630cca00734eb006e7206e2a928ffd603292e74 http://repo1.maven.org/maven2/org/apache/apache-license-header-resource-bundle/1.1/apache-license-header-resource-bundle-1.1.pom : CHECKSUM(SHA256) this package : 118ce2fc4f166b273d1a5f5c756f0db464c9a6eb7fedd4baba0a621b3ba0b5da CHECKSUM(SHA256) upstream package : 118ce2fc4f166b273d1a5f5c756f0db464c9a6eb7fedd4baba0a621b3ba0b5da http://repo1.maven.org/maven2/org/apache/apache-incubator-disclaimer-resource-bundle/1.1/apache-incubator-disclaimer-resource-bundle-1.1-sources.jar : CHECKSUM(SHA256) this package : d30be21d86530961e1e0d84a3b56411997aa67607fce864327ae82a8302258cb CHECKSUM(SHA256) upstream package : d30be21d86530961e1e0d84a3b56411997aa67607fce864327ae82a8302258cb Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn apache-resource-bundles -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires