Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - GConf schemas are properly installed Note: gconf file(s) in at-spi See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - update-desktop-database is invoked when required Note: desktop file(s) in at-spi See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package does not contain any libtool archives (.la) Note: at-spi : /usr/lib64/gtk-2.0/modules/at-spi-corba/modules/libatk- bridge.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop - Large documentation must go in a -doc subpackage. Note: Documentation size is 1566720 bytes in 161 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Rpath absent or only used for internal libs. Note: See rpmlint output [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in at-spi- devel , at-spi-python [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Test run failed [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} %define atk_version 1.29.2 %define gtk2_version 2.10.0 %define gail_version 1.9.0 %define libbonobo_version 2.4.0 %define orbit2_version 2.6.0 %define pango_version 1.2.0 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3112960 bytes in /usr/share 2764800 at-spi-devel-1.32.0-9.fc18.x86_64.rpm 348160 at- spi-1.32.0-9.fc18.x86_64.rpm Rpmlint ------- Checking: at-spi-1.32.0-9.fc18.x86_64.rpm at-spi-devel-1.32.0-9.fc18.x86_64.rpm at-spi-python-1.32.0-9.fc18.x86_64.rpm at-spi.x86_64: W: spelling-error Summary(en_US) Assistive -> Assertive, Massive, Passive at-spi.x86_64: W: spelling-error %description -l en_US assistive -> assertive, massive, passive at-spi.x86_64: W: invalid-url URL: http://developer.gnome.org/projects/gap/ HTTP Error 404: Not Found at-spi.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libcspi.so.0.10.11 ['/usr/lib64'] at-spi.x86_64: E: binary-or-shlib-defines-rpath /usr/libexec/at-spi-registryd ['/usr/lib64'] at-spi.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/gtk-2.0/modules/at-spi-corba/modules/libatk-bridge.so ['/usr/lib64'] at-spi.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/at-spi-registryd.desktop at-spi.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/at-spi.schemas at-spi.x86_64: E: incorrect-fsf-address /usr/share/doc/at-spi-1.32.0/COPYING at-spi.x86_64: W: dangerous-command-in-%pre rm at-spi.x86_64: W: dangerous-command-in-%post rm at-spi-devel.x86_64: W: invalid-url URL: http://developer.gnome.org/projects/gap/ HTTP Error 404: Not Found at-spi-python.x86_64: W: invalid-url URL: http://developer.gnome.org/projects/gap/ HTTP Error 404: Not Found at-spi-python.x86_64: W: no-documentation at-spi-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/pyatspi_corba/constants.py at-spi-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/pyatspi_corba/utils.py at-spi-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/pyatspi_corba/event.py at-spi-python.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/pyatspi_corba/registry.py 3 packages and 0 specfiles checked; 8 errors, 10 warnings. Requires -------- at-spi-python (rpmlib, GLIBC filtered): at-spi gnome-python2-bonobo pyorbit python python(abi) at-spi (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig GConf2 ORBit2 atk gail gtk2 libICE.so.6()(64bit) libORBit-2.so.0()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXtst.so.6()(64bit) libatk-1.0.so.0()(64bit) libbonobo libbonobo-2.so.0()(64bit) libbonobo-activation.so.4()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgconf-2.so.4()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libspi.so.0()(64bit) rtld(GNU_HASH) at-spi-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config ORBit2-devel at-spi atk-devel gail-devel gtk2-devel libbonobo-devel libcspi.so.0()(64bit) libloginhelper.so.0()(64bit) libspi.so.0()(64bit) pkgconfig pkgconfig(atk) pkgconfig(libbonobo-2.0) pkgconfig(libspi-1.0) Provides -------- at-spi-python: at-spi-python at-spi-python(x86-64) at-spi: Accessibility_LoginHelper_module.so()(64bit) Accessibility_module.so()(64bit) at-spi at-spi(x86-64) libatk-bridge.so()(64bit) libcspi.so.0()(64bit) libloginhelper.so.0()(64bit) libspi.so.0()(64bit) libtool(/usr/lib64/gtk-2.0/modules/at-spi-corba/modules/libatk-bridge.la) at-spi-devel: at-spi-devel at-spi-devel(x86-64) pkgconfig(cspi-1.0) pkgconfig(libloginhelper-1.0) pkgconfig(libspi-1.0) Unversioned so-files -------------------- at-spi: /usr/lib64/gtk-2.0/modules/at-spi-corba/modules/libatk-bridge.so at-spi: /usr/lib64/orbit-2.0/Accessibility_LoginHelper_module.so at-spi: /usr/lib64/orbit-2.0/Accessibility_module.so MD5-sum check ------------- http://download.gnome.org/sources/at-spi/1.32/at-spi-1.32.0.tar.bz2 : CHECKSUM(SHA256) this package : cc841dea746413eebadf0710dabec741450b37a06821c34526f505fe9d027039 CHECKSUM(SHA256) upstream package : cc841dea746413eebadf0710dabec741450b37a06821c34526f505fe9d027039 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn at-spi -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires