Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in audit-libs , audit-libs-devel , audit-libs-static , audit-libs-python , audispd- plugins [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 122880 bytes in 12 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Test run failed [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} %define WITH_SYSTEMD 1 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: audit-2.2.2-4.fc19.x86_64.rpm audit-libs-2.2.2-4.fc19.x86_64.rpm audit-libs-devel-2.2.2-4.fc19.x86_64.rpm audit-libs-static-2.2.2-4.fc19.x86_64.rpm audit-libs-python-2.2.2-4.fc19.x86_64.rpm audispd-plugins-2.2.2-4.fc19.x86_64.rpm audit.x86_64: W: only-non-binary-in-usr-lib audit.x86_64: E: non-standard-dir-perm /etc/audisp/plugins.d 0750L audit.x86_64: E: non-readable /etc/audit/audit.rules 0640L audit.x86_64: E: non-standard-dir-perm /var/log/audit 0750L audit.x86_64: E: non-standard-dir-perm /etc/audit 0750L audit.x86_64: E: non-readable /etc/audisp/plugins.d/syslog.conf 0640L audit.x86_64: E: incorrect-fsf-address /usr/share/doc/audit-2.2.2/COPYING audit.x86_64: E: non-readable /sbin/autrace 0750L audit.x86_64: E: non-standard-executable-perm /sbin/autrace 0750L audit.x86_64: E: non-readable /usr/lib/systemd/system/auditd.service 0640L audit.x86_64: E: non-readable /sbin/auditctl 0750L audit.x86_64: E: non-standard-executable-perm /sbin/auditctl 0750L audit.x86_64: E: non-readable /sbin/auditd 0750L audit.x86_64: E: non-standard-executable-perm /sbin/auditd 0750L audit.x86_64: E: non-readable /etc/audisp/audispd.conf 0640L audit.x86_64: E: non-readable /etc/audit/auditd.conf 0640L audit.x86_64: E: non-readable /sbin/audispd 0750L audit.x86_64: E: non-standard-executable-perm /sbin/audispd 0750L audit.x86_64: E: non-standard-dir-perm /etc/audisp 0750L audit.x86_64: E: non-readable /etc/audisp/plugins.d/af_unix.conf 0640L audit.x86_64: W: log-files-without-logrotate /var/log/audit audit-libs.x86_64: W: spelling-error Summary(en_US) libaudit -> lib audit, lib-audit, audibility audit-libs.x86_64: E: non-readable /etc/libaudit.conf 0640L audit-libs-devel.x86_64: W: spelling-error Summary(en_US) libaudit -> lib audit, lib-audit, audibility audit-libs-devel.x86_64: E: incorrect-fsf-address /usr/share/doc/audit-libs-devel-2.2.2/plugin/audisp-example.c audit-libs-static.x86_64: W: spelling-error Summary(en_US) libaudit -> lib audit, lib-audit, audibility audit-libs-static.x86_64: W: no-documentation audit-libs-python.x86_64: W: spelling-error Summary(en_US) libaudit -> lib audit, lib-audit, audibility audit-libs-python.x86_64: W: spelling-error %description -l en_US libaudit -> lib audit, lib-audit, audibility audit-libs-python.x86_64: W: spelling-error %description -l en_US libauparse -> sparseness audit-libs-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/_audit.so _audit.so()(64bit) audit-libs-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/auparse.so auparse.so()(64bit) audit-libs-python.x86_64: W: no-documentation audispd-plugins.x86_64: E: non-readable /sbin/audisp-remote 0750L audispd-plugins.x86_64: E: non-standard-executable-perm /sbin/audisp-remote 0750L audispd-plugins.x86_64: E: non-readable /sbin/audispd-zos-remote 0750L audispd-plugins.x86_64: E: non-standard-executable-perm /sbin/audispd-zos-remote 0750L audispd-plugins.x86_64: E: non-readable /etc/audisp/plugins.d/audispd-zos-remote.conf 0640L audispd-plugins.x86_64: E: non-readable /etc/audisp/plugins.d/au-prelude.conf 0640L audispd-plugins.x86_64: E: non-readable /sbin/audisp-prelude 0750L audispd-plugins.x86_64: E: non-standard-executable-perm /sbin/audisp-prelude 0750L audispd-plugins.x86_64: E: non-readable /etc/audisp/zos-remote.conf 0640L audispd-plugins.x86_64: E: non-readable /etc/audisp/plugins.d/au-remote.conf 0640L audispd-plugins.x86_64: E: non-standard-dir-perm /var/spool/audit 0700L audispd-plugins.x86_64: E: non-readable /etc/audisp/audisp-prelude.conf 0640L audispd-plugins.x86_64: E: non-readable /etc/audisp/audisp-remote.conf 0640L 6 packages and 0 specfiles checked; 34 errors, 12 warnings. Requires -------- audit (rpmlib, GLIBC filtered): /bin/sh audit-libs chkconfig config(audit) coreutils libaudit.so.1()(64bit) libauparse.so.0()(64bit) libc.so.6()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libwrap.so.0()(64bit) rtld(GNU_HASH) systemd-sysv systemd-units audit-libs-static (rpmlib, GLIBC filtered): kernel-headers audit-libs-python (rpmlib, GLIBC filtered): audit-libs libaudit.so.1()(64bit) libauparse.so.0()(64bit) libc.so.6()(64bit) python(abi) rtld(GNU_HASH) audit-libs (rpmlib, GLIBC filtered): /sbin/ldconfig config(audit-libs) libaudit.so.1()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) audispd-plugins (rpmlib, GLIBC filtered): audit audit-libs config(audispd-plugins) libaudit.so.1()(64bit) libauparse.so.0()(64bit) libc.so.6()(64bit) libcap-ng.so.0()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) libprelude.so.2()(64bit) libpthread.so.0()(64bit) openldap rtld(GNU_HASH) audit-libs-devel (rpmlib, GLIBC filtered): audit-libs kernel-headers libaudit.so.1()(64bit) libauparse.so.0()(64bit) Provides -------- audit: audit audit(x86-64) config(audit) audit-libs-static: audit-libs-static audit-libs-static(x86-64) audit-libs-python: _audit.so()(64bit) audit-libs-python audit-libs-python(x86-64) auparse.so()(64bit) audit-libs: audit-libs audit-libs(x86-64) config(audit-libs) libaudit.so.1()(64bit) libauparse.so.0()(64bit) audispd-plugins: audispd-plugins audispd-plugins(x86-64) config(audispd-plugins) audit-libs-devel: audit-libs-devel audit-libs-devel(x86-64) Unversioned so-files -------------------- audit-libs-python: /usr/lib64/python2.7/site-packages/_audit.so audit-libs-python: /usr/lib64/python2.7/site-packages/auparse.so MD5-sum check ------------- http://people.redhat.com/sgrubb/audit/audit-2.2.2.tar.gz : CHECKSUM(SHA256) this package : 8bc2b45a5f08f5df6cebcd5543f24b7e68e28b64da4b23f08de2c6616384302b CHECKSUM(SHA256) upstream package : 8bc2b45a5f08f5df6cebcd5543f24b7e68e28b64da4b23f08de2c6616384302b Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn audit -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires