Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - update-desktop-database is invoked when required Note: desktop file(s) in bacula-console-bat, bacula-traymonitor See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package does not contain any libtool archives (.la) Note: bacula-devel : /usr/lib64/libbac.la bacula-devel : /usr/lib64 /libbaccats-mysql.la bacula-devel : /usr/lib64/libbaccats-postgresql.la bacula-devel : /usr/lib64/libbaccats-sqlite3.la bacula-devel : /usr/lib64/libbaccats.la bacula-devel : /usr/lib64/libbaccfg.la bacula-devel : /usr/lib64/libbacfind.la bacula-devel : /usr/lib64/libbacpy.la bacula- devel : /usr/lib64/libbacsql.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in bacula-libs , bacula-libs-sql , bacula-common , bacula-director , bacula-storage , bacula-client , bacula-console , bacula-console-bat , bacula-traymonitor , bacula-devel , nagios-plugins-bacula [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 921600 bytes in 68 files. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1034240 bytes in /usr/share 266240 bacula-common-5.2.12-6.fc19.x86_64.rpm 10240 bacula- client-5.2.12-6.fc19.x86_64.rpm 256000 bacula- director-5.2.12-6.fc19.x86_64.rpm 20480 bacula- storage-5.2.12-6.fc19.x86_64.rpm 10240 bacula- console-5.2.12-6.fc19.x86_64.rpm 10240 bacula- traymonitor-5.2.12-6.fc19.x86_64.rpm 460800 bacula-console- bat-5.2.12-6.fc19.x86_64.rpm Rpmlint ------- Checking: bacula-libs-5.2.12-6.fc19.x86_64.rpm bacula-libs-sql-5.2.12-6.fc19.x86_64.rpm bacula-common-5.2.12-6.fc19.x86_64.rpm bacula-director-5.2.12-6.fc19.x86_64.rpm bacula-storage-5.2.12-6.fc19.x86_64.rpm bacula-client-5.2.12-6.fc19.x86_64.rpm bacula-console-5.2.12-6.fc19.x86_64.rpm bacula-console-bat-5.2.12-6.fc19.x86_64.rpm bacula-traymonitor-5.2.12-6.fc19.x86_64.rpm bacula-devel-5.2.12-6.fc19.x86_64.rpm nagios-plugins-bacula-5.2.12-6.fc19.x86_64.rpm bacula-libs.x86_64: W: obsolete-not-provided bacula-sysconfdir bacula-libs.x86_64: W: no-documentation bacula-libs.x86_64: W: one-line-command-in-%post /sbin/ldconfig bacula-libs-sql.x86_64: E: no-ldconfig-symlink /usr/lib64/libbaccats-sqlite3-5.2.12.so bacula-libs-sql.x86_64: E: no-ldconfig-symlink /usr/lib64/libbaccats-postgresql-5.2.12.so bacula-libs-sql.x86_64: E: no-ldconfig-symlink /usr/lib64/libbaccats-mysql-5.2.12.so bacula-libs-sql.x86_64: W: no-documentation bacula-common.x86_64: W: obsolete-not-provided bacula-sysconfdir bacula-common.x86_64: E: non-standard-dir-perm /var/log/bacula 0750L bacula-common.x86_64: E: non-standard-dir-perm /var/spool/bacula 0750L bacula-common.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/bacula bacula-common.x86_64: W: no-manual-page-for-binary bacula-checkconf bacula-director.x86_64: W: only-non-binary-in-usr-lib bacula-director.x86_64: E: non-readable /etc/bacula/query.sql 0640L bacula-director.x86_64: E: non-readable /etc/bacula/bacula-dir.conf 0640L bacula-director.x86_64: E: script-without-shebang /usr/lib/systemd/system/bacula-dir.service bacula-storage.x86_64: W: only-non-binary-in-usr-lib bacula-storage.x86_64: E: script-without-shebang /usr/libexec/bacula/mtx-changer.conf bacula-storage.x86_64: E: script-without-shebang /usr/lib/systemd/system/bacula-sd.service bacula-storage.x86_64: E: non-readable /etc/bacula/bacula-sd.conf 0640L bacula-client.x86_64: E: non-readable /etc/bacula/bacula-fd.conf 0640L bacula-client.x86_64: E: script-without-shebang /usr/lib/systemd/system/bacula-fd.service bacula-console.x86_64: W: obsolete-not-provided bacula-console-gnome bacula-console.x86_64: W: obsolete-not-provided bacula-console-wxwidgets bacula-console-bat.x86_64: W: install-file-in-docs /usr/share/doc/bacula-console-bat-5.2.12/INSTALL bacula-traymonitor.x86_64: W: no-documentation bacula-traymonitor.x86_64: W: no-manual-page-for-binary bacula-tray-monitor bacula-devel.x86_64: W: no-dependency-on bacula/bacula-libs/libbacula bacula-devel.x86_64: W: no-documentation nagios-plugins-bacula.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 14 errors, 16 warnings. Requires -------- bacula-console (rpmlib, GLIBC filtered): config(bacula-console) libbac-5.2.12.so()(64bit) libbaccfg-5.2.12.so()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libreadline.so.6()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libtinfo.so.5()(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) bacula-libs-sql (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libcrypt.so.1()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libmysqlclient.so.18()(64bit) libmysqlclient.so.18(libmysqlclient_16)(64bit) libpq.so.5()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) bacula-libs (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libcap.so.2()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libutil.so.1()(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) bacula-client (rpmlib, GLIBC filtered): /bin/sh bacula-common(x86-64) config(bacula-client) libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libbac-5.2.12.so()(64bit) libbaccfg-5.2.12.so()(64bit) libbacfind-5.2.12.so()(64bit) libbacpy-5.2.12.so()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) liblzo2.so.2()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libutil.so.1()(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) systemd systemd-sysv bacula-traymonitor (rpmlib, GLIBC filtered): config(bacula-traymonitor) libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libbac-5.2.12.so()(64bit) libbaccfg-5.2.12.so()(64bit) libbacfind-5.2.12.so()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) bacula-director (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env /usr/bin/perl bacula-common(x86-64) config(bacula-director) libbac-5.2.12.so()(64bit) libbaccats-5.2.12.so()(64bit) libbaccfg-5.2.12.so()(64bit) libbacfind-5.2.12.so()(64bit) libbacpy-5.2.12.so()(64bit) libbacsql-5.2.12.so()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libutil.so.1()(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) logwatch perl(Logwatch) perl(POSIX) perl(strict) rtld(GNU_HASH) systemd systemd-sysv bacula-console-bat (rpmlib, GLIBC filtered): config(bacula-console-bat) libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libbac-5.2.12.so()(64bit) libbaccfg-5.2.12.so()(64bit) libbacfind-5.2.12.so()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) bacula-storage (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python bacula-common(x86-64) config(bacula-storage) libbac-5.2.12.so()(64bit) libbaccats-5.2.12.so()(64bit) libbaccfg-5.2.12.so()(64bit) libbacfind-5.2.12.so()(64bit) libbacpy-5.2.12.so()(64bit) libbacsql-5.2.12.so()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) liblzo2.so.2()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libutil.so.1()(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) systemd systemd-sysv nagios-plugins-bacula (rpmlib, GLIBC filtered): libbac-5.2.12.so()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) bacula-common (rpmlib, GLIBC filtered): /bin/sh config(bacula-common) shadow-utils bacula-devel (rpmlib, GLIBC filtered): Provides -------- bacula-console: bacula-console bacula-console(x86-64) config(bacula-console) bacula-libs-sql: bacula-libs-mysql bacula-libs-postgresql bacula-libs-sql bacula-libs-sql(x86-64) bacula-libs-sqlite libbaccats-5.2.12.so()(64bit) libbacsql-5.2.12.so()(64bit) bacula-libs: bacula-libs bacula-libs(x86-64) libbac-5.2.12.so()(64bit) libbaccfg-5.2.12.so()(64bit) libbacfind-5.2.12.so()(64bit) libbacpy-5.2.12.so()(64bit) bacula-client: bacula-client bacula-client(x86-64) bpipe-fd.so()(64bit) config(bacula-client) bacula-traymonitor: bacula-traymonitor bacula-traymonitor(x86-64) config(bacula-traymonitor) bacula-director: bacula-director bacula-director(x86-64) bacula-director-common bacula-director-mysql bacula-director-postgresql bacula-director-sqlite config(bacula-director) bacula-console-bat: bacula-console-bat bacula-console-bat(x86-64) config(bacula-console-bat) bacula-storage: bacula-storage bacula-storage(x86-64) bacula-storage-common bacula-storage-mysql bacula-storage-postgresql bacula-storage-sqlite config(bacula-storage) nagios-plugins-bacula: nagios-plugins-bacula nagios-plugins-bacula(x86-64) bacula-common: bacula-common bacula-common(x86-64) config(bacula-common) group(bacula) user(bacula) bacula-devel: bacula-devel bacula-devel(x86-64) Unversioned so-files -------------------- bacula-libs: /usr/lib64/libbac-5.2.12.so bacula-libs: /usr/lib64/libbaccfg-5.2.12.so bacula-libs: /usr/lib64/libbacfind-5.2.12.so bacula-libs: /usr/lib64/libbacpy-5.2.12.so bacula-libs-sql: /usr/lib64/libbaccats-mysql-5.2.12.so bacula-libs-sql: /usr/lib64/libbaccats-mysql.so bacula-libs-sql: /usr/lib64/libbaccats-postgresql-5.2.12.so bacula-libs-sql: /usr/lib64/libbaccats-postgresql.so bacula-libs-sql: /usr/lib64/libbaccats-sqlite3-5.2.12.so bacula-libs-sql: /usr/lib64/libbaccats-sqlite3.so bacula-libs-sql: /usr/lib64/libbacsql-5.2.12.so bacula-client: /usr/lib64/bacula/bpipe-fd.so MD5-sum check ------------- http://www.bacula.org/downloads/Bacula-5.2.12/bacula-5.2.12.tar.gz : CHECKSUM(SHA256) this package : 360435634e28881b3fedb0dc1901b9c9be1895ce1e39c9737262b25f44513887 CHECKSUM(SHA256) upstream package : 360435634e28881b3fedb0dc1901b9c9be1895ce1e39c9737262b25f44513887 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn bacula -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires