Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package is not relocatable. Note: Package has a "Prefix:" tag See: http://fedoraproject.org/wiki/Packaging/Guidelines#RelocatablePackages - Large documentation must go in a -doc subpackage. Note: Documentation size is 4587520 bytes in 75 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config %verify(not link) /var/named/named.ca %config %verify(not link) /var/named/named.localhost %config %verify(not link) /var/named/named.loopback %config %verify(not link) /var/named/named.empty [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in bind-pkcs11 , bind-sdb , bind-libs-lite , bind-libs , bind-license , bind-utils , bind-devel , bind-lite-devel , bind-chroot [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4782080 bytes in /usr/share 30720 bind-sdb-9.9.2-6.P1.fc19.x86_64.rpm 40960 bind- pkcs11-9.9.2-6.P1.fc19.x86_64.rpm 4587520 bind-9.9.2-6.P1.fc19.x86_64.rpm 92160 bind-devel-9.9.2-6.P1.fc19.x86_64.rpm 30720 bind- utils-9.9.2-6.P1.fc19.x86_64.rpm Rpmlint ------- Checking: bind-9.9.2-6.P1.fc19.x86_64.rpm bind-pkcs11-9.9.2-6.P1.fc19.x86_64.rpm bind-sdb-9.9.2-6.P1.fc19.x86_64.rpm bind-libs-lite-9.9.2-6.P1.fc19.x86_64.rpm bind-libs-9.9.2-6.P1.fc19.x86_64.rpm bind-license-9.9.2-6.P1.fc19.noarch.rpm bind-utils-9.9.2-6.P1.fc19.x86_64.rpm bind-devel-9.9.2-6.P1.fc19.x86_64.rpm bind-lite-devel-9.9.2-6.P1.fc19.x86_64.rpm bind-chroot-9.9.2-6.P1.fc19.x86_64.rpm bind.x86_64: W: self-obsoletion dnssec-conf < 1.27-2 obsoletes dnssec-conf = 1.27-1 bind.x86_64: W: only-non-binary-in-usr-lib bind.x86_64: W: conffile-without-noreplace-flag /var/named/named.ca bind.x86_64: W: conffile-without-noreplace-flag /var/named/named.loopback bind.x86_64: W: conffile-without-noreplace-flag /var/named/named.empty bind.x86_64: W: conffile-without-noreplace-flag /var/named/named.localhost bind.x86_64: E: non-readable /var/named/named.ca 0640L bind.x86_64: E: non-standard-dir-perm /var/named/dynamic 0770L bind.x86_64: E: non-root-user-log-file /var/log/named.log named bind.x86_64: E: non-root-group-log-file /var/log/named.log named bind.x86_64: E: non-standard-dir-perm /var/named/data 0770L bind.x86_64: E: non-standard-dir-perm /etc/named 0750L bind.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/bind-9.9.2/arm/isc-logo.eps bind.x86_64: E: non-standard-dir-perm /var/named 0750L bind.x86_64: W: non-conffile-in-etc /etc/tmpfiles.d/named.conf bind.x86_64: E: non-readable /var/named/named.loopback 0640L bind.x86_64: E: non-readable /etc/rndc.key 0640L bind.x86_64: E: non-standard-dir-perm /var/named/slaves 0770L bind.x86_64: E: non-readable /var/named/named.empty 0640L bind.x86_64: E: non-readable /etc/named.conf 0640L bind.x86_64: E: non-readable /etc/named.rfc1912.zones 0640L bind.x86_64: E: non-readable /etc/rndc.conf 0640L bind.x86_64: E: non-readable /var/named/named.localhost 0640L bind.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/named bind.x86_64: E: non-readable /etc/logrotate.d/named 0640L bind.x86_64: W: FSSTND-dir-in-var /var/named/named.ca bind.x86_64: W: dangerous-command-in-%post chown bind.x86_64: W: dangerous-command-in-%trigger chown bind-pkcs11.x86_64: W: spelling-error %description -l en_US rsa -> rs, Ursa, rs a bind-pkcs11.x86_64: W: spelling-error %description -l en_US keystore -> keystone, key store, key-store bind-pkcs11.x86_64: W: spelling-error %description -l en_US opencryptoki -> encryption bind-pkcs11.x86_64: W: spelling-error %description -l en_US zsk -> ask, SK bind-pkcs11.x86_64: W: spelling-error %description -l en_US ksk -> ks, ask, ks k bind-pkcs11.x86_64: W: spelling-error %description -l en_US keytag -> key tag, key-tag, Maytag bind-pkcs11.x86_64: W: file-not-utf8 /usr/share/doc/bind-pkcs11-9.9.2/COPYRIGHT bind-sdb.x86_64: W: spelling-error Summary(en_US) backends -> back ends, back-ends, backhands bind-sdb.x86_64: W: spelling-error %description -l en_US ldapdb -> lapdog bind-sdb.x86_64: W: spelling-error %description -l en_US postgreSQL -> postgraduate bind-sdb.x86_64: W: spelling-error %description -l en_US pgsqldb bind-sdb.x86_64: W: spelling-error %description -l en_US sqlite -> sq lite, sq-lite, satellite bind-sdb.x86_64: W: spelling-error %description -l en_US sqlitedb -> solicited bind-sdb.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically bind-sdb.x86_64: W: spelling-error %description -l en_US dirdb -> redbird bind-sdb.x86_64: W: only-non-binary-in-usr-lib bind-libs-lite.x86_64: W: no-documentation bind-libs.x86_64: W: spelling-error %description -l en_US utils -> tills bind-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libisc.so.92.1.0 exit@GLIBC_2.2.5 bind-libs.x86_64: W: no-documentation bind-license.noarch: W: file-not-utf8 /usr/share/doc/bind-license-9.9.2/COPYRIGHT bind-utils.x86_64: W: non-conffile-in-etc /etc/trusted-key.key bind-lite-devel.x86_64: W: no-dependency-on bind-lite/bind-lite-libs/libbind-lite bind-lite-devel.x86_64: W: no-documentation bind-chroot.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment bind-chroot.x86_64: W: spelling-error %description -l en_US kas -> keys, ks, as bind-chroot.x86_64: W: spelling-error %description -l en_US fi -> phi, fee, if bind-chroot.x86_64: W: spelling-error %description -l en_US muni -> mini, mun, uni bind-chroot.x86_64: W: spelling-error %description -l en_US cz -> CZ, c, z bind-chroot.x86_64: W: only-non-binary-in-usr-lib bind-chroot.x86_64: W: no-documentation bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/etc/pki/dnssec-keys 0750L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/usr/lib64/bind 0750L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/var/run 0750L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot 0750L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/var/tmp 0770L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/etc/pki 0750L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/var/run/named 0770L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/etc/named 0750L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/var 0750L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/usr/lib64 0770L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/var/log 0770L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/etc 0750L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/dev 0750L bind-chroot.x86_64: E: non-readable /var/named/chroot/etc/named.conf 0640L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/usr 0770L bind-chroot.x86_64: E: non-standard-dir-perm /var/named/chroot/var/named 0750L bind-chroot.x86_64: W: FSSTND-dir-in-var /var/named/chroot/etc/pki/dnssec-keys bind-chroot.x86_64: W: dangerous-command-in-%post rm bind-chroot.x86_64: W: dangerous-command-in-%preun rm 10 packages and 0 specfiles checked; 33 errors, 45 warnings. Requires -------- bind-pkcs11 (rpmlib, GLIBC filtered): engine_pkcs11 libc.so.6()(64bit) libdl.so.2()(64bit) opensc rtld(GNU_HASH) bind-sdb (rpmlib, GLIBC filtered): /bin/sh bind config(bind-sdb) libbind9.so.90()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libdb-4.8.so()(64bit) libdl.so.2()(64bit) libdns.so.95()(64bit) libgssapi_krb5.so.2()(64bit) libisc.so.92()(64bit) libisccc.so.90()(64bit) libisccfg.so.90()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) liblwres.so.90()(64bit) libm.so.6()(64bit) libmysqlclient.so.18()(64bit) libmysqlclient.so.18(libmysqlclient_16)(64bit) libpq.so.5()(64bit) libpthread.so.0()(64bit) libsqlite3.so.0()(64bit) libssl.so.10()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) systemd-units bind-chroot (rpmlib, GLIBC filtered): /bin/bash /bin/sh bind config(bind-chroot) grep systemd-units bind-devel (rpmlib, GLIBC filtered): /bin/sh bind-libs libbind9.so.90()(64bit) libdns.so.95()(64bit) libisc.so.92()(64bit) libisccc.so.90()(64bit) libisccfg.so.90()(64bit) liblwres.so.90()(64bit) bind-libs (rpmlib, GLIBC filtered): /sbin/ldconfig bind-license libc.so.6()(64bit) libcap.so.2()(64bit) libcom_err.so.2()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libdns.so.95()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libisc.so.92()(64bit) libisccc.so.90()(64bit) libisccfg.so.90()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) bind (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/python bind-libs config(bind) coreutils grep libbind9.so.90()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcom_err.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libdns.so.95()(64bit) libgssapi_krb5.so.2()(64bit) libisc.so.92()(64bit) libisccc.so.90()(64bit) libisccfg.so.90()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) liblwres.so.90()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) shadow-utils systemd systemd-units bind-utils (rpmlib, GLIBC filtered): libbind9.so.90()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libcom_err.so.2()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libdns.so.95()(64bit) libgssapi_krb5.so.2()(64bit) libidn.so.11()(64bit) libidn.so.11(LIBIDN_1.0)(64bit) libisc.so.92()(64bit) libisccc.so.90()(64bit) libisccfg.so.90()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) liblwres.so.90()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) bind-license (rpmlib, GLIBC filtered): bind-lite-devel (rpmlib, GLIBC filtered): bind-libs-lite libdns-export.so.95()(64bit) libirs-export.so.90()(64bit) libisc-export.so.92()(64bit) libisccfg-export.so.90()(64bit) bind-libs-lite (rpmlib, GLIBC filtered): /sbin/ldconfig bind-license libc.so.6()(64bit) libcap.so.2()(64bit) libcom_err.so.2()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libdns-export.so.95()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libisc-export.so.92()(64bit) libisccfg-export.so.90()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- bind-pkcs11: bind-pkcs11 bind-pkcs11(x86-64) bind-sdb: bind-sdb bind-sdb(x86-64) config(bind-sdb) bind-chroot: bind-chroot bind-chroot(x86-64) config(bind-chroot) bind-devel: bind-devel bind-devel(x86-64) bind-libbind-devel bind-libs: bind-libs bind-libs(x86-64) libbind9.so.90()(64bit) libdns.so.95()(64bit) libisc.so.92()(64bit) libisccc.so.90()(64bit) libisccfg.so.90()(64bit) liblwres.so.90()(64bit) bind: bind bind(x86-64) bind-config caching-nameserver config(bind) dnssec-conf bind-utils: bind-utils bind-utils(x86-64) bind-license: bind-license bind-lite-devel: bind-lite-devel bind-lite-devel(x86-64) bind-libs-lite: bind-libbind-devel bind-libs-lite bind-libs-lite(x86-64) libdns-export.so.95()(64bit) libirs-export.so.90()(64bit) libisc-export.so.92()(64bit) libisccfg-export.so.90()(64bit) MD5-sum check ------------- ftp://ftp.isc.org/isc/bind9/9.9.2-P1/bind-9.9.2-P1.tar.gz : CHECKSUM(SHA256) this package : 4bce7c020402623333b655be5167ae8c52f30a6bfe9750caa3ab70da7d90219c CHECKSUM(SHA256) upstream package : 4bce7c020402623333b655be5167ae8c52f30a6bfe9750caa3ab70da7d90219c Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn bind -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires