Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain any libtool archives (.la) Note: cairo-tools : /usr/lib64/cairo/cairo-fdr.la cairo-tools : /usr/lib64/cairo/cairo-sphinx.la cairo-tools : /usr/lib64/cairo/libcairo- trace.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries - Large documentation must go in a -doc subpackage. Note: Documentation size is 2211840 bytes in 10 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cairo-devel , cairo-gobject , cairo-gobject-devel , cairo-tools [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define pixman_version 0.18.4 %define freetype_version 2.1.9 %define fontconfig_version 2.2.95 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4024320 bytes in /usr/share 3665920 cairo-devel-1.12.10-1.fc19.x86_64.rpm 358400 cairo-1.12.10-1.fc19.x86_64.rpm Rpmlint ------- Checking: cairo-1.12.10-1.fc19.x86_64.rpm cairo-devel-1.12.10-1.fc19.x86_64.rpm cairo-gobject-1.12.10-1.fc19.x86_64.rpm cairo-gobject-devel-1.12.10-1.fc19.x86_64.rpm cairo-tools-1.12.10-1.fc19.x86_64.rpm cairo.x86_64: W: no-manual-page-for-binary cairo-sphinx cairo-gobject.x86_64: W: no-documentation cairo-gobject-devel.x86_64: W: no-documentation cairo-tools.x86_64: W: no-documentation cairo-tools.x86_64: W: devel-file-in-non-devel-package /usr/lib64/cairo/libcairo-trace.so cairo-tools.x86_64: W: no-manual-page-for-binary cairo-trace 5 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- cairo (rpmlib, GLIBC filtered): /sbin/ldconfig libEGL.so.1()(64bit) libGL.so.1()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXrender.so.1()(64bit) libc.so.6()(64bit) libcairo-script-interpreter.so.2()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libglib-2.0.so.0()(64bit) libm.so.6()(64bit) libpixman-1.so.0()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libxcb-render.so.0()(64bit) libxcb-shm.so.0()(64bit) libxcb.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) cairo-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cairo fontconfig-devel freetype-devel libXrender-devel libcairo-script-interpreter.so.2()(64bit) libcairo.so.2()(64bit) libpng-devel pixman-devel pkgconfig(cairo) pkgconfig(cairo-xlib) pkgconfig(egl) pkgconfig(fontconfig) pkgconfig(freetype2) pkgconfig(gl) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) pkgconfig(libpng) pkgconfig(pixman-1) pkgconfig(x11) pkgconfig(xcb) pkgconfig(xcb-render) pkgconfig(xcb-shm) pkgconfig(xext) pkgconfig(xrender) cairo-gobject-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cairo-devel cairo-gobject libcairo-gobject.so.2()(64bit) pkgconfig(cairo) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) cairo-gobject (rpmlib, GLIBC filtered): /sbin/ldconfig cairo libEGL.so.1()(64bit) libGL.so.1()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXrender.so.1()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libpixman-1.so.0()(64bit) libpng15.so.15()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libxcb-render.so.0()(64bit) libxcb-shm.so.0()(64bit) libxcb.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) cairo-tools (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libcairo-trace.so.0()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- cairo: cairo cairo(x86-64) libcairo-script-interpreter.so.2()(64bit) libcairo.so.2()(64bit) cairo-devel: cairo-devel cairo-devel(x86-64) pkgconfig(cairo) pkgconfig(cairo-egl) pkgconfig(cairo-fc) pkgconfig(cairo-ft) pkgconfig(cairo-gl) pkgconfig(cairo-glx) pkgconfig(cairo-pdf) pkgconfig(cairo-png) pkgconfig(cairo-ps) pkgconfig(cairo-script) pkgconfig(cairo-svg) pkgconfig(cairo-tee) pkgconfig(cairo-xcb) pkgconfig(cairo-xcb-shm) pkgconfig(cairo-xlib) pkgconfig(cairo-xlib-xrender) cairo-gobject-devel: cairo-gobject-devel cairo-gobject-devel(x86-64) pkgconfig(cairo-gobject) cairo-gobject: cairo-gobject cairo-gobject(x86-64) libcairo-gobject.so.2()(64bit) cairo-tools: cairo-fdr.so.0()(64bit) cairo-sphinx.so.0()(64bit) cairo-tools cairo-tools(x86-64) libcairo-trace.so.0()(64bit) Unversioned so-files -------------------- cairo-tools: /usr/lib64/cairo/cairo-fdr.so cairo-tools: /usr/lib64/cairo/cairo-sphinx.so cairo-tools: /usr/lib64/cairo/libcairo-trace.so MD5-sum check ------------- http://cairographics.org/releases/cairo-1.12.10.tar.xz : CHECKSUM(SHA256) this package : f1581aef210f6caa9cf42875fb66ab3b47a32db9436bdfa9913b9bbd5034b03b CHECKSUM(SHA256) upstream package : f1581aef210f6caa9cf42875fb66ab3b47a32db9436bdfa9913b9bbd5034b03b Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn cairo -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires