Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in colord-libs See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - glib-compile-schemas is run if required Note: gschema file(s) in colord See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/colord.conf [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in colord-libs , colord-devel , colord-devel-docs , colord-extra-profiles [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 92160 bytes in 5 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define enable_print_profiles 0 %define build_print_profiles %{?enable_print_profiles} %define build_print_profiles 0 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1290240 bytes in /usr/share 901120 colord-0.1.28-2.fc19.x86_64.rpm 358400 colord- devel-0.1.28-2.fc19.x86_64.rpm 30720 colord-libs-0.1.28-2.fc19.x86_64.rpm Rpmlint ------- Checking: colord-0.1.28-2.fc19.x86_64.rpm colord-libs-0.1.28-2.fc19.x86_64.rpm colord-devel-0.1.28-2.fc19.x86_64.rpm colord-devel-docs-0.1.28-2.fc19.noarch.rpm colord-extra-profiles-0.1.28-2.fc19.noarch.rpm colord.x86_64: W: self-obsoletion shared-color-profiles <= 0.1.6-2 obsoletes shared-color-profiles colord.x86_64: W: conffile-without-noreplace-flag /etc/colord.conf colord.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/colormgr-completion.bash colord.x86_64: W: non-standard-uid /var/lib/colord colord colord.x86_64: W: non-standard-gid /var/lib/colord colord colord.x86_64: W: non-standard-uid /var/lib/colord/icc colord colord.x86_64: W: non-standard-gid /var/lib/colord/icc colord colord.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.ColorManager.conf colord-libs.x86_64: E: library-without-ldconfig-postin /usr/lib64/libcolord.so.1.0.16 colord-devel.x86_64: W: no-documentation colord-extra-profiles.noarch: W: self-obsoletion shared-color-profiles-extra <= 0.1.6-2 obsoletes shared-color-profiles-extra colord-extra-profiles.noarch: W: no-documentation 5 packages and 0 specfiles checked; 1 errors, 11 warnings. Requires -------- colord-extra-profiles (rpmlib, GLIBC filtered): colord colord-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config colord colord-libs libcolord.so.1()(64bit) pkgconfig(dbus-1) pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) pkgconfig(gthread-2.0) pkgconfig(lcms2) colord-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) liblcms2.so.2()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) colord (rpmlib, GLIBC filtered): /bin/sh color-filesystem config(colord) libc.so.6()(64bit) libcolord.so.1()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgudev-1.0.so.0()(64bit) libgusb.so.2()(64bit) liblcms2.so.2()(64bit) libm.so.6()(64bit) libpolkit-gobject-1.so.0()(64bit) libpthread.so.0()(64bit) libsqlite3.so.0()(64bit) libsystemd-login.so.0()(64bit) libsystemd-login.so.0(LIBSYSTEMD_LOGIN_31)(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) shadow-utils systemd-units colord-devel-docs (rpmlib, GLIBC filtered): colord Provides -------- colord-extra-profiles: colord-extra-profiles shared-color-profiles-extra colord-devel: colord-devel colord-devel(x86-64) pkgconfig(colord) colord-libs: colord-libs colord-libs(x86-64) libcolord.so.1()(64bit) colord: colord colord(x86-64) config(colord) libcd_plugin_camera.so()(64bit) libcd_plugin_scanner.so()(64bit) libcolord_sensor_argyll.so()(64bit) libcolord_sensor_colorhug.so()(64bit) libcolord_sensor_dummy.so()(64bit) libcolord_sensor_huey.so()(64bit) shared-color-profiles colord-devel-docs: colord-devel-docs Unversioned so-files -------------------- colord: /usr/lib64/colord-plugins/libcd_plugin_camera.so colord: /usr/lib64/colord-plugins/libcd_plugin_scanner.so colord: /usr/lib64/colord-sensors/libcolord_sensor_argyll.so colord: /usr/lib64/colord-sensors/libcolord_sensor_colorhug.so colord: /usr/lib64/colord-sensors/libcolord_sensor_dummy.so colord: /usr/lib64/colord-sensors/libcolord_sensor_huey.so MD5-sum check ------------- http://www.freedesktop.org/software/colord/releases/colord-0.1.28.tar.xz : CHECKSUM(SHA256) this package : b165be944eb60aedb3e16d04336643dd9b4945d034c899473583b5a44b9cbcdd CHECKSUM(SHA256) upstream package : b165be944eb60aedb3e16d04336643dd9b4945d034c899473583b5a44b9cbcdd Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn colord -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires