Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in control-center See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in control- center-filesystem [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in control-center [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 266240 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define gettext_package gnome-control-center-2.0 %define glib2_version 2.31.0 %define gtk3_version 3.5.13 %define gsd_version 3.6.0 %define gnome_desktop_version 3.5.91 %define desktop_file_utils_version 0.9 %define redhat_menus_version 1.8 %define gnome_menus_version 2.11.1 %define libXrandr_version 1.2.99 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: The placement of pkgconfig(.pc) files are correct. Note: control-center : /usr/share/pkgconfig/gnome-keybindings.pc [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 12236800 bytes in /usr/share 10240 control-center-filesystem-3.7.4-2.fc19.x86_64.rpm 12226560 control- center-3.7.4-2.fc19.x86_64.rpm Rpmlint ------- Checking: control-center-3.7.4-2.fc19.x86_64.rpm control-center-filesystem-3.7.4-2.fc19.x86_64.rpm control-center.x86_64: E: explicit-lib-dependency alsa-lib control-center.x86_64: W: devel-file-in-non-devel-package /usr/share/pkgconfig/gnome-keybindings.pc control-center.x86_64: W: non-conffile-in-etc /etc/xdg/menus/gnomecc.menu control-center.x86_64: E: non-executable-script /usr/share/bash-completion/completions/gnome_control_center_completion.bash 0644L /bin/bash control-center-filesystem.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 2 errors, 3 warnings. Requires -------- control-center-filesystem (rpmlib, GLIBC filtered): control-center (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pkg-config accountsservice alsa-lib control-center-filesystem cups-pk-helper dbus-x11 desktop-file-utils glx-utils gnome-desktop3 gnome-icon-theme gnome-icon-theme-symbolic gnome-menus gnome-settings-daemon iso-codes libX11.so.6()(64bit) libXcomposite.so.1()(64bit) libXdamage.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXi.so.6()(64bit) libXrandr libaccountsservice.so.0()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libcanberra-gtk3.so.0()(64bit) libcanberra.so.0()(64bit) libcheese-gtk.so.23()(64bit) libcheese.so.7()(64bit) libclutter-1.0.so.0()(64bit) libclutter-gtk-1.0.so.0()(64bit) libcogl-pango.so.0()(64bit) libcogl.so.11()(64bit) libcolord.so.1()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcups.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libfontconfig.so.1()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgnome-bluetooth.so.11()(64bit) libgnome-desktop-3.so.5()(64bit) libgnome-menu-3.so.0()(64bit) libgoa-1.0.so.0()(64bit) libgoa-backend-1.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgssapi_krb5.so.2()(64bit) libgstreamer-1.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtop-2.0.so.7()(64bit) libibus-1.0.so.5()(64bit) libjson-glib-1.0.so.0()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libm.so.6()(64bit) libnm-glib.so.4()(64bit) libnm-gtk.so.0()(64bit) libnm-util.so.2()(64bit) libnotify.so.4()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpolkit-gobject-1.so.0()(64bit) libpthread.so.0()(64bit) libpulse-mainloop-glib.so.0()(64bit) libpulse-mainloop-glib.so.0(PULSE_0)(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) libpwquality.so.1()(64bit) libpwquality.so.1(LIBPWQUALITY_1.0)(64bit) libupower-glib.so.1()(64bit) libwacom.so.2()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libz.so.1()(64bit) nm-connection-editor redhat-menus rtld(GNU_HASH) shared-mime-info Provides -------- control-center-filesystem: control-center-filesystem control-center-filesystem(x86-64) control-center: accountsdialog control-center control-center(x86-64) control-center-devel control-center-extra desktop-effects pkgconfig(gnome-keybindings) MD5-sum check ------------- http://download.gnome.org/sources/gnome-control-center/3.7/gnome-control-center-3.7.4.tar.xz : CHECKSUM(SHA256) this package : c01138ae7306f7fb1576c47b79bba24554dfbb41cd9fb095272927c4b6f02e02 CHECKSUM(SHA256) upstream package : c01138ae7306f7fb1576c47b79bba24554dfbb41cd9fb095272927c4b6f02e02 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn control-center -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires