Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/ClockerPlugIn/ClockerListener.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/ClockerPlugIn/ClockerModel.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/ClockerPlugIn/ClockerXmlHook.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/ClockerPlugIn/Timer.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/ClockerPlugIn/WinNtTimer.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/DumperPlugIn/DumperListener.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/BaseTestCase.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/CoreSuite.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/cppunittest/ExceptionTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/ExceptionTestCaseDecoratorTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/ExtensionSuite.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/FailureException.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/HelperMacrosTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/HelperSuite.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/cppunittest/MessageTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/MockFunctor.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/MockProtector.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/cppunittest/MockTestCase.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/MockTestListener.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/OrthodoxTest.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/cppunittest/OutputSuite.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/RepeatedTestTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/StringToolsTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/SubclassedTestCase.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/SynchronizedTestResult.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/TestAssertTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/TestCallerTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/TestCaseTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/TestDecoratorTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/TestFailureTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/TestPathTest.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/cppunittest/TestResultCollectorTest.h cppunit- doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/TestResultTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/TestSetUpTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/TestSuiteTest.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/cppunittest/TestTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/ToolsSuite.h cppunit- doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/TrackedTestCase.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/UnitTestToolSuite.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/XmlElementTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/XmlOutputterTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/XmlUniformiser.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/cppunittest/XmlUniformiserTest.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/cppunittest/assertion_traitsTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/hierarchy/BoardGame.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/hierarchy/BoardGameTest.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/hierarchy/Chess.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/hierarchy/ChessTest.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/money/Money.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/money/MoneyTest.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/money/StdAfx.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/msvc6/CppUnitTestApp/CppUnitTestApp.h cppunit- doc : /usr/share/doc/cppunit- doc-1.12.1/examples/msvc6/CppUnitTestApp/CppUnitTestAppDlg.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/msvc6/CppUnitTestApp/Resource.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/msvc6/CppUnitTestApp/StdAfx.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/msvc6/HostApp/ExampleTestCase.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/msvc6/HostApp/HostApp.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/msvc6/HostApp/HostAppDoc.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/msvc6/HostApp/HostAppView.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/msvc6/HostApp/MainFrm.h cppunit-doc : /usr/share/doc /cppunit-doc-1.12.1/examples/msvc6/HostApp/Resource.h cppunit-doc : /usr/share/doc/cppunit-doc-1.12.1/examples/msvc6/HostApp/StdAfx.h cppunit- doc : /usr/share/doc/cppunit-doc-1.12.1/examples/qt/ExampleTestCases.h cppunit-doc : /usr/share/doc/cppunit- doc-1.12.1/examples/simple/ExampleTestCase.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Large documentation must go in a -doc subpackage. Note: Documentation size is 15032320 bytes in 1693 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Package does not contain any libtool archives (.la) [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cppunit- devel , cppunit-doc [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 16250880 bytes in /usr/share 10240 cppunit-devel-1.12.1-8.fc18.x86_64.rpm 16015360 cppunit- doc-1.12.1-8.fc18.x86_64.rpm 225280 cppunit-1.12.1-8.fc18.x86_64.rpm Rpmlint ------- Checking: cppunit-1.12.1-8.fc18.x86_64.rpm cppunit-devel-1.12.1-8.fc18.x86_64.rpm cppunit-doc-1.12.1-8.fc18.x86_64.rpm cppunit.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/DllPlugInTester ['/usr/lib64'] cppunit.x86_64: E: incorrect-fsf-address /usr/share/doc/cppunit-1.12.1/COPYING cppunit.x86_64: W: no-manual-page-for-binary DllPlugInTester cppunit-devel.x86_64: W: manual-page-warning /usr/share/man/man1/cppunit-config.1.gz 15: warning: macro `l' not defined cppunit-doc.x86_64: W: spelling-error Summary(en_US) documention -> document ion, document-ion, documentation cppunit-doc.x86_64: W: spelling-error %description -l en_US documention -> document ion, document-ion, documentation cppunit-doc.x86_64: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen 3 packages and 0 specfiles checked; 2 errors, 5 warnings. Requires -------- cppunit-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pkg-config automake cppunit libcppunit-1.12.so.1()(64bit) pkgconfig cppunit (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcppunit-1.12.so.1()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) cppunit-doc (rpmlib, GLIBC filtered): Provides -------- cppunit-devel: cppunit-devel cppunit-devel(x86-64) pkgconfig(cppunit) cppunit: cppunit cppunit(x86-64) libcppunit-1.12.so.1()(64bit) cppunit-doc: cppunit-doc cppunit-doc(x86-64) MD5-sum check ------------- http://downloads.sourceforge.net/cppunit/cppunit-1.12.1.tar.gz : CHECKSUM(SHA256) this package : ac28a04c8e6c9217d910b0ae7122832d28d9917fa668bcc9e0b8b09acb4ea44a CHECKSUM(SHA256) upstream package : ac28a04c8e6c9217d910b0ae7122832d28d9917fa668bcc9e0b8b09acb4ea44a Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn cppunit -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires