Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cracklib- devel , cracklib-python , cracklib-dicts [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 71680 bytes in 6 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Test run failed [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-root [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define dictdir %{_datadir}/cracklib %define dictpath %{dictdir}/pw_dict [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 9564160 bytes in /usr/share 9338880 cracklib-dicts-2.8.22-2.fc19.x86_64.rpm 215040 cracklib-2.8.22-2.fc19.x86_64.rpm 10240 cracklib- devel-2.8.22-2.fc19.x86_64.rpm Rpmlint ------- Checking: cracklib-2.8.22-2.fc19.x86_64.rpm cracklib-devel-2.8.22-2.fc19.x86_64.rpm cracklib-python-2.8.22-2.fc19.x86_64.rpm cracklib-dicts-2.8.22-2.fc19.x86_64.rpm cracklib.x86_64: W: spelling-error %description -l en_US username -> user name, user-name, surname cracklib.x86_64: W: spelling-error %description -l en_US gecos -> geckos, Pecos cracklib.x86_64: W: spelling-error %description -l en_US passwd -> passed, password cracklib.x86_64: W: spelling-error %description -l en_US dicts -> ducts, dicta, dict cracklib.x86_64: W: no-manual-page-for-binary cracklib-packer cracklib.x86_64: W: no-manual-page-for-binary cracklib-unpacker cracklib-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/_cracklib.so _cracklib.so()(64bit) cracklib-python.x86_64: W: no-documentation cracklib-dicts.x86_64: W: only-non-binary-in-usr-lib cracklib-dicts.x86_64: W: no-documentation cracklib-dicts.x86_64: W: dangling-relative-symlink /usr/sbin/packer cracklib-packer cracklib-dicts.x86_64: W: dangling-relative-symlink /usr/sbin/mkdict cracklib-format cracklib-dicts.x86_64: W: no-manual-page-for-binary packer cracklib-dicts.x86_64: W: no-manual-page-for-binary mkdict 4 packages and 0 specfiles checked; 0 errors, 14 warnings. Requires -------- cracklib-python (rpmlib, GLIBC filtered): cracklib libc.so.6()(64bit) libcrack.so.2()(64bit) libz.so.1()(64bit) python(abi) rtld(GNU_HASH) cracklib-devel (rpmlib, GLIBC filtered): cracklib libcrack.so.2()(64bit) cracklib-dicts (rpmlib, GLIBC filtered): cracklib cracklib (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig gzip libc.so.6()(64bit) libcrack.so.2()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- cracklib-python: _cracklib.so()(64bit) cracklib-python cracklib-python(x86-64) cracklib-devel: cracklib-devel cracklib-devel(x86-64) cracklib-dicts: cracklib-dicts cracklib-dicts(x86-64) cracklib: cracklib cracklib(x86-64) libcrack.so.2()(64bit) Unversioned so-files -------------------- cracklib-python: /usr/lib64/python2.7/site-packages/_cracklib.so MD5-sum check ------------- http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/male-names.gz : CHECKSUM(SHA256) this package : 78cb7cab6987807faccfb03b7d492954fdf56190d1528882ee10180bb66af6f4 CHECKSUM(SHA256) upstream package : 78cb7cab6987807faccfb03b7d492954fdf56190d1528882ee10180bb66af6f4 http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/names.french.gz : CHECKSUM(SHA256) this package : 752fe17bffb33f983ec97facc1a6e06b0eed7523a95d287a439f0f3839990aba CHECKSUM(SHA256) upstream package : 752fe17bffb33f983ec97facc1a6e06b0eed7523a95d287a439f0f3839990aba http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/fast-names.gz : CHECKSUM(SHA256) this package : c0e6b916d0100300d72c6e925862e2f3bb717bb1677880ea5723e86987d294e9 CHECKSUM(SHA256) upstream package : c0e6b916d0100300d72c6e925862e2f3bb717bb1677880ea5723e86987d294e9 http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/female-names.gz : CHECKSUM(SHA256) this package : db44dbf4e562f0ca016f61c87843e212bd12fd705b16e126c587a4a46984d678 CHECKSUM(SHA256) upstream package : db44dbf4e562f0ca016f61c87843e212bd12fd705b16e126c587a4a46984d678 http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/surnames.finnish.gz : CHECKSUM(SHA256) this package : 9e99bff401730ef2b3b1f4f15df729bc077c3666bcbddc13c33116a02c16bbb2 CHECKSUM(SHA256) upstream package : 9e99bff401730ef2b3b1f4f15df729bc077c3666bcbddc13c33116a02c16bbb2 http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/names.hp.gz : CHECKSUM(SHA256) this package : 79953d74b7c2c2ffa0c9c831a25df33011a9e72be2801a9bd92009a84c2f58ca CHECKSUM(SHA256) upstream package : 79953d74b7c2c2ffa0c9c831a25df33011a9e72be2801a9bd92009a84c2f58ca http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/other-names.gz : CHECKSUM(SHA256) this package : 981aa819d40cdb8ac8aa3684174c88640907e244891519a2573b2b13067bad51 CHECKSUM(SHA256) upstream package : 981aa819d40cdb8ac8aa3684174c88640907e244891519a2573b2b13067bad51 http://ftp.cerias.purdue.edu/pub/dict/wordlists/computer/common-passwords.txt.gz : CHECKSUM(SHA256) this package : 23c62c447cf5f0473b149661f3726eb54f2e3af19b32bc92589e010cefffecd9 CHECKSUM(SHA256) upstream package : 23c62c447cf5f0473b149661f3726eb54f2e3af19b32bc92589e010cefffecd9 http://ftp.cerias.purdue.edu/pub/dict/wordlists/computer/etc-hosts.gz : CHECKSUM(SHA256) this package : ab53787146e06e196d69ad703ff4c156c53955b24eff4eeee54fe8906fa6fa83 CHECKSUM(SHA256) upstream package : ab53787146e06e196d69ad703ff4c156c53955b24eff4eeee54fe8906fa6fa83 http://ftp.cerias.purdue.edu/pub/dict/wordlists/movieTV/Movies.gz : CHECKSUM(SHA256) this package : c1d79579db5b1ce21c45e376b7f886dfbd0f3ec3c13ead191515e2554b8e6084 CHECKSUM(SHA256) upstream package : c1d79579db5b1ce21c45e376b7f886dfbd0f3ec3c13ead191515e2554b8e6084 http://ftp.cerias.purdue.edu/pub/dict/wordlists/movieTV/Python.gz : CHECKSUM(SHA256) this package : d59a1ba926281f2f501f95197d41d3e54949fc31004e0e9b991cc904098e059b CHECKSUM(SHA256) upstream package : d59a1ba926281f2f501f95197d41d3e54949fc31004e0e9b991cc904098e059b http://ftp.cerias.purdue.edu/pub/dict/wordlists/computer/Domains.gz : CHECKSUM(SHA256) this package : 0460d732d45093f3658612cf1190e84611f2176e8f6d841eec02ab3909114a97 CHECKSUM(SHA256) upstream package : 0460d732d45093f3658612cf1190e84611f2176e8f6d841eec02ab3909114a97 http://ftp.cerias.purdue.edu/pub/dict/wordlists/computer/Dosref.gz : CHECKSUM(SHA256) this package : 23a1e78ac3e64a4c4c77548a3fb0be22d93e405160aa29f9bf0eaa4d30b12622 CHECKSUM(SHA256) upstream package : 23a1e78ac3e64a4c4c77548a3fb0be22d93e405160aa29f9bf0eaa4d30b12622 http://ftp.cerias.purdue.edu/pub/dict/wordlists/computer/Ftpsites.gz : CHECKSUM(SHA256) this package : ac1dea9f1f6bc5bdab2dbea02245a0bcd53239219280a7319e650022417a3459 CHECKSUM(SHA256) upstream package : ac1dea9f1f6bc5bdab2dbea02245a0bcd53239219280a7319e650022417a3459 http://ftp.cerias.purdue.edu/pub/dict/wordlists/computer/Jargon.gz : CHECKSUM(SHA256) this package : 7a3df73e01b47eaf181b978404231bdcfb61dd7c30becbc280412ab7af6d2ecc CHECKSUM(SHA256) upstream package : 7a3df73e01b47eaf181b978404231bdcfb61dd7c30becbc280412ab7af6d2ecc http://ftp.cerias.purdue.edu/pub/dict/wordlists/movieTV/Trek.gz : CHECKSUM(SHA256) this package : 9ff5de76721cdab66ebc2c0ee1d6339f3b0679b7a24ef834fa8c554cb987cb3f CHECKSUM(SHA256) upstream package : 9ff5de76721cdab66ebc2c0ee1d6339f3b0679b7a24ef834fa8c554cb987cb3f http://ftp.cerias.purdue.edu/pub/dict/wordlists/literature/LCarrol.gz : CHECKSUM(SHA256) this package : b1d29407f502b3258da15f60694463efc24bab5f2eedfd53e8805f30615bf93c CHECKSUM(SHA256) upstream package : b1d29407f502b3258da15f60694463efc24bab5f2eedfd53e8805f30615bf93c http://prdownloads.sourceforge.net/cracklib/cracklib-2.8.22.tar.gz : CHECKSUM(SHA256) this package : feaff49bfb513ec10b2618c00d2f7f60776ba93fcc5fa22dd3479dd9cad9f770 CHECKSUM(SHA256) upstream package : feaff49bfb513ec10b2618c00d2f7f60776ba93fcc5fa22dd3479dd9cad9f770 http://iweb.dl.sourceforge.net/project/cracklib/cracklib-words/2008-05-07/cracklib-words-20080507.gz : CHECKSUM(SHA256) this package : e0c7f452c1fd80d551ae4a7d1afa7fa19cbf47c2d6d5dafc1255c1e76502cb71 CHECKSUM(SHA256) upstream package : e0c7f452c1fd80d551ae4a7d1afa7fa19cbf47c2d6d5dafc1255c1e76502cb71 http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/famous.gz : CHECKSUM(SHA256) this package : 3e53134bdea7a86cbb4dabbe0a0373927b44c1b679b720b6715c3cf220e78b29 CHECKSUM(SHA256) upstream package : 3e53134bdea7a86cbb4dabbe0a0373927b44c1b679b720b6715c3cf220e78b29 http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/Given-Names.gz : CHECKSUM(SHA256) this package : 1799d121010e5349d2aa6965d85526ebdb65465180d471f96fa470cfae661932 CHECKSUM(SHA256) upstream package : 1799d121010e5349d2aa6965d85526ebdb65465180d471f96fa470cfae661932 http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/ASSurnames.gz : CHECKSUM(SHA256) this package : 12c5c66b9e3711f96ab7f82a8a36183d8955c883a65e22d1e1b1dc2d75da0e2a CHECKSUM(SHA256) upstream package : 12c5c66b9e3711f96ab7f82a8a36183d8955c883a65e22d1e1b1dc2d75da0e2a http://ftp.cerias.purdue.edu/pub/dict/wordlists/literature/shakespeare.gz : CHECKSUM(SHA256) this package : 80f81cf26c980f1d16f1d401d55241a4f8a04288623cb98ba7cc1c4efb69d22b CHECKSUM(SHA256) upstream package : 80f81cf26c980f1d16f1d401d55241a4f8a04288623cb98ba7cc1c4efb69d22b http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/Family-Names.gz : CHECKSUM(SHA256) this package : adbe3f583c2f7cd826c734d2f513cd666a2267f02b72a2a49975726b4bd6b2da CHECKSUM(SHA256) upstream package : adbe3f583c2f7cd826c734d2f513cd666a2267f02b72a2a49975726b4bd6b2da http://ftp.cerias.purdue.edu/pub/dict/wordlists/names/Congress.gz : CHECKSUM(SHA256) this package : a12ebc19e42d6db6662c89afa2cd1d07646cad4c80b7d2fc201b659a0bb42cb5 CHECKSUM(SHA256) upstream package : a12ebc19e42d6db6662c89afa2cd1d07646cad4c80b7d2fc201b659a0bb42cb5 http://ftp.cerias.purdue.edu/pub/dict/wordlists/literature/cartoon.gz : CHECKSUM(SHA256) this package : d6ae05e33f55db7743622fbdf6b1a780155052b5181667857f8629effe6ff9f8 CHECKSUM(SHA256) upstream package : d6ae05e33f55db7743622fbdf6b1a780155052b5181667857f8629effe6ff9f8 http://ftp.cerias.purdue.edu/pub/dict/wordlists/literature/Paradise.Lost.gz : CHECKSUM(SHA256) this package : 4b7693510c87f17f5e3950969e34fcb0be2eb23a92f0a0387091fae6be8b47a6 CHECKSUM(SHA256) upstream package : 4b7693510c87f17f5e3950969e34fcb0be2eb23a92f0a0387091fae6be8b47a6 http://ftp.cerias.purdue.edu/pub/dict/wordlists/literature/sf.gz : CHECKSUM(SHA256) this package : 47b7546aab9e0d5671d657a17a8aac918397e741f15d6075b34f121b80e79a4d CHECKSUM(SHA256) upstream package : 47b7546aab9e0d5671d657a17a8aac918397e741f15d6075b34f121b80e79a4d http://ftp.cerias.purdue.edu/pub/dict/wordlists/literature/myths-legends.gz : CHECKSUM(SHA256) this package : 57177b7284e1d203099bceba031b762795247d53cd5c0b03720cdabf95bdc7f8 CHECKSUM(SHA256) upstream package : 57177b7284e1d203099bceba031b762795247d53cd5c0b03720cdabf95bdc7f8 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn cracklib -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires