Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: cups : /usr/share/cups/ppdc/epson.h cups : /usr/share/cups/ppdc/hp.h cups : /usr/share/cups/ppdc/label.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cups-devel , cups-libs , cups-filesystem , cups-lpd , cups-ipptool [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 81920 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 9369600 bytes in /usr/share 61440 cups-libs-1.6.1-20.fc19.x86_64.rpm 10240 cups- lpd-1.6.1-20.fc19.x86_64.rpm 10240 cups-devel-1.6.1-20.fc19.x86_64.rpm 6021120 cups-ipptool-1.6.1-20.fc19.x86_64.rpm 3266560 cups-1.6.1-20.fc19.x86_64.rpm Rpmlint ------- Checking: cups-1.6.1-20.fc19.x86_64.rpm cups-devel-1.6.1-20.fc19.x86_64.rpm cups-libs-1.6.1-20.fc19.x86_64.rpm cups-filesystem-1.6.1-20.fc19.noarch.rpm cups-lpd-1.6.1-20.fc19.x86_64.rpm cups-ipptool-1.6.1-20.fc19.x86_64.rpm cups.x86_64: W: devel-file-in-non-devel-package /usr/share/cups/ppdc/epson.h cups.x86_64: W: devel-file-in-non-devel-package /usr/share/cups/ppdc/label.h cups.x86_64: E: non-standard-dir-perm /var/run/cups/certs 0511L cups.x86_64: E: non-readable /etc/cups/cups-files.conf 0640L cups.x86_64: E: non-readable /usr/lib/cups/backend/lpd 0700L cups.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/lpd 0700L cups.x86_64: E: zero-length /etc/cups/lpoptions cups.x86_64: E: zero-length /etc/cups/subscriptions.conf cups.x86_64: E: non-readable /usr/lib/cups/backend/dnssd 0700L cups.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/dnssd 0700L cups.x86_64: E: non-readable /etc/cups/classes.conf 0600L cups.x86_64: E: zero-length /etc/cups/classes.conf cups.x86_64: E: non-readable /etc/cups/cupsd.conf.default 0640L cups.x86_64: W: non-conffile-in-etc /etc/cups/cupsd.conf.default cups.x86_64: E: zero-length /etc/cups/client.conf cups.x86_64: E: non-readable /usr/lib/cups/backend/ipp 0700L cups.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/ipp 0700L cups.x86_64: E: non-standard-dir-perm /var/spool/cups/tmp 01770L cups.x86_64: E: non-standard-dir-perm /var/spool/cups 0710L cups.x86_64: E: non-readable /etc/cups/printers.conf 0600L cups.x86_64: E: zero-length /etc/cups/printers.conf cups.x86_64: E: non-standard-dir-perm /etc/cups/ssl 0700L cups.x86_64: W: devel-file-in-non-devel-package /usr/share/cups/ppdc/hp.h cups.x86_64: E: non-readable /etc/cups/cupsd.conf 0640L cups.x86_64: W: no-manual-page-for-binary lpr.cups cups.x86_64: W: no-manual-page-for-binary lpstat.cups cups.x86_64: W: no-manual-page-for-binary lp.cups cups.x86_64: W: no-manual-page-for-binary lprm.cups cups.x86_64: W: no-manual-page-for-binary cancel.cups cups.x86_64: W: no-manual-page-for-binary lpc.cups cups.x86_64: W: no-manual-page-for-binary lpq.cups cups.x86_64: W: dangerous-command-in-%post rm cups.x86_64: W: dangerous-command-in-%trigger ln cups.x86_64: W: dangerous-command-in-%trigger rm cups.x86_64: W: dangerous-command-in-%trigger ln cups.x86_64: W: dangerous-command-in-%trigger rm cups-devel.x86_64: W: non-conffile-in-etc /etc/rpm/macros.cups cups-libs.x86_64: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively cups-libs.x86_64: W: spelling-error %description -l en_US lp -> LP, pl, lo cups-libs.x86_64: W: spelling-error %description -l en_US lpr -> pr, ppr, Apr cups-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libcupscgi.so.1 exit@GLIBC_2.2.5 cups-filesystem.noarch: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands cups-filesystem.noarch: W: no-documentation 6 packages and 0 specfiles checked; 20 errors, 23 warnings. Requires -------- cups-lpd (rpmlib, GLIBC filtered): /bin/sh cups cups-libs(x86-64) libaudit.so.1()(64bit) libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcups.so.2()(64bit) libdl.so.2()(64bit) libgcrypt.so.11()(64bit) libgnutls.so.26()(64bit) libgpg-error.so.0()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) cups-filesystem (rpmlib, GLIBC filtered): cups-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libaudit.so.1()(64bit) libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcups.so.2()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcrypt.so.11()(64bit) libgnutls.so.26()(64bit) libgnutls.so.26(GNUTLS_1_4)(64bit) libgpg-error.so.0()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) cups-devel (rpmlib, GLIBC filtered): /bin/sh cups-libs(x86-64) gnutls-devel krb5-devel libcups.so.2()(64bit) libcupscgi.so.1()(64bit) libcupsimage.so.2()(64bit) libcupsmime.so.1()(64bit) libcupsppdc.so.1()(64bit) zlib-devel cups-ipptool (rpmlib, GLIBC filtered): cups-libs(x86-64) libaudit.so.1()(64bit) libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcups.so.2()(64bit) libdl.so.2()(64bit) libgcrypt.so.11()(64bit) libgnutls.so.26()(64bit) libgpg-error.so.0()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) cups (rpmlib, GLIBC filtered): /bin/sh /sbin/chkconfig /usr/sbin/alternatives acl config(cups) cups-filesystem cups-filters cups-libs(x86-64) dbus ghostscript-cups grep libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libaudit.so.1()(64bit) libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcups.so.2()(64bit) libcupscgi.so.1()(64bit) libcupsimage.so.2()(64bit) libcupsmime.so.1()(64bit) libcupsppdc.so.1()(64bit) libdbus-1.so.3()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcrypt.so.11()(64bit) libgnutls.so.26()(64bit) libgnutls.so.26(GNUTLS_1_4)(64bit) libgpg-error.so.0()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libm.so.6()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libsystemd-daemon.so.0()(64bit) libsystemd-daemon.so.0(LIBSYSTEMD_DAEMON_31)(64bit) libusb-1.0.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) sed systemd systemd-sysv Provides -------- cups-lpd: cups-lpd cups-lpd(x86-64) cups-filesystem: cups-filesystem cups-libs: cups-libs cups-libs(x86-64) libcups.so.2()(64bit) libcupscgi.so.1()(64bit) libcupsimage.so.2()(64bit) libcupsmime.so.1()(64bit) libcupsppdc.so.1()(64bit) cups-devel: cups-devel cups-devel(x86-64) cupsddk-devel cups-ipptool: cups-ipptool cups-ipptool(x86-64) cups: /usr/bin/cancel /usr/bin/lp /usr/bin/lpq /usr/bin/lpr /usr/bin/lprm /usr/bin/lpstat config(cups) cups cups(x86-64) cupsddk cupsddk-drivers lpd lpr MD5-sum check ------------- http://ftp.easysw.com/pub/cups/1.6.1/cups-1.6.1-source.tar.bz2 : CHECKSUM(SHA256) this package : 5842ab1144e653160fe667ee78b932ee036b054c0c2d20533d19e309149a7790 CHECKSUM(SHA256) upstream package : 5842ab1144e653160fe667ee78b932ee036b054c0c2d20533d19e309149a7790 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn cups -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires