Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: http://fedoraproject.org/wiki/Packaging:Perl - Static libraries in -static subpackage, if present. Note: Archive *.a files found in cyrus-imapd-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cyrus- imapd-devel , cyrus-imapd-utils [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 921600 bytes in 107 files. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define ssl_pem_file %{_sysconfdir}/pki/%{name}/%{name}.pem %define uid 76 %define gid 76 %define _cyrususer cyrus %define _cyrusgroup mail %define _cyrexecdir %{_exec_prefix}/lib/%{name} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1105920 bytes in /usr/share 983040 cyrus-imapd-2.4.17-1.fc19.x86_64.rpm 20480 cyrus-imapd- devel-2.4.17-1.fc19.x86_64.rpm 102400 cyrus-imapd- utils-2.4.17-1.fc19.x86_64.rpm Rpmlint ------- Checking: cyrus-imapd-2.4.17-1.fc19.x86_64.rpm cyrus-imapd-devel-2.4.17-1.fc19.x86_64.rpm cyrus-imapd-utils-2.4.17-1.fc19.x86_64.rpm cyrus-imapd.x86_64: E: explicit-lib-dependency libdb-utils cyrus-imapd.x86_64: W: spelling-error %description -l en_US scaleable -> scale able, scale-able, scaleless cyrus-imapd.x86_64: W: spelling-error %description -l en_US scalability -> availability, sociability, implacability cyrus-imapd.x86_64: W: spelling-error %description -l en_US administratability -> administration cyrus-imapd.x86_64: W: spelling-error %description -l en_US imaps -> imps, maps, imams cyrus-imapd.x86_64: W: spelling-error %description -l en_US nntps -> Napster cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/backup 0700L cyrus-imapd.x86_64: E: non-readable /etc/pki/cyrus-imapd/cyrus-imapd.pem 0640L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/socket 0750L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/rpm 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/user 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/msg 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/proc 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/sync 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/spool/imap 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/quota 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/ptclient 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/sieve 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/log 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap 0750L cyrus-imapd.x86_64: E: incorrect-fsf-address /usr/lib/cyrus-imapd/cvt_cyrusdb_all cyrus-imapd.x86_64: W: manual-page-warning /usr/share/man/man8/cyr_dbtool.8.gz 83: warning: macro `myconsistent'' not defined cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/db 0700L cyrus-imapd.x86_64: W: manual-page-warning /usr/share/man/man5/imapd.conf.5.gz 801: warning: macro `t',' not defined cyrus-imapd.x86_64: W: manual-page-warning /usr/share/man/man5/imapd.conf.5.gz 1198: warning: numeric expression expected (got `f') cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/meta 0700L cyrus-imapd.x86_64: E: non-standard-dir-perm /var/lib/imap/md5 0700L cyrus-imapd.x86_64: W: dangerous-command-in-%post chown cyrus-imapd-devel.x86_64: W: spelling-error %description -l en_US imclient -> client, liniment cyrus-imapd-utils.x86_64: W: obsolete-not-provided cyrus-imapd-perl cyrus-imapd-utils.x86_64: W: no-manual-page-for-binary notifytest cyrus-imapd-utils.x86_64: W: no-manual-page-for-binary synctest 3 packages and 0 specfiles checked; 19 errors, 13 warnings. Requires -------- cyrus-imapd (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/env /usr/bin/perl config(cyrus-imapd) coreutils cyrus-imapd-utils e2fsprogs file findutils grep libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdb-5.3.so()(64bit) libdb-utils libdl.so.2()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libkrb5support.so.0()(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) libnsl.so.1()(64bit) libpthread.so.0()(64bit) libsasl2.so.2()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) perl perl(:MODULE_COMPAT_5.16.2) perl(Getopt::Std) perl(strict) perl(warnings) rtld(GNU_HASH) systemd-units cyrus-imapd-devel (rpmlib, GLIBC filtered): cyrus-imapd-utils (rpmlib, GLIBC filtered): /bin/sh coreutils grep libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdb-5.3.so()(64bit) libdl.so.2()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5support.so.0()(64bit) libnsl.so.1()(64bit) libsasl2.so.2()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libwrap.so.0()(64bit) libz.so.1()(64bit) make openssl perl(Carp) perl(Cyrus::IMAP) perl(Cyrus::IMAP::Admin) perl(DynaLoader) perl(Exporter) perl(Getopt::Long) perl(IO::File) perl(POSIX) perl(strict) perl(vars) rtld(GNU_HASH) shadow-utils Provides -------- cyrus-imapd: config(cyrus-imapd) cyrus-imapd cyrus-imapd(x86-64) cyrus-imapd-devel: cyrus-imapd-devel cyrus-imapd-devel(x86-64) cyrus-imapd-static cyrus-imapd-utils: cyrus-imapd-utils cyrus-imapd-utils(x86-64) perl(Cyrus::IMAP) perl(Cyrus::IMAP::Admin) perl(Cyrus::IMAP::DummyReadline) perl(Cyrus::IMAP::IMSP) perl(Cyrus::IMAP::Shell) perl(Cyrus::SIEVE::managesieve) Unversioned so-files -------------------- cyrus-imapd-utils: /usr/lib64/perl5/vendor_perl/auto/Cyrus/IMAP/IMAP.so cyrus-imapd-utils: /usr/lib64/perl5/vendor_perl/auto/Cyrus/SIEVE/managesieve/managesieve.so MD5-sum check ------------- ftp://ftp.cyrusimap.org/cyrus-imapd/cyrus-imapd-2.4.17.tar.gz : CHECKSUM(SHA256) this package : b3e30052c764ee7163947ffde27bdd58bd4dd2e5697ad144491941e46300a583 CHECKSUM(SHA256) upstream package : b3e30052c764ee7163947ffde27bdd58bd4dd2e5697ad144491941e46300a583 http://email.uoa.gr/projects/cyrus/autocreate/README.autocreate-cyrus-2.3 : CHECKSUM(SHA256) this package : b98e96ff65b5fb635620232b3ee8ea79a1f45b5a44740d2150129d1c379a629f CHECKSUM(SHA256) upstream package : b98e96ff65b5fb635620232b3ee8ea79a1f45b5a44740d2150129d1c379a629f http://email.uoa.gr/projects/cyrus/autosievefolder/README.autosievefolder : CHECKSUM(SHA256) this package : 685208ea733a4c4c4e81a25ecb63b37b28bcfbe533da6a85d34a5c118d41d6d6 CHECKSUM(SHA256) upstream package : 685208ea733a4c4c4e81a25ecb63b37b28bcfbe533da6a85d34a5c118d41d6d6 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn cyrus-imapd -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires