Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 1064960 bytes in 45 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cyrus-sasl- lib , cyrus-sasl-devel , cyrus-sasl-gssapi , cyrus-sasl-plain , cyrus- sasl-md5 , cyrus-sasl-ntlm , cyrus-sasl-sql , cyrus-sasl-ldap , cyrus- sasl-scram , cyrus-sasl-gs2 , cyrus-sasl-sysvinit [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define username saslauth %define hint "Saslauthd user" %define homedir /run/saslauthd %define _plugindir2 %{_libdir}/sasl2 %define bootstrap_cyrus_sasl 0 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1187840 bytes in /usr/share 215040 cyrus-sasl-lib-2.1.25-2.fc19.x86_64.rpm 942080 cyrus-sasl- devel-2.1.25-2.fc19.x86_64.rpm 30720 cyrus-sasl-2.1.25-2.fc19.x86_64.rpm Rpmlint ------- Checking: cyrus-sasl-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-lib-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-devel-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-gssapi-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-plain-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-md5-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-ntlm-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-sql-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-ldap-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-scram-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-gs2-2.1.25-2.fc19.x86_64.rpm cyrus-sasl-sysvinit-2.1.25-2.fc19.x86_64.rpm cyrus-sasl.x86_64: W: only-non-binary-in-usr-lib cyrus-sasl-lib.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libanonymous.so cyrus-sasl-lib.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libsasldb.so cyrus-sasl-lib.x86_64: W: no-manual-page-for-binary saslpasswd2 cyrus-sasl-lib.x86_64: W: no-manual-page-for-binary sasldblistusers2 cyrus-sasl-devel.x86_64: W: no-manual-page-for-binary sasl2-sample-server cyrus-sasl-devel.x86_64: W: no-manual-page-for-binary sasl2-shared-mechlist cyrus-sasl-devel.x86_64: W: no-manual-page-for-binary sasl2-sample-client cyrus-sasl-gssapi.x86_64: W: no-documentation cyrus-sasl-gssapi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libgssapiv2.so cyrus-sasl-plain.x86_64: W: no-documentation cyrus-sasl-plain.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libplain.so cyrus-sasl-plain.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/liblogin.so cyrus-sasl-md5.x86_64: W: no-documentation cyrus-sasl-md5.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libdigestmd5.so cyrus-sasl-md5.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libcrammd5.so cyrus-sasl-ntlm.x86_64: W: no-documentation cyrus-sasl-ntlm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libntlm.so cyrus-sasl-sql.x86_64: W: spelling-error Summary(en_US) auxprop -> aux prop, aux-prop, apropos cyrus-sasl-sql.x86_64: W: no-documentation cyrus-sasl-sql.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libsql.so cyrus-sasl-ldap.x86_64: W: spelling-error Summary(en_US) auxprop -> aux prop, aux-prop, apropos cyrus-sasl-ldap.x86_64: W: no-documentation cyrus-sasl-ldap.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libldapdb.so cyrus-sasl-scram.x86_64: W: spelling-error Summary(en_US) auxprop -> aux prop, aux-prop, apropos cyrus-sasl-scram.x86_64: W: no-documentation cyrus-sasl-scram.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libscram.so cyrus-sasl-gs2.x86_64: W: no-documentation cyrus-sasl-gs2.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sasl2/libgs2.so cyrus-sasl-sysvinit.x86_64: W: spelling-error Summary(en_US) initscript -> inscription, postscript cyrus-sasl-sysvinit.x86_64: W: spelling-error Summary(en_US) authd -> author cyrus-sasl-sysvinit.x86_64: W: summary-ended-with-dot C The SysV initscript to manage the cyrus SASL authd. cyrus-sasl-sysvinit.x86_64: W: spelling-error %description -l en_US init -> unit, int, nit cyrus-sasl-sysvinit.x86_64: W: spelling-error %description -l en_US authd -> author cyrus-sasl-sysvinit.x86_64: W: no-documentation cyrus-sasl-sysvinit.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/saslauthd cyrus-sasl-sysvinit.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/saslauthd cyrus-sasl-sysvinit.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/saslauthd cyrus-sasl-sysvinit.x86_64: W: incoherent-init-script-name saslauthd ('cyrus-sasl', 'cyrus-sasld') 12 packages and 0 specfiles checked; 2 errors, 37 warnings. Requires -------- cyrus-sasl-lib (rpmlib, GLIBC filtered): /sbin/ldconfig libanonymous.so.2()(64bit) libc.so.6()(64bit) libcrypt.so.1()(64bit) libdb-5.3.so()(64bit) libdl.so.2()(64bit) libresolv.so.2()(64bit) libsasl2.so.2()(64bit) libsasldb.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl-ntlm (rpmlib, GLIBC filtered): cyrus-sasl-lib libc.so.6()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libntlm.so.2()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl-plain (rpmlib, GLIBC filtered): cyrus-sasl-lib libc.so.6()(64bit) libcrypt.so.1()(64bit) liblogin.so.2()(64bit) libplain.so.2()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl-md5 (rpmlib, GLIBC filtered): cyrus-sasl-lib libc.so.6()(64bit) libcrammd5.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdigestmd5.so.2()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl-gs2 (rpmlib, GLIBC filtered): cyrus-sasl-lib libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libgs2.so.2()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5support.so.0()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl (rpmlib, GLIBC filtered): /bin/sh /sbin/nologin /sbin/service /usr/sbin/groupadd /usr/sbin/groupdel /usr/sbin/useradd /usr/sbin/userdel chkconfig config(cyrus-sasl) cyrus-sasl-lib libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdb-5.3.so()(64bit) libdl.so.2()(64bit) libgssapi_krb5.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libkrb5support.so.0()(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libresolv.so.2()(64bit) libsasl2.so.2()(64bit) rtld(GNU_HASH) systemd-units cyrus-sasl-devel (rpmlib, GLIBC filtered): cyrus-sasl cyrus-sasl-lib libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5support.so.0()(64bit) libresolv.so.2()(64bit) libsasl2.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl-ldap (rpmlib, GLIBC filtered): cyrus-sasl-lib libc.so.6()(64bit) libcrypt.so.1()(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) libldapdb.so.2()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl-sysvinit (rpmlib, GLIBC filtered): /bin/bash cyrus-sasl cyrus-sasl-sql (rpmlib, GLIBC filtered): cyrus-sasl-lib libc.so.6()(64bit) libcrypt.so.1()(64bit) libmysqlclient.so.18()(64bit) libpq.so.5()(64bit) libresolv.so.2()(64bit) libsql.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl-scram (rpmlib, GLIBC filtered): cyrus-sasl-lib libc.so.6()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libresolv.so.2()(64bit) libscram.so.2()(64bit) rtld(GNU_HASH) cyrus-sasl-gssapi (rpmlib, GLIBC filtered): cyrus-sasl-lib libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libgssapiv2.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5support.so.0()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) Provides -------- cyrus-sasl-lib: cyrus-sasl-lib cyrus-sasl-lib(x86-64) libanonymous.so.2()(64bit) libsasl2.so.2()(64bit) libsasldb.so.2()(64bit) cyrus-sasl-ntlm: cyrus-sasl-ntlm cyrus-sasl-ntlm(x86-64) libntlm.so.2()(64bit) cyrus-sasl-plain: cyrus-sasl-plain cyrus-sasl-plain(x86-64) liblogin.so.2()(64bit) libplain.so.2()(64bit) cyrus-sasl-md5: cyrus-sasl-md5 cyrus-sasl-md5(x86-64) libcrammd5.so.2()(64bit) libdigestmd5.so.2()(64bit) cyrus-sasl-gs2: cyrus-sasl-gs2 cyrus-sasl-gs2(x86-64) libgs2.so.2()(64bit) cyrus-sasl: config(cyrus-sasl) cyrus-sasl cyrus-sasl(x86-64) group(saslauth) user(saslauth) cyrus-sasl-devel: cyrus-sasl-devel cyrus-sasl-devel(x86-64) cyrus-sasl-ldap: cyrus-sasl-ldap cyrus-sasl-ldap(x86-64) libldapdb.so.2()(64bit) cyrus-sasl-sysvinit: cyrus-sasl-sysvinit cyrus-sasl-sysvinit(x86-64) cyrus-sasl-sql: cyrus-sasl-sql cyrus-sasl-sql(x86-64) libsql.so.2()(64bit) cyrus-sasl-scram: cyrus-sasl-scram cyrus-sasl-scram(x86-64) libscram.so.2()(64bit) cyrus-sasl-gssapi: cyrus-sasl-gssapi cyrus-sasl-gssapi(x86-64) libgssapiv2.so.2()(64bit) Unversioned so-files -------------------- cyrus-sasl-lib: /usr/lib64/sasl2/libanonymous.so cyrus-sasl-lib: /usr/lib64/sasl2/libsasldb.so cyrus-sasl-gssapi: /usr/lib64/sasl2/libgssapiv2.so cyrus-sasl-plain: /usr/lib64/sasl2/liblogin.so cyrus-sasl-plain: /usr/lib64/sasl2/libplain.so cyrus-sasl-md5: /usr/lib64/sasl2/libcrammd5.so cyrus-sasl-md5: /usr/lib64/sasl2/libdigestmd5.so cyrus-sasl-ntlm: /usr/lib64/sasl2/libntlm.so cyrus-sasl-sql: /usr/lib64/sasl2/libsql.so cyrus-sasl-ldap: /usr/lib64/sasl2/libldapdb.so cyrus-sasl-scram: /usr/lib64/sasl2/libscram.so cyrus-sasl-gs2: /usr/lib64/sasl2/libgs2.so Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn cyrus-sasl -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires