Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 20152320 bytes in 395 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/dbus-1/*.conf [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dbus-libs , dbus-doc , dbus-devel , dbus-x11 [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define gettext_package dbus %define expat_version 1.95.5 %define libselinux_version 1.15.2 %define dbus_user_uid 81 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: dbus-1.6.8-2.fc18.x86_64.rpm dbus-libs-1.6.8-2.fc18.x86_64.rpm dbus-doc-1.6.8-2.fc18.noarch.rpm dbus-devel-1.6.8-2.fc18.x86_64.rpm dbus-x11-1.6.8-2.fc18.x86_64.rpm dbus.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo gin dbus.x86_64: W: conffile-without-noreplace-flag /etc/dbus-1/system.conf dbus.x86_64: W: conffile-without-noreplace-flag /etc/dbus-1/session.conf dbus.x86_64: E: setuid-binary /lib64/dbus-1/dbus-daemon-launch-helper root 04750L dbus.x86_64: E: non-standard-executable-perm /lib64/dbus-1/dbus-daemon-launch-helper 04750L dbus.x86_64: E: non-standard-executable-perm /lib64/dbus-1/dbus-daemon-launch-helper 04750L dbus-libs.x86_64: W: spelling-error %description -l en_US lowlevel -> low level, low-level, leveler dbus-libs.x86_64: W: obsolete-not-provided dbus dbus-libs.x86_64: W: no-documentation dbus-doc.noarch: W: spelling-error %description -l en_US dtd -> std, dd, did dbus-devel.x86_64: W: no-documentation dbus-x11.x86_64: W: spelling-error Summary(en_US) ons -> nos, ins, obs dbus-x11.x86_64: E: incorrect-fsf-address /etc/X11/xinit/xinitrc.d/00-start-message-bus.sh 5 packages and 0 specfiles checked; 4 errors, 9 warnings. Requires -------- dbus (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/useradd chkconfig config(dbus) dbus-libs libaudit.so.1()(64bit) libc.so.6()(64bit) libcap-ng.so.0()(64bit) libdbus-1.so.3()(64bit) libexpat.so.1()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libselinux libselinux.so.1()(64bit) rtld(GNU_HASH) systemd-units dbus-x11 (rpmlib, GLIBC filtered): /bin/sh dbus libX11.so.6()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) dbus-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dbus libdbus-1.so.3()(64bit) pkgconfig dbus-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) rtld(GNU_HASH) dbus-doc (rpmlib, GLIBC filtered): dbus Provides -------- dbus: config(dbus) dbus dbus(x86-64) dbus-x11: dbus-x11 dbus-x11(x86-64) dbus-devel: dbus-devel dbus-devel(x86-64) pkgconfig(dbus-1) dbus-libs: dbus-libs dbus-libs(x86-64) libdbus-1.so.3()(64bit) dbus-doc: dbus-doc MD5-sum check ------------- http://dbus.freedesktop.org/releases/dbus/dbus-1.6.8.tar.gz : CHECKSUM(SHA256) this package : fc1370ef38abeeb13f55c905ec002e60705fb0bfde3b8d21c8d6eb8056c11bac CHECKSUM(SHA256) upstream package : fc1370ef38abeeb13f55c905ec002e60705fb0bfde3b8d21c8d6eb8056c11bac Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn dbus -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires