Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 24473600 bytes in 1857 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dirac-libs , dirac-devel , dirac-docs [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 24586240 bytes in /usr/share 23869440 dirac-docs-1.0.2-9.fc18.x86_64.rpm 716800 dirac-1.0.2-9.fc18.x86_64.rpm Rpmlint ------- Checking: dirac-1.0.2-9.fc18.x86_64.rpm dirac-libs-1.0.2-9.fc18.x86_64.rpm dirac-devel-1.0.2-9.fc18.x86_64.rpm dirac-docs-1.0.2-9.fc18.x86_64.rpm dirac.x86_64: W: spelling-error Summary(en_US) codec -> codex, code, codes dirac.x86_64: W: name-repeated-in-summary C Dirac dirac.x86_64: W: spelling-error %description -l en_US codec -> codex, code, codes dirac.x86_64: W: spelling-error %description -l en_US artefacts -> artifacts, artifact dirac.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dirac_unittest ['/usr/lib64'] dirac.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dirac_encoder ['/usr/lib64'] dirac.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dirac_decoder ['/usr/lib64'] dirac.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dirac_instrumentation ['/usr/lib64'] dirac.x86_64: W: no-manual-page-for-binary dirac_RGBtoUYVY dirac.x86_64: W: no-manual-page-for-binary dirac_RGBtoYUV420 dirac.x86_64: W: no-manual-page-for-binary dirac_YUV420pt75filter dirac.x86_64: W: no-manual-page-for-binary dirac_RGBtoYUV422 dirac.x86_64: W: no-manual-page-for-binary dirac_encoder dirac.x86_64: W: no-manual-page-for-binary dirac_YUV444toRGB dirac.x86_64: W: no-manual-page-for-binary dirac_BMPtoRGB dirac.x86_64: W: no-manual-page-for-binary dirac_YUV420Down2x2 dirac.x86_64: W: no-manual-page-for-binary create_dirac_testfile.pl dirac.x86_64: W: no-manual-page-for-binary dirac_unittest dirac.x86_64: W: no-manual-page-for-binary dirac_YUV422toYUV420 dirac.x86_64: W: no-manual-page-for-binary dirac_decoder dirac.x86_64: W: no-manual-page-for-binary dirac_YUV422toRGB dirac.x86_64: W: no-manual-page-for-binary dirac_RGBtoYUV444 dirac.x86_64: W: no-manual-page-for-binary dirac_UYVYtoYUV422 dirac.x86_64: W: no-manual-page-for-binary dirac_RGBtoYUV411 dirac.x86_64: W: no-manual-page-for-binary dirac_YUV420toRGB dirac.x86_64: W: no-manual-page-for-binary dirac_YUV420toYUV422 dirac.x86_64: W: no-manual-page-for-binary dirac_instrumentation dirac.x86_64: W: no-manual-page-for-binary dirac_YUV411toRGB dirac.x86_64: W: no-manual-page-for-binary dirac_YUV422ItoYUV420I dirac.x86_64: W: no-manual-page-for-binary dirac_YUV420ItoYUV422I dirac.x86_64: W: no-manual-page-for-binary dirac_RGBtoBMP dirac.x86_64: W: no-manual-page-for-binary dirac_YUV422toUYVY dirac.x86_64: W: no-manual-page-for-binary dirac_UYVYtoRGB dirac-libs.x86_64: W: no-documentation dirac-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 4 errors, 31 warnings. Requires -------- dirac-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) dirac-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dirac-libs libdirac_decoder.so.0()(64bit) libdirac_encoder.so.0()(64bit) pkgconfig dirac (rpmlib, GLIBC filtered): /usr/bin/perl libc.so.6()(64bit) libcppunit-1.12.so.1()(64bit) libdirac_decoder.so.0()(64bit) libdirac_encoder.so.0()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) perl(File::Basename) perl(Getopt::Long) perl(strict) rtld(GNU_HASH) dirac-docs (rpmlib, GLIBC filtered): Provides -------- dirac-libs: dirac-libs dirac-libs(x86-64) libdirac_decoder.so.0()(64bit) libdirac_encoder.so.0()(64bit) dirac-devel: dirac-devel dirac-devel(x86-64) pkgconfig(dirac) dirac: dirac dirac(x86-64) dirac-docs: dirac-docs dirac-docs(x86-64) MD5-sum check ------------- http://downloads.sourceforge.net/dirac/dirac-1.0.2.tar.gz : CHECKSUM(SHA256) this package : 816b16f18d235ff8ccd40d95fc5b4fad61ae47583e86607932929d70bf1f00fd CHECKSUM(SHA256) upstream package : 816b16f18d235ff8ccd40d95fc5b4fad61ae47583e86607932929d70bf1f00fd Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn dirac -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires