Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 19 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define openjadever 1.3.2 %define version_list "{3,4}.{0,1}-sgml 4.1.2-xml 4.{2,3,4,5}-{sgml,xml}" [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: docbook-dtds-1.0-57.fc18.noarch.rpm docbook-dtds.noarch: W: dangerous-command-in-%post chmod docbook-dtds.noarch: W: dangerous-command-in-%postun rm 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- docbook-dtds (rpmlib, GLIBC filtered): /bin/chmod /bin/sh /usr/bin/xmlcatalog config(docbook-dtds) sed sgml-common xml-common Provides -------- docbook-dtds: config(docbook-dtds) docbook-dtd-sgml docbook-dtd-xml docbook-dtd30-sgml docbook-dtd31-sgml docbook-dtd40-sgml docbook-dtd41-sgml docbook-dtd412-xml docbook-dtd42-sgml docbook-dtd42-xml docbook-dtd43-sgml docbook-dtd43-xml docbook-dtd44-sgml docbook-dtd44-xml docbook-dtd45-sgml docbook-dtd45-xml docbook-dtds MD5-sum check ------------- http://www.docbook.org/xml/4.4/docbook-xml-4.4.zip : CHECKSUM(SHA256) this package : 02f159eb88c4254d95e831c51c144b1863b216d909b5ff45743a1ce6f5273090 CHECKSUM(SHA256) upstream package : 02f159eb88c4254d95e831c51c144b1863b216d909b5ff45743a1ce6f5273090 http://www.docbook.org/sgml/4.5/docbook-4.5.zip : CHECKSUM(SHA256) this package : 8043e514e80c6c19cb146b5d37937d1305bf3abf9b0097c36df7f70f611cdf43 CHECKSUM(SHA256) upstream package : 8043e514e80c6c19cb146b5d37937d1305bf3abf9b0097c36df7f70f611cdf43 http://www.docbook.org/xml/4.5/docbook-xml-4.5.zip : CHECKSUM(SHA256) this package : 4e4e037a2b83c98c6c94818390d4bdd3f6e10f6ec62dd79188594e26190dc7b4 CHECKSUM(SHA256) upstream package : 4e4e037a2b83c98c6c94818390d4bdd3f6e10f6ec62dd79188594e26190dc7b4 http://www.oasis-open.org/docbook/sgml/4.0/docbk40.zip : CHECKSUM(SHA256) this package : dfef22f109779e4cfaafa27b6d381d975ac05eaafb5b3d4407d7043e310817bb CHECKSUM(SHA256) upstream package : dfef22f109779e4cfaafa27b6d381d975ac05eaafb5b3d4407d7043e310817bb http://www.oasis-open.org/docbook/sgml/4.1/docbk41.zip : CHECKSUM(SHA256) this package : deaafcf0a3677692e7ad4412c0e41c1db3e9da6cdcdb3dd32b2cc1f9c97d6311 CHECKSUM(SHA256) upstream package : deaafcf0a3677692e7ad4412c0e41c1db3e9da6cdcdb3dd32b2cc1f9c97d6311 http://www.oasis-open.org/docbook/sgml/3.0/docbk30.zip : CHECKSUM(SHA256) this package : ecf71cbe8ddbad7494ff520d5b4edf73a428c0b159178cb0cb619cba685e61c6 CHECKSUM(SHA256) upstream package : ecf71cbe8ddbad7494ff520d5b4edf73a428c0b159178cb0cb619cba685e61c6 http://www.oasis-open.org/docbook/sgml/3.1/docbk31.zip : CHECKSUM(SHA256) this package : 20261d2771b9a052abfa3d8fab1aa62be05791a010281c566f9073bf0e644538 CHECKSUM(SHA256) upstream package : 20261d2771b9a052abfa3d8fab1aa62be05791a010281c566f9073bf0e644538 http://www.oasis-open.org/docbook/xml/4.2/docbook-xml-4.2.zip : CHECKSUM(SHA256) this package : acc4601e4f97a196076b7e64b368d9248b07c7abf26b34a02cca40eeebe60fa2 CHECKSUM(SHA256) upstream package : acc4601e4f97a196076b7e64b368d9248b07c7abf26b34a02cca40eeebe60fa2 http://www.docbook.org/sgml/4.3/docbook-4.3.zip : CHECKSUM(SHA256) this package : 88f52fab7bd49b2e8f40c525014129c26a5a4b8bbd1494e00387556ec76f95ee CHECKSUM(SHA256) upstream package : 88f52fab7bd49b2e8f40c525014129c26a5a4b8bbd1494e00387556ec76f95ee http://www.oasis-open.org/docbook/xml/4.1.2/docbkx412.zip : CHECKSUM(SHA256) this package : 30f0644064e0ea71751438251940b1431f46acada814a062870f486c772e7772 CHECKSUM(SHA256) upstream package : 30f0644064e0ea71751438251940b1431f46acada814a062870f486c772e7772 http://www.oasis-open.org/docbook/sgml/4.2/docbook-4.2.zip : CHECKSUM(SHA256) this package : 67ebd2c94b342718c6865d2de60f5d4ff02d77a7e4b0d9e72a48c45f2b2635c3 CHECKSUM(SHA256) upstream package : 67ebd2c94b342718c6865d2de60f5d4ff02d77a7e4b0d9e72a48c45f2b2635c3 http://www.docbook.org/xml/4.3/docbook-xml-4.3.zip : CHECKSUM(SHA256) this package : 23068a94ea6fd484b004c5a73ec36a66aa47ea8f0d6b62cc1695931f5c143464 CHECKSUM(SHA256) upstream package : 23068a94ea6fd484b004c5a73ec36a66aa47ea8f0d6b62cc1695931f5c143464 http://www.docbook.org/sgml/4.4/docbook-4.4.zip : CHECKSUM(SHA256) this package : 0ac7960409b032c8e517483523ecb92af4e59196a33b3e2c5617daa22b7a8a6c CHECKSUM(SHA256) upstream package : 0ac7960409b032c8e517483523ecb92af4e59196a33b3e2c5617daa22b7a8a6c Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn docbook-dtds -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires