Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 3461120 bytes in 269 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dovecot- pigeonhole , dovecot-pgsql , dovecot-mysql , dovecot-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define ssldir %{_sysconfdir}/pki/%{name} %define _initddir %{_initrddir} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3614720 bytes in /usr/share 727040 dovecot-pigeonhole-2.1.13-1.fc19.x86_64.rpm 2877440 dovecot-2.1.13-1.fc19.x86_64.rpm 10240 dovecot- devel-2.1.13-1.fc19.x86_64.rpm Rpmlint ------- Checking: dovecot-2.1.13-1.fc19.x86_64.rpm dovecot-pigeonhole-2.1.13-1.fc19.x86_64.rpm dovecot-pgsql-2.1.13-1.fc19.x86_64.rpm dovecot-mysql-2.1.13-1.fc19.x86_64.rpm dovecot-devel-2.1.13-1.fc19.x86_64.rpm dovecot.x86_64: W: spelling-error %description -l en_US maildir -> airmail dovecot.x86_64: W: spelling-error %description -l en_US mbox -> box, m box dovecot.x86_64: W: spelling-error %description -l en_US subpackages -> sub packages, sub-packages, prepackages dovecot.x86_64: E: non-standard-dir-perm /var/lib/dovecot 0750L dovecot.x86_64: E: non-readable /etc/pki/dovecot/certs/dovecot.pem 0600L dovecot.x86_64: E: incorrect-fsf-address /usr/share/doc/dovecot-2.1.13/COPYING.LGPL dovecot.x86_64: E: non-readable /etc/pki/dovecot/private/dovecot.pem 0600L dovecot.x86_64: W: dangerous-command-in-%pre rm dovecot.x86_64: W: dangerous-command-in-%post install dovecot.x86_64: W: dangerous-command-in-%preun rm dovecot.x86_64: W: dangerous-command-in-%postun rm dovecot.x86_64: W: dangerous-command-in-%posttrans rm dovecot-pigeonhole.x86_64: W: obsolete-not-provided dovecot-sieve dovecot-pigeonhole.x86_64: W: obsolete-not-provided dovecot-managesieve dovecot-pigeonhole.x86_64: E: incorrect-fsf-address /usr/share/doc/dovecot-2.1-pigeonhole-0.3.3/COPYING.LGPL dovecot-pigeonhole.x86_64: W: install-file-in-docs /usr/share/doc/dovecot-2.1-pigeonhole-0.3.3/INSTALL dovecot-pgsql.x86_64: W: spelling-error Summary(en_US) Postgres -> Postures, Postgraduates dovecot-pgsql.x86_64: W: no-documentation dovecot-mysql.x86_64: W: no-documentation dovecot-devel.x86_64: W: only-non-binary-in-usr-lib dovecot-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 5 errors, 16 warnings. Requires -------- dovecot (rpmlib, GLIBC filtered): /bin/sh config(dovecot) lib01_acl_plugin.so()(64bit) lib10_quota_plugin.so()(64bit) lib15_notify_plugin.so()(64bit) lib20_fts_plugin.so()(64bit) lib20_zlib_plugin.so()(64bit) lib90_stats_plugin.so()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcap.so.2()(64bit) libclucene-core.so.1()(64bit) libclucene-shared.so.1()(64bit) libcom_err.so.2()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libdovecot-lda.so.0()(64bit) libdovecot-login.so.0()(64bit) libdovecot-storage.so.0()(64bit) libdovecot.so.0()(64bit) libexpat.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) liblber-2.4.so.2()(64bit) libldap-2.4.so.2()(64bit) libm.so.6()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) openssl rtld(GNU_HASH) shadow-utils systemd systemd-units dovecot-pgsql (rpmlib, GLIBC filtered): dovecot libc.so.6()(64bit) libpq.so.5()(64bit) librt.so.1()(64bit) rtld(GNU_HASH) dovecot-mysql (rpmlib, GLIBC filtered): dovecot libc.so.6()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libmysqlclient.so.18()(64bit) libmysqlclient.so.18(libmysqlclient_16)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) dovecot-devel (rpmlib, GLIBC filtered): dovecot libdovecot-lda.so.0()(64bit) libdovecot-login.so.0()(64bit) libdovecot-sieve.so.0()(64bit) libdovecot-sql.so.0()(64bit) libdovecot-ssl.so.0()(64bit) libdovecot-storage.so.0()(64bit) libdovecot.so.0()(64bit) dovecot-pigeonhole (rpmlib, GLIBC filtered): config(dovecot-pigeonhole) dovecot libc.so.6()(64bit) libcrypto.so.10()(64bit) libdl.so.2()(64bit) libdovecot-lda.so.0()(64bit) libdovecot-login.so.0()(64bit) libdovecot-sieve.so.0()(64bit) libdovecot-storage.so.0()(64bit) libdovecot.so.0()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) rtld(GNU_HASH) Provides -------- dovecot: config(dovecot) dovecot dovecot(x86-64) lib01_acl_plugin.so()(64bit) lib02_imap_acl_plugin.so()(64bit) lib02_lazy_expunge_plugin.so()(64bit) lib05_pop3_migration_plugin.so()(64bit) lib05_snarf_plugin.so()(64bit) lib10_doveadm_acl_plugin.so()(64bit) lib10_doveadm_expire_plugin.so()(64bit) lib10_doveadm_quota_plugin.so()(64bit) lib10_doveadm_zlib_plugin.so()(64bit) lib10_quota_plugin.so()(64bit) lib11_imap_quota_plugin.so()(64bit) lib11_trash_plugin.so()(64bit) lib15_notify_plugin.so()(64bit) lib20_autocreate_plugin.so()(64bit) lib20_doveadm_fts_lucene_plugin.so()(64bit) lib20_doveadm_fts_plugin.so()(64bit) lib20_expire_plugin.so()(64bit) lib20_fts_plugin.so()(64bit) lib20_listescape_plugin.so()(64bit) lib20_mail_log_plugin.so()(64bit) lib20_mailbox_alias_plugin.so()(64bit) lib20_replication_plugin.so()(64bit) lib20_virtual_plugin.so()(64bit) lib20_zlib_plugin.so()(64bit) lib21_fts_lucene_plugin.so()(64bit) lib21_fts_solr_plugin.so()(64bit) lib21_fts_squat_plugin.so()(64bit) lib30_imap_zlib_plugin.so()(64bit) lib90_stats_plugin.so()(64bit) lib95_imap_stats_plugin.so()(64bit) libauthdb_imap.so()(64bit) libauthdb_ldap.so()(64bit) libdovecot-lda.so.0()(64bit) libdovecot-login.so.0()(64bit) libdovecot-sieve.so.0()(64bit) libdovecot-sql.so.0()(64bit) libdovecot-ssl.so.0()(64bit) libdovecot-storage.so.0()(64bit) libdovecot.so.0()(64bit) libdriver_sqlite.so()(64bit) libmech_gssapi.so()(64bit) dovecot-pgsql: dovecot-pgsql dovecot-pgsql(x86-64) libdriver_pgsql.so()(64bit) dovecot-mysql: dovecot-mysql dovecot-mysql(x86-64) libdriver_mysql.so()(64bit) dovecot-devel: dovecot-devel dovecot-devel(x86-64) dovecot-pigeonhole: config(dovecot-pigeonhole) dovecot-pigeonhole dovecot-pigeonhole(x86-64) lib90_sieve_plugin.so()(64bit) libmanagesieve_login_settings.so()(64bit) libmanagesieve_settings.so()(64bit) Unversioned so-files -------------------- dovecot: /usr/lib64/dovecot/auth/libauthdb_imap.so dovecot: /usr/lib64/dovecot/auth/libauthdb_ldap.so dovecot: /usr/lib64/dovecot/auth/libdriver_sqlite.so dovecot: /usr/lib64/dovecot/auth/libmech_gssapi.so dovecot: /usr/lib64/dovecot/dict/libdriver_sqlite.so dovecot: /usr/lib64/dovecot/doveadm/lib10_doveadm_acl_plugin.so dovecot: /usr/lib64/dovecot/doveadm/lib10_doveadm_expire_plugin.so dovecot: /usr/lib64/dovecot/doveadm/lib10_doveadm_quota_plugin.so dovecot: /usr/lib64/dovecot/doveadm/lib10_doveadm_zlib_plugin.so dovecot: /usr/lib64/dovecot/doveadm/lib20_doveadm_fts_lucene_plugin.so dovecot: /usr/lib64/dovecot/doveadm/lib20_doveadm_fts_plugin.so dovecot: /usr/lib64/dovecot/lib01_acl_plugin.so dovecot: /usr/lib64/dovecot/lib02_imap_acl_plugin.so dovecot: /usr/lib64/dovecot/lib02_lazy_expunge_plugin.so dovecot: /usr/lib64/dovecot/lib05_pop3_migration_plugin.so dovecot: /usr/lib64/dovecot/lib05_snarf_plugin.so dovecot: /usr/lib64/dovecot/lib10_quota_plugin.so dovecot: /usr/lib64/dovecot/lib11_imap_quota_plugin.so dovecot: /usr/lib64/dovecot/lib11_trash_plugin.so dovecot: /usr/lib64/dovecot/lib15_notify_plugin.so dovecot: /usr/lib64/dovecot/lib20_autocreate_plugin.so dovecot: /usr/lib64/dovecot/lib20_expire_plugin.so dovecot: /usr/lib64/dovecot/lib20_fts_plugin.so dovecot: /usr/lib64/dovecot/lib20_listescape_plugin.so dovecot: /usr/lib64/dovecot/lib20_mail_log_plugin.so dovecot: /usr/lib64/dovecot/lib20_mailbox_alias_plugin.so dovecot: /usr/lib64/dovecot/lib20_replication_plugin.so dovecot: /usr/lib64/dovecot/lib20_virtual_plugin.so dovecot: /usr/lib64/dovecot/lib20_zlib_plugin.so dovecot: /usr/lib64/dovecot/lib21_fts_lucene_plugin.so dovecot: /usr/lib64/dovecot/lib21_fts_solr_plugin.so dovecot: /usr/lib64/dovecot/lib21_fts_squat_plugin.so dovecot: /usr/lib64/dovecot/lib30_imap_zlib_plugin.so dovecot: /usr/lib64/dovecot/lib90_stats_plugin.so dovecot: /usr/lib64/dovecot/lib95_imap_stats_plugin.so dovecot: /usr/lib64/dovecot/libdriver_sqlite.so dovecot-pigeonhole: /usr/lib64/dovecot/lib90_sieve_plugin.so dovecot-pigeonhole: /usr/lib64/dovecot/settings/libmanagesieve_login_settings.so dovecot-pigeonhole: /usr/lib64/dovecot/settings/libmanagesieve_settings.so dovecot-pgsql: /usr/lib64/dovecot/auth/libdriver_pgsql.so dovecot-pgsql: /usr/lib64/dovecot/dict/libdriver_pgsql.so dovecot-pgsql: /usr/lib64/dovecot/libdriver_pgsql.so dovecot-mysql: /usr/lib64/dovecot/auth/libdriver_mysql.so dovecot-mysql: /usr/lib64/dovecot/dict/libdriver_mysql.so dovecot-mysql: /usr/lib64/dovecot/libdriver_mysql.so MD5-sum check ------------- http://www.dovecot.org/releases/2.1/dovecot-2.1.13.tar.gz : CHECKSUM(SHA256) this package : d0982b1a3b4cefe06d8d5e9e90372dc7569b9cc35bcb4d8087f09362b2632278 CHECKSUM(SHA256) upstream package : d0982b1a3b4cefe06d8d5e9e90372dc7569b9cc35bcb4d8087f09362b2632278 http://www.rename-it.nl/dovecot/2.1/dovecot-2.1-pigeonhole-0.3.3.tar.gz : CHECKSUM(SHA256) this package : 1d581f6292c6e760b26a06193a0af266ba3b6f3a0431e6617fcf6e1c84f7dd0e CHECKSUM(SHA256) upstream package : 1d581f6292c6e760b26a06193a0af266ba3b6f3a0431e6617fcf6e1c84f7dd0e Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn dovecot -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires