Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dracut- network , dracut-fips , dracut-fips-aesni , dracut-caps , dracut-tools [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 348160 bytes in 10 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Multiple BuildRoot definitions found [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define dracutlibdir %{_prefix}/lib/dracut %define with_nbd 1 %define with_nbd 0 [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: dracut-025-1.fc19.x86_64.rpm dracut-network-025-1.fc19.x86_64.rpm dracut-fips-025-1.fc19.x86_64.rpm dracut-fips-aesni-025-1.fc19.x86_64.rpm dracut-caps-025-1.fc19.x86_64.rpm dracut-tools-025-1.fc19.x86_64.rpm dracut.x86_64: W: spelling-error Summary(en_US) Initramfs -> Ministrants dracut.x86_64: W: spelling-error %description -l en_US bootable -> bookable, boo table, boo-table dracut.x86_64: W: spelling-error %description -l en_US iSCSI -> SCSI, i SCSI, Isis dracut.x86_64: W: invalid-license LGPLv2.1+ dracut.x86_64: W: obsolete-not-provided mkinitrd dracut.x86_64: W: obsolete-not-provided mkinitrd-devel dracut.x86_64: W: obsolete-not-provided nash dracut.x86_64: W: obsolete-not-provided libbdevid-python dracut.x86_64: W: conffile-without-noreplace-flag /etc/dracut.conf.d/01-dist.conf dracut.x86_64: E: non-executable-script /usr/lib/dracut/modules.d/98pollcdrom/pollcdrom.sh 0644L /bin/sh dracut.x86_64: E: non-executable-script /usr/lib/dracut/modules.d/91crypt-loop/crypt-loop-lib.sh 0644L /bin/sh dracut.x86_64: E: non-executable-script /usr/lib/dracut/modules.d/50drm/module-setup.sh 0644L /bin/bash dracut.x86_64: E: non-executable-script /usr/lib/dracut/modules.d/99base/wait-host-devs.sh 0644L /bin/sh dracut.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/dracut_log dracut.x86_64: E: script-without-shebang /usr/lib/dracut/dracut-version.sh dracut.x86_64: E: non-executable-script /usr/lib/dracut/modules.d/95udev-rules/udev-rules-prepare.sh 0644L /bin/sh dracut-network.x86_64: W: spelling-error Summary(en_US) initramfs -> ministrants dracut-network.x86_64: W: summary-not-capitalized C dracut modules to build a dracut initramfs with network support dracut-network.x86_64: W: spelling-error %description -l en_US initramfs -> ministrants dracut-network.x86_64: W: invalid-license LGPLv2.1+ dracut-network.x86_64: W: only-non-binary-in-usr-lib dracut-network.x86_64: W: no-documentation dracut-network.x86_64: E: non-executable-script /usr/lib/dracut/modules.d/40network/net-lib.sh 0644L /bin/sh dracut-network.x86_64: E: non-executable-script /usr/lib/dracut/modules.d/40network/parse-vlan.sh 0644L /bin/sh dracut-fips.x86_64: W: spelling-error Summary(en_US) initramfs -> ministrants dracut-fips.x86_64: W: summary-not-capitalized C dracut modules to build a dracut initramfs with an integrity check dracut-fips.x86_64: W: spelling-error %description -l en_US initramfs -> ministrants dracut-fips.x86_64: W: invalid-license LGPLv2.1+ dracut-fips.x86_64: W: only-non-binary-in-usr-lib dracut-fips.x86_64: W: no-documentation dracut-fips-aesni.x86_64: W: spelling-error Summary(en_US) initramfs -> ministrants dracut-fips-aesni.x86_64: W: spelling-error Summary(en_US) intel -> inlet, Intel, lintel dracut-fips-aesni.x86_64: W: summary-not-capitalized C dracut modules to build a dracut initramfs with an integrity check with aesni-intel dracut-fips-aesni.x86_64: E: summary-too-long C dracut modules to build a dracut initramfs with an integrity check with aesni-intel dracut-fips-aesni.x86_64: W: spelling-error %description -l en_US initramfs -> ministrants dracut-fips-aesni.x86_64: W: spelling-error %description -l en_US intel -> inlet, Intel, lintel dracut-fips-aesni.x86_64: W: invalid-license LGPLv2.1+ dracut-fips-aesni.x86_64: W: only-non-binary-in-usr-lib dracut-caps.x86_64: E: explicit-lib-dependency libcap dracut-caps.x86_64: W: spelling-error Summary(en_US) initramfs -> ministrants dracut-caps.x86_64: W: summary-not-capitalized C dracut modules to build a dracut initramfs which drops capabilities dracut-caps.x86_64: W: spelling-error %description -l en_US initramfs -> ministrants dracut-caps.x86_64: W: invalid-license LGPLv2.1+ dracut-caps.x86_64: W: only-non-binary-in-usr-lib dracut-caps.x86_64: W: no-documentation dracut-tools.x86_64: W: spelling-error Summary(en_US) initramfs -> ministrants dracut-tools.x86_64: W: summary-not-capitalized C dracut tools to build the local initramfs dracut-tools.x86_64: W: spelling-error %description -l en_US initrd -> Trinity dracut-tools.x86_64: W: invalid-license LGPLv2.1+ 6 packages and 0 specfiles checked; 11 errors, 38 warnings. Requires -------- dracut-tools (rpmlib, GLIBC filtered): /bin/bash dracut dracut-network (rpmlib, GLIBC filtered): /bin/bash /bin/sh dracut iproute iputils dracut-fips (rpmlib, GLIBC filtered): /bin/bash /bin/sh config(dracut-fips) dracut hmaccalc nss-softokn nss-softokn-freebl dracut-fips-aesni (rpmlib, GLIBC filtered): /bin/bash dracut-fips dracut (rpmlib, GLIBC filtered): /bin/bash /bin/sh bash config(dracut) coreutils cpio file filesystem findutils grep gzip hardlink kbd kbd-misc kpartx libc.so.6()(64bit) module-init-tools rtld(GNU_HASH) sed udev util-linux xz dracut-caps (rpmlib, GLIBC filtered): /bin/bash dracut libcap Provides -------- dracut-tools: dracut-tools dracut-tools(x86-64) dracut-network: dracut-generic dracut-network dracut-network(x86-64) dracut-fips: config(dracut-fips) dracut-fips dracut-fips(x86-64) dracut-fips-aesni: dracut-fips-aesni dracut-fips-aesni(x86-64) dracut: config(dracut) dracut dracut(x86-64) dracut-kernel dracut-caps: dracut-caps dracut-caps(x86-64) MD5-sum check ------------- http://www.kernel.org/pub/linux/utils/boot/dracut/dracut-025.tar.bz2 : CHECKSUM(SHA256) this package : dff2bc61787606ce3c4a22800dce99cf620fa521e69669a61edd19a955bcd69b CHECKSUM(SHA256) upstream package : dff2bc61787606ce3c4a22800dce99cf620fa521e69669a61edd19a955bcd69b Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn dracut -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires