Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in e2fsprogs- libs , e2fsprogs-static , e2fsprogs-devel , libcom_err , libcom_err-devel , libss , libss-devel [ ]: Package complies to the Packaging Guidelines [ ]: Texinfo files are properly installed Note: Texinfo .info file(s) in e2fsprogs-devel [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 552960 bytes in 7 files. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define multilib_arches %{ix86} x86_64 ppc ppc64 s390 s390x sparcv9 sparc64 [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2017280 bytes in /usr/share 20480 libcom_err-devel-1.42.7-1.fc19.x86_64.rpm 10240 libss- devel-1.42.7-1.fc19.x86_64.rpm 20480 e2fsprogs- devel-1.42.7-1.fc19.x86_64.rpm 51200 libss-1.42.7-1.fc19.x86_64.rpm 1761280 e2fsprogs-1.42.7-1.fc19.x86_64.rpm 51200 libcom_err-1.42.7-1.fc19.x86_64.rpm 51200 e2fsprogs- static-1.42.7-1.fc19.x86_64.rpm 51200 e2fsprogs- libs-1.42.7-1.fc19.x86_64.rpm Rpmlint ------- Checking: e2fsprogs-1.42.7-1.fc19.x86_64.rpm e2fsprogs-libs-1.42.7-1.fc19.x86_64.rpm e2fsprogs-static-1.42.7-1.fc19.x86_64.rpm e2fsprogs-devel-1.42.7-1.fc19.x86_64.rpm libcom_err-1.42.7-1.fc19.x86_64.rpm libcom_err-devel-1.42.7-1.fc19.x86_64.rpm libss-1.42.7-1.fc19.x86_64.rpm libss-devel-1.42.7-1.fc19.x86_64.rpm e2fsprogs.x86_64: W: spelling-error Summary(en_US) filesystems -> file systems, file-systems, ecosystems e2fsprogs.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems e2fsprogs.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically e2fsprogs-libs.x86_64: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systemically e2fsprogs-libs.x86_64: W: spelling-error %description -l en_US acccess -> access, accedes e2fsprogs-libs.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems e2fsprogs-libs.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace e2fsprogs-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libext2fs.so.2.4 exit@GLIBC_2.2.5 e2fsprogs-static.x86_64: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systemically e2fsprogs-static.x86_64: W: spelling-error %description -l en_US libcom -> lib com, lib-com, Lipscomb e2fsprogs-static.x86_64: W: spelling-error %description -l en_US libss -> bliss, lib's, libels e2fsprogs-static.x86_64: W: spelling-error %description -l en_US acccess -> access, accedes e2fsprogs-static.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems e2fsprogs-static.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace e2fsprogs-devel.x86_64: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systemically e2fsprogs-devel.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically e2fsprogs-devel.x86_64: E: incorrect-fsf-address /usr/include/ext2fs/tdb.h libcom_err.x86_64: W: spelling-error %description -l en_US libcom -> lib com, lib-com, Lipscomb libcom_err-devel.x86_64: W: spelling-error %description -l en_US commmand -> command, commend libcom_err-devel.x86_64: W: spelling-error %description -l en_US libcom -> lib com, lib-com, Lipscomb libcom_err-devel.x86_64: W: cross-directory-hard-link /usr/include/et/com_err.h /usr/include/com_err.h libss-devel.x86_64: W: spelling-error %description -l en_US mk -> km, Mk, ml libss-devel.x86_64: W: spelling-error %description -l en_US cmds -> cads, cods, cuds 8 packages and 0 specfiles checked; 1 errors, 22 warnings. Requires -------- libss (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcom_err.so.2()(64bit) libdl.so.2()(64bit) rtld(GNU_HASH) libss-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pkg-config libss libss.so.2()(64bit) pkgconfig pkgconfig(com_err) e2fsprogs-static (rpmlib, GLIBC filtered): e2fsprogs-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pkg-config e2fsprogs-libs gawk info libcom_err-devel libe2p.so.2()(64bit) libext2fs.so.2()(64bit) pkgconfig pkgconfig(com_err) e2fsprogs (rpmlib, GLIBC filtered): config(e2fsprogs) e2fsprogs-libs libblkid.so.1()(64bit) libblkid.so.1(BLKID_1.0)(64bit) libblkid.so.1(BLKID_2.15)(64bit) libblkid.so.1(BLKID_2.17)(64bit) libc.so.6()(64bit) libcom_err libcom_err.so.2()(64bit) libe2p.so.2()(64bit) libext2fs.so.2()(64bit) libss libss.so.2()(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) rtld(GNU_HASH) libcom_err (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) e2fsprogs-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcom_err.so.2()(64bit) rtld(GNU_HASH) libcom_err-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pkg-config libcom_err libcom_err.so.2()(64bit) pkgconfig Provides -------- libss: libss libss(x86-64) libss.so.2()(64bit) libss-devel: libss-devel libss-devel(x86-64) pkgconfig(ss) e2fsprogs-static: e2fsprogs-static e2fsprogs-static(x86-64) e2fsprogs-devel: e2fsprogs-devel e2fsprogs-devel(x86-64) pkgconfig(e2p) pkgconfig(ext2fs) pkgconfig(quota) e2fsprogs: config(e2fsprogs) e2fsprogs e2fsprogs(x86-64) libcom_err: libcom_err libcom_err(x86-64) libcom_err.so.2()(64bit) e2fsprogs-libs: e2fsprogs-libs e2fsprogs-libs(x86-64) libe2p.so.2()(64bit) libext2fs.so.2()(64bit) libcom_err-devel: libcom_err-devel libcom_err-devel(x86-64) pkgconfig(com_err) MD5-sum check ------------- http://downloads.sourceforge.net/e2fsprogs/e2fsprogs-1.42.7.tar.gz : CHECKSUM(SHA256) this package : 6231655b2865b8fbfabc749a87cc72fc8d04a4d6a987f159e2c7e1e0df9b454a CHECKSUM(SHA256) upstream package : dc6501b2e75d205e425196d753d92b129c568525d8aad08085c0aa69ee9e7345 However, diff -r shows no differences Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn e2fsprogs -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires