Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Static libraries in -static subpackage, if present. Note: Archive *.a files found in elfutils-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in elfutils- libs , elfutils-devel , elfutils-devel-static , elfutils-libelf , elfutils-libelf-devel , elfutils-libelf-devel-static [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 81920 bytes in 6 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Dist tag is present. Note: Multiple Release tags found [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: elfutils-0.155-3.fc19.x86_64.rpm elfutils-libs-0.155-3.fc19.x86_64.rpm elfutils-devel-0.155-3.fc19.x86_64.rpm elfutils-devel-static-0.155-3.fc19.x86_64.rpm elfutils-libelf-0.155-3.fc19.x86_64.rpm elfutils-libelf-devel-0.155-3.fc19.x86_64.rpm elfutils-libelf-devel-static-0.155-3.fc19.x86_64.rpm elfutils.x86_64: W: spelling-error %description -l en_US ld -> ls, l, d elfutils.x86_64: W: spelling-error %description -l en_US nm -> NM, mm, n elfutils.x86_64: W: spelling-error %description -l en_US readelf -> read elf, read-elf, reader elfutils.x86_64: W: spelling-error %description -l en_US elflint -> elf lint, elf-lint, Flint elfutils.x86_64: W: invalid-url URL: https://fedorahosted.org/elfutils/ The read operation timed out elfutils.x86_64: W: no-manual-page-for-binary eu-findtextrel elfutils.x86_64: W: no-manual-page-for-binary eu-readelf elfutils.x86_64: W: no-manual-page-for-binary eu-addr2line elfutils.x86_64: W: no-manual-page-for-binary eu-ranlib elfutils.x86_64: W: no-manual-page-for-binary eu-elfcmp elfutils.x86_64: W: no-manual-page-for-binary eu-strip elfutils.x86_64: W: no-manual-page-for-binary eu-unstrip elfutils.x86_64: W: no-manual-page-for-binary eu-elflint elfutils.x86_64: W: no-manual-page-for-binary eu-size elfutils.x86_64: W: no-manual-page-for-binary eu-strings elfutils.x86_64: W: no-manual-page-for-binary eu-make-debug-archive elfutils.x86_64: W: no-manual-page-for-binary eu-nm elfutils.x86_64: W: no-manual-page-for-binary eu-objdump elfutils.x86_64: W: no-manual-page-for-binary eu-ar elfutils-libs.x86_64: W: spelling-error %description -l en_US devel -> delve, devil, revel elfutils-libs.x86_64: W: no-documentation elfutils-devel.x86_64: W: spelling-error %description -l en_US libebl -> libel elfutils-devel.x86_64: W: spelling-error %description -l en_US libdw -> libido elfutils-devel.x86_64: W: spelling-error %description -l en_US libasm -> liberalism elfutils-devel.x86_64: W: no-documentation elfutils-devel-static.x86_64: W: no-documentation elfutils-libelf.x86_64: W: obsolete-not-provided libelf elfutils-libelf.x86_64: W: no-documentation elfutils-libelf-devel.x86_64: W: obsolete-not-provided libelf-devel elfutils-libelf-devel.x86_64: W: no-documentation elfutils-libelf-devel-static.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 31 warnings. Requires -------- elfutils-libs (rpmlib, GLIBC filtered): /sbin/ldconfig elfutils-libelf(x86-64) ld-linux-x86-64.so.2()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libdw.so.1()(64bit) libdw.so.1(ELFUTILS_0.122)(64bit) libdw.so.1(ELFUTILS_0.144)(64bit) libelf.so.1()(64bit) libelf.so.1(ELFUTILS_1.0)(64bit) libelf.so.1(ELFUTILS_1.1.1)(64bit) libelf.so.1(ELFUTILS_1.3)(64bit) libelf.so.1(ELFUTILS_1.4)(64bit) libelf.so.1(ELFUTILS_1.5)(64bit) libelf.so.1(ELFUTILS_1.6)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.2.3)(64bit) rtld(GNU_HASH) elfutils-libelf-devel (rpmlib, GLIBC filtered): elfutils-libelf(x86-64) libelf.so.1()(64bit) elfutils (rpmlib, GLIBC filtered): /bin/sh elfutils-libelf(x86-64) elfutils-libs(x86-64) libasm.so.1()(64bit) libasm.so.1(ELFUTILS_1.0)(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libdw.so.1()(64bit) libdw.so.1(ELFUTILS_0.122)(64bit) libdw.so.1(ELFUTILS_0.126)(64bit) libdw.so.1(ELFUTILS_0.127)(64bit) libdw.so.1(ELFUTILS_0.138)(64bit) libdw.so.1(ELFUTILS_0.148)(64bit) libdw.so.1(ELFUTILS_0.149)(64bit) libelf.so.1()(64bit) libelf.so.1(ELFUTILS_1.0)(64bit) libelf.so.1(ELFUTILS_1.1)(64bit) libelf.so.1(ELFUTILS_1.1.1)(64bit) libelf.so.1(ELFUTILS_1.2)(64bit) libelf.so.1(ELFUTILS_1.3)(64bit) libelf.so.1(ELFUTILS_1.4)(64bit) libelf.so.1(ELFUTILS_1.5)(64bit) libelf.so.1(ELFUTILS_1.6)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) elfutils-devel-static (rpmlib, GLIBC filtered): elfutils-devel(x86-64) elfutils-libelf-devel-static(x86-64) elfutils-libelf-devel-static (rpmlib, GLIBC filtered): elfutils-libelf-devel(x86-64) elfutils-devel (rpmlib, GLIBC filtered): elfutils-libelf-devel(x86-64) elfutils-libs(x86-64) libasm.so.1()(64bit) libdw.so.1()(64bit) elfutils-libelf (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) Provides -------- elfutils-libs: elfutils-libs elfutils-libs(x86-64) libasm.so.1()(64bit) libasm.so.1(ELFUTILS_1.0)(64bit) libdw.so.1()(64bit) libdw.so.1(ELFUTILS_0)(64bit) libdw.so.1(ELFUTILS_0.122)(64bit) libdw.so.1(ELFUTILS_0.126)(64bit) libdw.so.1(ELFUTILS_0.127)(64bit) libdw.so.1(ELFUTILS_0.130)(64bit) libdw.so.1(ELFUTILS_0.136)(64bit) libdw.so.1(ELFUTILS_0.138)(64bit) libdw.so.1(ELFUTILS_0.142)(64bit) libdw.so.1(ELFUTILS_0.143)(64bit) libdw.so.1(ELFUTILS_0.144)(64bit) libdw.so.1(ELFUTILS_0.146)(64bit) libdw.so.1(ELFUTILS_0.148)(64bit) libdw.so.1(ELFUTILS_0.149)(64bit) libebl_alpha-0.155.so()(64bit) libebl_alpha.so(ELFUTILS_0.155)(64bit) libebl_arm-0.155.so()(64bit) libebl_arm.so(ELFUTILS_0.155)(64bit) libebl_i386-0.155.so()(64bit) libebl_i386.so(ELFUTILS_0.155)(64bit) libebl_ia64-0.155.so()(64bit) libebl_ia64.so(ELFUTILS_0.155)(64bit) libebl_ppc-0.155.so()(64bit) libebl_ppc.so(ELFUTILS_0.155)(64bit) libebl_ppc64-0.155.so()(64bit) libebl_ppc64.so(ELFUTILS_0.155)(64bit) libebl_s390-0.155.so()(64bit) libebl_s390.so(ELFUTILS_0.155)(64bit) libebl_sh-0.155.so()(64bit) libebl_sh.so(ELFUTILS_0.155)(64bit) libebl_sparc-0.155.so()(64bit) libebl_sparc.so(ELFUTILS_0.155)(64bit) libebl_tilegx-0.155.so()(64bit) libebl_tilegx.so(ELFUTILS_0.155)(64bit) libebl_x86_64-0.155.so()(64bit) libebl_x86_64.so(ELFUTILS_0.155)(64bit) elfutils-libelf-devel: elfutils-libelf-devel elfutils-libelf-devel(x86-64) elfutils: elfutils elfutils(x86-64) elfutils-devel-static: elfutils-devel-static elfutils-devel-static(x86-64) elfutils-libelf-devel-static: elfutils-libelf-devel-static elfutils-libelf-devel-static(x86-64) elfutils-devel: elfutils-devel elfutils-devel(x86-64) elfutils-libelf: elfutils-libelf elfutils-libelf(x86-64) libelf.so.1()(64bit) libelf.so.1(ELFUTILS_1.0)(64bit) libelf.so.1(ELFUTILS_1.1)(64bit) libelf.so.1(ELFUTILS_1.1.1)(64bit) libelf.so.1(ELFUTILS_1.2)(64bit) libelf.so.1(ELFUTILS_1.3)(64bit) libelf.so.1(ELFUTILS_1.4)(64bit) libelf.so.1(ELFUTILS_1.5)(64bit) libelf.so.1(ELFUTILS_1.6)(64bit) Unversioned so-files -------------------- elfutils-libs: /usr/lib64/elfutils/libebl_alpha-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_alpha.so elfutils-libs: /usr/lib64/elfutils/libebl_arm-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_arm.so elfutils-libs: /usr/lib64/elfutils/libebl_i386-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_i386.so elfutils-libs: /usr/lib64/elfutils/libebl_ia64-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_ia64.so elfutils-libs: /usr/lib64/elfutils/libebl_ppc-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_ppc.so elfutils-libs: /usr/lib64/elfutils/libebl_ppc64-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_ppc64.so elfutils-libs: /usr/lib64/elfutils/libebl_s390-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_s390.so elfutils-libs: /usr/lib64/elfutils/libebl_sh-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_sh.so elfutils-libs: /usr/lib64/elfutils/libebl_sparc-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_sparc.so elfutils-libs: /usr/lib64/elfutils/libebl_tilegx-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_tilegx.so elfutils-libs: /usr/lib64/elfutils/libebl_x86_64-0.155.so elfutils-libs: /usr/lib64/elfutils/libebl_x86_64.so elfutils-libs: /usr/lib64/libasm-0.155.so elfutils-libs: /usr/lib64/libdw-0.155.so elfutils-libelf: /usr/lib64/libelf-0.155.so MD5-sum check ------------- http://fedorahosted.org/releases/e/l/elfutils/0.155/elfutils-0.155.tar.bz2 : CHECKSUM(SHA256) this package : 68444a4526416ffd68852ec3c6a40ceddcca46538297322405319884c5d30ed8 CHECKSUM(SHA256) upstream package : 68444a4526416ffd68852ec3c6a40ceddcca46538297322405319884c5d30ed8 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn elfutils -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires