Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked when required Note: icons in emacs See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - update-desktop-database is invoked when required Note: desktop file(s) in emacs, emacs-common, emacs-terminal See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find copying.paper in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in emacs-nox , emacs-common , emacs-el , emacs-terminal , emacs-filesystem [ ]: Package complies to the Packaging Guidelines [ ]: Texinfo files are properly installed Note: Texinfo .info file(s) in emacs-common [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 3 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? Python: [ ]: Binary eggs must be removed in %prep Note: Test run failed [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define paranoid 1 %define expurgate 0 %define expurgate 1 %define site_lisp %{_datadir}/emacs/site-lisp %define site_start_d %{site_lisp }/site-start.d %define bytecompargs -batch --no-init-file --no-site-file -f batch-byte-compile %define pkgconfig %{_datadir}/pkgconfig %define emacs_libexecdir %{_libexecdir}/emacs/%{version}/%{_host} %define info_files ada-mode auth autotype calc ccmode cl dbus dired-x ebrowse ede ediff edt eieio efaq eintr elisp emacs emacs-gnutls emacs-mime epa erc ert eshell eudc flymake forms gnus idlwave info mairix-el message mh-e newsticker nxml-mode org pcl-cvs pgg rcirc reftex remember sasl sc semantic ses sieve smtpmail speedbar tramp url vip viper widget woman %define setarch setarch %{_arch} -R %define setarch %{nil} %define toolkit gtk %define toolkit gtk3 [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: The placement of pkgconfig(.pc) files are correct. Note: emacs-el : /usr/share/pkgconfig/emacs.pc [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 72693760 bytes in /usr/share 72601600 emacs-common-24.2-8.fc19.x86_64.rpm 92160 emacs-24.2-8.fc19.x86_64.rpm Rpmlint ------- Checking: emacs-24.2-8.fc19.x86_64.rpm emacs-nox-24.2-8.fc19.x86_64.rpm emacs-common-24.2-8.fc19.x86_64.rpm emacs-el-24.2-8.fc19.noarch.rpm emacs-terminal-24.2-8.fc19.noarch.rpm emacs-filesystem-24.2-8.fc19.noarch.rpm emacs.x86_64: W: name-repeated-in-summary C Emacs emacs.x86_64: W: spelling-error %description -l en_US customizable -> customization emacs.x86_64: W: spelling-error %description -l en_US modeless -> modelers, mode less, mode-less emacs.x86_64: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Ellis emacs.x86_64: W: no-documentation emacs.x86_64: E: non-standard-executable-perm /usr/bin/emacs-24.2 01755L emacs.x86_64: W: no-manual-page-for-binary emacs emacs.x86_64: W: no-manual-page-for-binary emacs-24.2 emacs-nox.x86_64: W: spelling-error %description -l en_US customizable -> customization emacs-nox.x86_64: W: spelling-error %description -l en_US modeless -> modelers, mode less, mode-less emacs-nox.x86_64: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Ellis emacs-nox.x86_64: W: no-documentation emacs-nox.x86_64: W: no-manual-page-for-binary emacs emacs-nox.x86_64: W: no-manual-page-for-binary emacs-24.2-nox emacs-common.x86_64: W: spelling-error %description -l en_US customizable -> customization emacs-common.x86_64: W: spelling-error %description -l en_US modeless -> modelers, mode less, mode-less emacs-common.x86_64: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Ellis emacs-common.x86_64: W: spelling-error %description -l en_US nox -> box, nix, no emacs-common.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/emacs/site-lisp/site-start.el emacs-common.x86_64: W: conffile-without-noreplace-flag /usr/share/emacs/site-lisp/site-start.el emacs-common.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/emacs/site-lisp/default.el emacs-common.x86_64: W: file-not-utf8 /usr/share/info/emacs-7.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/gnus-1.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/emacs-6.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/ses.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/emacs-8.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/elisp-4.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/emacs-5.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/mh-e-1.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/emacs-2.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/gnus-3.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/emacs-4.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/elisp-1.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/emacs-mime.gz emacs-common.x86_64: W: hidden-file-or-dir /usr/share/emacs/24.2/lisp/gnus/.dir-locals.el emacs-common.x86_64: W: file-not-utf8 /usr/share/info/gnus-2.gz emacs-common.x86_64: W: file-not-utf8 /usr/share/info/elisp-8.gz emacs-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Ellis emacs-el.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/emacs.pc emacs-terminal.noarch: W: summary-ended-with-dot C A desktop menu item for GNU Emacs terminal. emacs-terminal.noarch: W: no-documentation emacs-terminal.noarch: W: no-manual-page-for-binary emacs-terminal emacs-filesystem.noarch: W: no-documentation 6 packages and 0 specfiles checked; 1 errors, 42 warnings. Requires -------- emacs-nox (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/alternatives emacs-common libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libgnutls.so.26()(64bit) libgnutls.so.26(GNUTLS_1_4)(64bit) libgpm.so.2()(64bit) libm.so.6()(64bit) libncurses.so.5()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libtinfo.so.5()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) emacs-common (rpmlib, GLIBC filtered): /bin/sh /sbin/install-info /usr/bin/perl /usr/sbin/alternatives config(emacs-common) emacs-filesystem libc.so.6()(64bit) liblockfile.so.1()(64bit) perl perl(Getopt::Long) perl(strict) perl(vars) rtld(GNU_HASH) emacs-terminal (rpmlib, GLIBC filtered): /bin/sh emacs emacs (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/alternatives dejavu-sans-mono-fonts desktop-file-utils emacs-common libICE.so.6()(64bit) libMagickCore.so.5()(64bit) libMagickWand.so.5()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXft.so.2()(64bit) libXpm.so.4()(64bit) libXrender.so.1()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgconf-2.so.4()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgif.so.4()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgnutls.so.26()(64bit) libgnutls.so.26(GNUTLS_1_4)(64bit) libgobject-2.0.so.0()(64bit) libgomp.so.1()(64bit) libgtk-3.so.0()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libm17n-core.so.0()(64bit) libm17n-flt.so.0()(64bit) libncurses.so.5()(64bit) libotf.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) librsvg-2.so.2()(64bit) libselinux.so.1()(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) libtinfo.so.5()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) emacs-filesystem (rpmlib, GLIBC filtered): emacs-el (rpmlib, GLIBC filtered): /usr/bin/pkg-config emacs-filesystem Provides -------- emacs-nox: emacs(bin) emacs-nox emacs-nox(x86-64) emacs-common: config(emacs-common) emacs-common emacs-common(x86-64) emacs-terminal: emacs-terminal emacs: emacs emacs(bin) emacs(x86-64) mimehandler(application/x-shellscript) mimehandler(text/english) mimehandler(text/plain) mimehandler(text/x-c) mimehandler(text/x-c++) mimehandler(text/x-c++hdr) mimehandler(text/x-c++src) mimehandler(text/x-chdr) mimehandler(text/x-csrc) mimehandler(text/x-java) mimehandler(text/x-makefile) mimehandler(text/x-moc) mimehandler(text/x-pascal) mimehandler(text/x-tcl) mimehandler(text/x-tex) emacs-filesystem: emacs-filesystem emacs-el: emacs-el pkgconfig(emacs) MD5-sum check ------------- ftp://ftp.gnu.org/gnu/emacs/emacs-24.2.tar.xz : CHECKSUM(SHA256) this package : 1f11b65520611d108eceea886cc1d2573704e18b19aded8a09b75fdea7eb0ddd CHECKSUM(SHA256) upstream package : 1f11b65520611d108eceea886cc1d2573704e18b19aded8a09b75fdea7eb0ddd Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn emacs -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires