Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked when required Note: icons in esc See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - update-desktop-database is invoked when required Note: desktop file(s) in esc See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 1 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: #%define __prelink_undo_cmd %{nil} %define escname %{name}-%{version} %define escdir %{_libdir}/%{escname} %define escbindir %{_bindir} %define esc_chromepath chrome/content/esc %define appdir applications %define icondir %{_datadir}/icons/hicolor/48x48/apps %define esc_vendor esc %define autostartdir %{_sysconfdir}/xdg/autostart %define pixmapdir %{_datadir}/pixmaps %define docdir %{_defaultdocdir}/%{escname} %define escappdir src/app/xpcom %define escxuldir src/app/xul/esc %define escxulchromeicons %{escxuldir}/chrome/icons/default %define escdaemon escd [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: esc-1.1.0-18.fc18.x86_64.rpm esc.x86_64: W: spelling-error %description -l en_US cryptographic -> cryptography, cryptographer, crystallographic esc.x86_64: W: spelling-error %description -l en_US smartcards -> smart cards, smart-cards, scratchcards esc.x86_64: W: invalid-license GPL esc.x86_64: W: invalid-url URL: http://directory.fedora.redhat.com/wiki/CoolKey esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/certManager.xul esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/GenericAuth.js esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/GenericAuth.js esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/password.js esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/password.js esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/password.xul esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/password.xul esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/esc.css esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/esc.css esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/advancedinfo.xul esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/advancedinfo.xul esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/escCertManager.js esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/escCertManager.js esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/CertInfo.js esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/CertInfo.js esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/application.ini esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/application.ini esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/MineOverlay.xul esc.x86_64: E: incorrect-fsf-address /usr/bin/esc esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/ESC.js esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/ESC.js esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/defaults/preferences/esc-prefs.js esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/defaults/preferences/esc-prefs.js esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/GenericAuth.xul esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/GenericAuth.xul esc.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/esc.desktop esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/TRAY.js esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/TRAY.js esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/locale/en-US/esc.dtd esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/locale/en-US/esc.dtd esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/esc esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome.manifest esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/security.xul esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/security.xul esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/settings.xul esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/settings.xul esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/icons/default/default.xpm esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/locale/en-US/esc.properties esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/locale/en-US/esc.properties esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/hiddenWindow.xul esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/hiddenWindow.xul esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/contents.rdf esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/contents.rdf esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/config.xul esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/config.xul esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/components/escCLH.js esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/icons/default/esc-window.xpm esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/esc.xul esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/esc.xul esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/content/esc/AdvancedInfo.js esc.x86_64: E: incorrect-fsf-address /usr/lib64/esc-1.1.0/chrome/content/esc/AdvancedInfo.js esc.x86_64: E: zero-length /usr/lib64/esc-1.1.0/chrome/chrome.manifest esc.x86_64: E: script-without-shebang /usr/lib64/esc-1.1.0/chrome/chrome.manifest esc.x86_64: W: no-manual-page-for-binary esc esc.x86_64: E: invalid-desktopfile /usr/share/applications/esc.desktop value "System;Application;SystemSetup;X-Red-Hat-Base;" for key "Categories" in group "Desktop Entry" contains an unregistered value "SystemSetup"; values extending the format should start with "X-" esc.x86_64: E: invalid-desktopfile /usr/share/applications/esc.desktop (will be fatal in the future): value "esc.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path 1 packages and 0 specfiles checked; 54 errors, 6 warnings. Requires -------- esc (rpmlib, GLIBC filtered): /bin/sh coolkey dbus libnotify nspr nss pcsc-lite xulrunner zip Provides -------- esc: esc esc(x86-64) Unversioned so-files -------------------- esc: /usr/lib64/esc-1.1.0/components/librhCoolKey.so esc: /usr/lib64/esc-1.1.0/components/librhTray.so Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn esc -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires