Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in evolution- data-server-devel , evolution-data-server-doc [ ]: glib-compile-schemas is run if required Note: gschema file(s) in evolution-data-server [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 296960 bytes in 5 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define ldap_support 1 %define static_ldap 1 %define krb5_support 1 %define nntp_support 1 %define largefile_support 1 %define glib2_version 2.34.0 %define gtk3_version 3.2.0 %define gcr_version 3.4 %define gtk_doc_version 1.9 %define intltool_version 0.35.5 %define libsecret_version 0.5 %define libgdata_version 0.10.0 %define libgweather_version 3.5.0 %define libical_version 0.46 %define libsoup_version 2.38.1 %define sqlite_version 3.5 %define eds_base_version 3.8 %define camel_provider_dir %{_libdir}/evolution- data-server/camel-providers %define ebook_backends_dir %{_libdir }/evolution-data-server/addressbook-backends %define ecal_backends_dir %{_libdir}/evolution-data-server/calendar-backends %define modules_dir %{_libdir}/evolution-data-server/registry-modules %define krb5dir /usr/kerberos %define ldap_flags --with-openldap=%{_libdir}/evolution- openldap --with-static-ldap %define ldap_flags --with-openldap=yes %define ldap_flags --without-openldap %define krb5_flags --with- krb5=%{krb5dir} %define krb5_flags --without-krb5 %define nntp_flags --enable-nntp=yes %define nntp_flags --enable-nntp=no %define largefile_flags --enable-largefile %define largefile_flags --disable- largefile %define ssl_flags --enable-smime=yes [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 9472000 bytes in /usr/share 972800 evolution-data-server-devel-3.7.4-1.fc19.x86_64.rpm 8499200 evolution- data-server-3.7.4-1.fc19.x86_64.rpm Rpmlint ------- Checking: evolution-data-server-3.7.4-1.fc19.x86_64.rpm evolution-data-server-devel-3.7.4-1.fc19.x86_64.rpm evolution-data-server-doc-3.7.4-1.fc19.noarch.rpm evolution-data-server.x86_64: W: spelling-error Summary(en_US) Backend -> Backed, Back end, Back-end evolution-data-server.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end evolution-data-server.x86_64: E: description-line-too-long C The evolution-data-server package provides a unified backend for programs that work evolution-data-server.x86_64: E: zero-length /usr/share/doc/evolution-data-server-3.7.4/AUTHORS evolution-data-server-devel.x86_64: E: description-line-too-long C Development files needed for building things which link against evolution-data-server. evolution-data-server-devel.x86_64: W: no-documentation evolution-data-server-devel.x86_64: E: incorrect-fsf-address /usr/include/evolution-data-server/camel/camel-msgport.h evolution-data-server-devel.x86_64: E: incorrect-fsf-address /usr/include/evolution-data-server/camel/camel-mempool.h evolution-data-server-devel.x86_64: E: incorrect-fsf-address /usr/include/evolution-data-server/camel/camel-trie.h 3 packages and 0 specfiles checked; 6 errors, 3 warnings. Requires -------- evolution-data-server-doc (rpmlib, GLIBC filtered): evolution-data-server (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libcamel-1.2.so.43()(64bit) libcom_err.so.2()(64bit) libcrypto.so.10()(64bit) libdb-5.3.so()(64bit) libdl.so.2()(64bit) libebackend-1.2.so.6()(64bit) libebook-1.2.so.14()(64bit) libecal-1.2.so.15()(64bit) libedata-book-1.2.so.16()(64bit) libedata-cal-1.2.so.20()(64bit) libedataserver-1.2.so.17()(64bit) libgck-1.so.0()(64bit) libgcr-base-3.so.1()(64bit) libgdata.so.13()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgoa-1.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libgthread-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgweather-3.so.3()(64bit) libical.so.0()(64bit) libicalss.so.0()(64bit) libicalvcal.so.0()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libnsl.so.1()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnss3.so(NSS_3.10)(64bit) libnss3.so(NSS_3.11)(64bit) libnss3.so(NSS_3.11.1)(64bit) libnss3.so(NSS_3.12)(64bit) libnss3.so(NSS_3.12.1)(64bit) libnss3.so(NSS_3.12.5)(64bit) libnss3.so(NSS_3.12.9)(64bit) libnss3.so(NSS_3.2)(64bit) libnss3.so(NSS_3.3)(64bit) libnss3.so(NSS_3.4)(64bit) libnss3.so(NSS_3.6)(64bit) libnss3.so(NSS_3.8)(64bit) libnss3.so(NSS_3.9.2)(64bit) libnss3.so(NSS_3.9.3)(64bit) libnssutil3.so()(64bit) liboauth.so.0()(64bit) libp11-kit.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpthread.so.0()(64bit) libresolv.so.2()(64bit) libsasl2.so.2()(64bit) libsecret-1.so.0()(64bit) libsmime3.so()(64bit) libsmime3.so(NSS_3.2)(64bit) libsmime3.so(NSS_3.4)(64bit) libsmime3.so(NSS_3.4.1)(64bit) libsmime3.so(NSS_3.6)(64bit) libsoup-2.4.so.1()(64bit) libsoup-gnome-2.4.so.1()(64bit) libsqlite3.so.0()(64bit) libssl.so.10()(64bit) libssl3.so()(64bit) libssl3.so(NSS_3.2)(64bit) libssl3.so(NSS_3.4)(64bit) libssl3.so(NSS_3.7.4)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.0)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.9.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) evolution-data-server-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config evolution-data-server gnome-online-accounts-devel libcamel-1.2.so.43()(64bit) libebackend-1.2.so.6()(64bit) libebook-1.2.so.14()(64bit) libecal-1.2.so.15()(64bit) libedata-book-1.2.so.16()(64bit) libedata-cal-1.2.so.20()(64bit) libedataserver-1.2.so.17()(64bit) libgdata-devel libgweather-devel libical-devel libsecret-devel libsoup-devel pkgconfig(camel-1.2) pkgconfig(gio-2.0) pkgconfig(gmodule-2.0) pkgconfig(libebackend-1.2) pkgconfig(libebook-1.2) pkgconfig(libecal-1.2) pkgconfig(libedataserver-1.2) pkgconfig(libical) pkgconfig(libsecret-1) pkgconfig(libsoup-2.4) pkgconfig(libxml-2.0) pkgconfig(nspr) pkgconfig(nss) pkgconfig(sqlite3) sqlite-devel Provides -------- evolution-data-server-doc: evolution-data-server-doc evolution-data-server: evolution-data-server evolution-data-server(x86-64) evolution-webcal libcamel-1.2.so.43()(64bit) libcamelimapx.so()(64bit) libcamellocal.so()(64bit) libcamelnntp.so()(64bit) libcamelpop3.so()(64bit) libcamelsendmail.so()(64bit) libcamelsmtp.so()(64bit) libebackend-1.2.so.6()(64bit) libebook-1.2.so.14()(64bit) libebookbackendfile.so()(64bit) libebookbackendgoogle.so()(64bit) libebookbackendldap.so()(64bit) libebookbackendwebdav.so()(64bit) libecal-1.2.so.15()(64bit) libecalbackendcaldav.so()(64bit) libecalbackendcontacts.so()(64bit) libecalbackendfile.so()(64bit) libecalbackendhttp.so()(64bit) libecalbackendweather.so()(64bit) libedata-book-1.2.so.16()(64bit) libedata-cal-1.2.so.20()(64bit) libedataserver-1.2.so.17()(64bit) module-cache-reaper.so()(64bit) module-data-book-factory-goa.so()(64bit) module-data-cal-factory-goa.so()(64bit) module-gnome-online-accounts.so()(64bit) module-google-backend.so()(64bit) module-trust-prompt.so()(64bit) module-yahoo-backend.so()(64bit) evolution-data-server-devel: evolution-data-server-devel evolution-data-server-devel(x86-64) pkgconfig(camel-1.2) pkgconfig(evolution-data-server-1.2) pkgconfig(libebackend-1.2) pkgconfig(libebook-1.2) pkgconfig(libecal-1.2) pkgconfig(libedata-book-1.2) pkgconfig(libedata-cal-1.2) pkgconfig(libedataserver-1.2) Unversioned so-files -------------------- evolution-data-server: /usr/lib64/evolution-data-server/addressbook-backends/libebookbackendfile.so evolution-data-server: /usr/lib64/evolution-data-server/addressbook-backends/libebookbackendgoogle.so evolution-data-server: /usr/lib64/evolution-data-server/addressbook-backends/libebookbackendldap.so evolution-data-server: /usr/lib64/evolution-data-server/addressbook-backends/libebookbackendwebdav.so evolution-data-server: /usr/lib64/evolution-data-server/addressbook-backends/module-data-book-factory-goa.so evolution-data-server: /usr/lib64/evolution-data-server/calendar-backends/libecalbackendcaldav.so evolution-data-server: /usr/lib64/evolution-data-server/calendar-backends/libecalbackendcontacts.so evolution-data-server: /usr/lib64/evolution-data-server/calendar-backends/libecalbackendfile.so evolution-data-server: /usr/lib64/evolution-data-server/calendar-backends/libecalbackendhttp.so evolution-data-server: /usr/lib64/evolution-data-server/calendar-backends/libecalbackendweather.so evolution-data-server: /usr/lib64/evolution-data-server/calendar-backends/module-data-cal-factory-goa.so evolution-data-server: /usr/lib64/evolution-data-server/camel-providers/libcamelimapx.so evolution-data-server: /usr/lib64/evolution-data-server/camel-providers/libcamellocal.so evolution-data-server: /usr/lib64/evolution-data-server/camel-providers/libcamelnntp.so evolution-data-server: /usr/lib64/evolution-data-server/camel-providers/libcamelpop3.so evolution-data-server: /usr/lib64/evolution-data-server/camel-providers/libcamelsendmail.so evolution-data-server: /usr/lib64/evolution-data-server/camel-providers/libcamelsmtp.so evolution-data-server: /usr/lib64/evolution-data-server/registry-modules/module-cache-reaper.so evolution-data-server: /usr/lib64/evolution-data-server/registry-modules/module-gnome-online-accounts.so evolution-data-server: /usr/lib64/evolution-data-server/registry-modules/module-google-backend.so evolution-data-server: /usr/lib64/evolution-data-server/registry-modules/module-trust-prompt.so evolution-data-server: /usr/lib64/evolution-data-server/registry-modules/module-yahoo-backend.so MD5-sum check ------------- http://download.gnome.org/sources/evolution-data-server/3.7/evolution-data-server-3.7.4.tar.xz : CHECKSUM(SHA256) this package : 1c4ebf75a8b39feaf78e2c99a02ef07ae53d24018bae809949b95801f7a4c4fb CHECKSUM(SHA256) upstream package : 1c4ebf75a8b39feaf78e2c99a02ef07ae53d24018bae809949b95801f7a4c4fb Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn evolution-data-server -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires