Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/temp/rhel- reviews/festival-1.96-23.fc19/festival/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Large documentation must go in a -doc subpackage. Note: Documentation size is 4106240 bytes in 721 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in festival- lib , festival-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Invalid buildroot found: %(mktemp -ud %{_tmppath}/%{name}-%{festivalversion}-%{release}-XXXXXX) [!]: Uses parallel make. [!]: Spec use %global instead of %define. Note: %define festivalversion 1.96 %define docversion 1.4.2 %define speechtoolsversion 1.2.96 %define baseURL http://festvox.org/packed/festival/%{festivalversion} %define diphoneversion 0.19990610 %define nitechbaseURL http://hts.sp.nitech.ac.jp/?plugin=attach&refer=Download&openfile= %define nitechhtsversion 0.20061229 %define hispavocesversion 1.0.0 [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 13086720 bytes in /usr/share 3819520 festival-speechtools-devel-1.2.96-23.fc19.x86_64.rpm 20480 festival- speechtools-libs-1.2.96-23.fc19.x86_64.rpm 10240 festival- lib-1.96-23.fc19.x86_64.rpm 10240 festival-devel-1.96-23.fc19.x86_64.rpm 20480 festival-speechtools-utils-1.2.96-23.fc19.x86_64.rpm 9205760 festival-1.96-23.fc19.x86_64.rpm Rpmlint ------- Checking: festival-1.96-23.fc19.x86_64.rpm festival-lib-1.96-23.fc19.x86_64.rpm festival-devel-1.96-23.fc19.x86_64.rpm festival.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti festival.x86_64: W: no-manual-page-for-binary saytime festival.x86_64: W: no-manual-page-for-binary festival_server festival.x86_64: W: no-manual-page-for-binary festival_server_control festival.x86_64: W: no-manual-page-for-binary text2wave festival-devel.x86_64: W: no-dependency-on festival/festival-libs/libfestival 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- festival (rpmlib, GLIBC filtered): /bin/sh config(festival) festival-lib festival-speechtools-libs festvox-slt-arctic-hts libFestival.so.1.96.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libestbase.so.1.2.96.1()(64bit) libestools.so.1.2.96.1()(64bit) libeststring.so.1.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtinfo.so.5()(64bit) rtld(GNU_HASH) festival-devel (rpmlib, GLIBC filtered): festival-lib festival-speechtools-devel libFestival.so.1.96.0()(64bit) festival-lib (rpmlib, GLIBC filtered): /sbin/ldconfig festival-speechtools-libs libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- festival: config(festival) festival festival(x86-64) festival-devel: festival-devel festival-devel(x86-64) festival-lib: festival-lib festival-lib(x86-64) libFestival.so.1.96.0()(64bit) MD5-sum check ------------- http://hts.sp.nitech.ac.jp/?plugin=attach&refer=Download&openfile=/festvox_nitech_us_awb_arctic_hts.tar.bz2 : CHECKSUM(SHA256) this package : 74ad419a037457adc1841219bc01b75a6abc00c54e9b981d0d78f32c98397500 CHECKSUM(SHA256) upstream package : dce33c6a1443266a8f5fd05033a9fe6dd13d9bbb6d4d18adcd6f3cbbffe99415 http://festvox.org/packed/festival/1.96/festvox_kedlpc16k.tar.gz : CHECKSUM(SHA256) this package : 6b8f11424bda5c81ae8a58f7838e2a9d12fdb39cdfff6ed89f611305391b1a36 CHECKSUM(SHA256) upstream package : 6b8f11424bda5c81ae8a58f7838e2a9d12fdb39cdfff6ed89f611305391b1a36 http://festvox.org/packed/festival/1.96/festvox_kallpc16k.tar.gz : CHECKSUM(SHA256) this package : 9eb6336f35c202c8069d37e489fb009a7e9fd8539cd47644329db1e92c6aba83 CHECKSUM(SHA256) upstream package : 9eb6336f35c202c8069d37e489fb009a7e9fd8539cd47644329db1e92c6aba83 http://v4.guadalinex.org/guadalinex-toro/pool-test/main/f/festival-spanish-voices/festival-spanish-voices_1.0.0.orig.tar.gz : CHECKSUM(SHA256) this package : f86829a92c71b28d5f75eb8d9928a8b5c6b69ec1113637352b27c77f0afa13b8 CHECKSUM(SHA256) upstream package : f86829a92c71b28d5f75eb8d9928a8b5c6b69ec1113637352b27c77f0afa13b8 http://festvox.org/packed/festival/1.4.2/festdoc-1.4.2.tar.gz : CHECKSUM(SHA256) this package : 92916bfa79642c9932e7344eeafac1f58041445db901fead0c7b72a110a895f1 CHECKSUM(SHA256) upstream package : 92916bfa79642c9932e7344eeafac1f58041445db901fead0c7b72a110a895f1 http://festvox.org/packed/festival/1.96/festival-1.96-beta.tar.gz : CHECKSUM(SHA256) this package : 4fa48d3525957762c83f289fba361063b8855f57ff50b7db22754d844aeadbee CHECKSUM(SHA256) upstream package : 4fa48d3525957762c83f289fba361063b8855f57ff50b7db22754d844aeadbee http://festvox.org/packed/festival/1.96/speech_tools-1.2.96-beta.tar.gz : CHECKSUM(SHA256) this package : fa1ce5698e1253ee21e67629f394733ef6ad578af671e3a90ea8b73898a12428 CHECKSUM(SHA256) upstream package : fa1ce5698e1253ee21e67629f394733ef6ad578af671e3a90ea8b73898a12428 http://hts.sp.nitech.ac.jp/?plugin=attach&refer=Download&openfile=/festvox_nitech_us_rms_arctic_hts.tar.bz2 : CHECKSUM(SHA256) this package : 3c973d30cd42ae57d1751b9314f0e1500f03a12ffde8d3212e96b067303d0379 CHECKSUM(SHA256) upstream package : 6e0385f160d9347477556591e281e9d9a20e68d977fcbbfc34bb0f0c6fa5cdda http://hts.sp.nitech.ac.jp/?plugin=attach&refer=Download&openfile=/festvox_nitech_us_slt_arctic_hts.tar.bz2 : CHECKSUM(SHA256) this package : e47f70838d08045e462441f462faa692aafdd06b96b3d19037937b7eaebe44dd CHECKSUM(SHA256) upstream package : 531a965a2c8c3b77983b7dd5097ae0805e986ae5de28626af788fff44f83512b http://hts.sp.nitech.ac.jp/?plugin=attach&refer=Download&openfile=/festvox_nitech_us_jmk_arctic_hts.tar.bz2 : CHECKSUM(SHA256) this package : 4110add458d308f11f0d347c455b402611b146f1041c4b95306a1749a1a697ac CHECKSUM(SHA256) upstream package : d313474f0ebe342b1fe3f5405996670d08ea6c2ecfe3196a366fc192fda1c1bc http://festvox.org/packed/festival/1.96/festlex_CMU.tar.gz : CHECKSUM(SHA256) this package : e0111754cba5e3dd46faa7b61af1460ad273110d5a8570008e35bd3076bd1aa7 CHECKSUM(SHA256) upstream package : e0111754cba5e3dd46faa7b61af1460ad273110d5a8570008e35bd3076bd1aa7 http://festvox.org/packed/festival/1.96/festlex_POSLEX.tar.gz : CHECKSUM(SHA256) this package : 5ef8cc5d35e9f2141b5a0a4774df82dc9731fe7e9800eb09ecf264f2f8503e7b CHECKSUM(SHA256) upstream package : 5ef8cc5d35e9f2141b5a0a4774df82dc9731fe7e9800eb09ecf264f2f8503e7b http://hts.sp.nitech.ac.jp/?plugin=attach&refer=Download&openfile=/festvox_nitech_us_clb_arctic_hts.tar.bz2 : CHECKSUM(SHA256) this package : 784c2abeae80417888dde2f8830a1b7f9abcd47cb9310d4334590ce3733fe8f3 CHECKSUM(SHA256) upstream package : 863543d48b00dd17bba252a855604ea7ed26dd1d74dfcb7437ae32e3bbfddf60 http://hts.sp.nitech.ac.jp/?plugin=attach&refer=Download&openfile=/festvox_nitech_us_bdl_arctic_hts.tar.bz2 : CHECKSUM(SHA256) this package : 3265342e0e07fdaeddac066033fdf77c212e58db60d17655b18ab7494a880928 CHECKSUM(SHA256) upstream package : 7650c28c13c8f14f79687c8037679fdb7c4826d6d412530c36cd3178b0a5a3c3 diff -r also reports differences Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn festival -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires