Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/temp/rhel- reviews/filesystem-3.2-2.fc19/filesystem/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Packages must not store files under /srv, /opt or /usr/local Note: Rpm(s) have files under /srv, /opt or /usr/local: /opt filesystem-3.2-2.fc19.x86_64.rpm /srv filesystem-3.2-2.fc19.x86_64.rpm /usr/local filesystem-3.2-2.fc19.x86_64.rpm See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 0 files. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: filesystem-3.2-2.fc19.x86_64.rpm filesystem.x86_64: E: no-binary filesystem.x86_64: W: no-documentation filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/games filesystem.x86_64: E: non-standard-dir-perm /usr/lib/locale 0555L filesystem.x86_64: E: non-standard-dir-perm /usr/lib64/pm-utils/power.d 0555L filesystem.x86_64: E: non-standard-dir-perm /usr/lib64/games 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/lib64 filesystem.x86_64: E: non-standard-dir-perm /var/tmp 01777L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man9x filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man1x filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man5x filesystem.x86_64: E: non-standard-dir-perm / 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/etc filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man7x filesystem.x86_64: E: non-standard-dir-perm /var/spool/mail 0775L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man3x filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/mann filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man4 filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man5 filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man6 filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man7 filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man1 filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man2 filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man3 filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man9 filesystem.x86_64: W: dangling-relative-symlink /sbin usr/sbin filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man8 filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/include filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/src filesystem.x86_64: E: non-standard-dir-perm /usr/lib64/X11 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/libexec filesystem.x86_64: E: non-standard-dir-perm /usr/share/empty 0555L filesystem.x86_64: E: non-standard-dir-perm /usr/lib 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/info filesystem.x86_64: E: non-standard-dir-perm /usr/lib64/pm-utils 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/sbin filesystem.x86_64: W: dangling-relative-symlink /lib64 usr/lib64 filesystem.x86_64: W: dangling-relative-symlink /lib usr/lib filesystem.x86_64: W: dangling-relative-symlink /bin usr/bin filesystem.x86_64: E: non-standard-dir-perm /tmp 01777L filesystem.x86_64: E: non-standard-dir-perm /proc 0555L filesystem.x86_64: E: non-standard-dir-perm /usr/lib/modules 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man8x filesystem.x86_64: E: non-standard-dir-perm /usr/lib64 0555L filesystem.x86_64: E: non-standard-dir-perm /usr/bin 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/lib filesystem.x86_64: E: non-standard-dir-perm /usr/lib64/sse2 0555L filesystem.x86_64: E: non-standard-dir-perm /usr/lib64/tls 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man4x filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man6x filesystem.x86_64: E: non-standard-dir-perm /usr/lib64/pm-utils/module.d 0555L filesystem.x86_64: E: non-standard-dir-perm /usr/sbin 0555L filesystem.x86_64: E: non-standard-dir-perm /boot 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/applications filesystem.x86_64: E: non-standard-dir-perm /usr/lib/games 0555L filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man/man2x filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/share/man filesystem.x86_64: E: dir-or-file-in-usr-local /usr/local/bin filesystem.x86_64: E: non-standard-dir-perm /usr/lib/sse2 0555L filesystem.x86_64: E: non-standard-dir-perm /usr/lib64/pm-utils/sleep.d 0555L filesystem.x86_64: E: non-standard-dir-perm /root 0550L filesystem.x86_64: E: incorrect-locale-subdir /usr/share/locale/qaa-qtz/LC_MESSAGES 1 packages and 0 specfiles checked; 58 errors, 5 warnings. Requires -------- filesystem (rpmlib, GLIBC filtered): setup Provides -------- filesystem: filesystem filesystem(x86-64) MD5-sum check ------------- https://fedorahosted.org/filesystem/browser/lang-exceptions : CHECKSUM(SHA256) this package : 29787d395c1e78fd53916090f71f695ca85353b32cc10a22fe548f54be92b19c CHECKSUM(SHA256) upstream package : 67e6b4e34f81f1b2fbc3f0819812e308e63f88ca5c9060ae3f6ba5b623a8af22 diff -r also reports differences Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn filesystem -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires