Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked when required Note: icons in firstaidkit-gui See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - update-desktop-database is invoked when required Note: desktop file(s) in firstaidkit-gui See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/firstaidkit/about [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in firstaidkit-engine , firstaidkit-devel , firstaidkit-plugin-all , firstaidkit-gui , firstaidkit-plugin-freespace , firstaidkit-plugin- passwd , firstaidkit-plugin-openscap , firstaidkit-plugin-xserver , firstaidkit-plugin-mdadm-conf , firstaidkit-plugin-key-recovery [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 1 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Test run failed [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} %define _unpackaged_files_terminate_build 0 %define debug_package %{nil} [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: firstaidkit-0.3.2-4.fc18.x86_64.rpm firstaidkit-engine-0.3.2-4.fc18.noarch.rpm firstaidkit-devel-0.3.2-4.fc18.noarch.rpm firstaidkit-plugin-all-0.3.2-4.fc18.x86_64.rpm firstaidkit-gui-0.3.2-4.fc18.noarch.rpm firstaidkit-plugin-freespace-0.3.2-4.fc18.noarch.rpm firstaidkit-plugin-passwd-0.3.2-4.fc18.noarch.rpm firstaidkit-plugin-openscap-0.3.2-4.fc18.noarch.rpm firstaidkit-plugin-xserver-0.3.2-4.fc18.noarch.rpm firstaidkit-plugin-mdadm-conf-0.3.2-4.fc18.noarch.rpm firstaidkit-plugin-key-recovery-0.3.2-4.fc18.noarch.rpm firstaidkit.x86_64: W: invalid-url URL: http://firstaidkit.fedorahosted.org The read operation timed out firstaidkit.x86_64: W: obsolete-not-provided firstaidkit-plugin-grub firstaidkit.x86_64: E: no-binary firstaidkit.x86_64: W: no-documentation firstaidkit-engine.noarch: W: conffile-without-noreplace-flag /etc/firstaidkit/about firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/utils/__init__.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/__init__.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/bin/firstaidkit-shell firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/returns.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/errors.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/utils/backup.py firstaidkit-engine.noarch: E: executable-marked-as-config-file /etc/firstaidkit/about firstaidkit-engine.noarch: E: script-without-shebang /etc/firstaidkit/about firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/bin/firstaidkitrevert firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/utils/errors.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/FirstAidKit.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/configuration.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/reporting.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/dependency.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/issue.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/bin/firstaidkit firstaidkit-engine.noarch: E: executable-marked-as-config-file /etc/firstaidkit/firstaidkit.conf firstaidkit-engine.noarch: E: script-without-shebang /etc/firstaidkit/firstaidkit.conf firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/interpret.py firstaidkit-engine.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/pyfirstaidkit/plugins.py firstaidkit-engine.noarch: W: no-manual-page-for-binary firstaidkit-qs firstaidkit-engine.noarch: W: no-manual-page-for-binary firstaidkit-shell firstaidkit-engine.noarch: W: no-manual-page-for-binary firstaidkitrevert firstaidkit-devel.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/examples/plugin_examples/sample1Plugin.py firstaidkit-devel.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/examples/plugin_examples/dep3.py firstaidkit-devel.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/examples/plugin_examples/sample2Plugin.py firstaidkit-devel.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/examples/plugin_examples/dep1.py firstaidkit-devel.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/examples/plugin_examples/dialogue.py firstaidkit-devel.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/examples/plugin_examples/sample3Plugin/sample3Plugin.py firstaidkit-devel.noarch: W: manual-page-warning /usr/share/man/man1/firstaidkit-plugin.1.gz 10: warning: macro `pyo' not defined firstaidkit-devel.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/examples/plugin_examples/dep2.py firstaidkit-plugin-all.x86_64: W: spelling-error Summary(en_US) gui -> GUI, goo, gun firstaidkit-plugin-all.x86_64: W: no-documentation firstaidkit-gui.noarch: W: no-documentation firstaidkit-gui.noarch: E: script-without-shebang /usr/share/firstaidkit/frontend/firstaidkit.glade firstaidkit-gui.noarch: E: script-without-shebang /usr/share/firstaidkit/frontend/gtk-list.xml firstaidkit-gui.noarch: E: script-without-shebang /usr/share/firstaidkit/frontend/firstaidkit.gladep firstaidkit-gui.noarch: E: script-without-shebang /usr/share/firstaidkit/frontend/__init__.py firstaidkit-gui.noarch: E: script-without-shebang /usr/share/firstaidkit/frontend/frontend_gtk.py firstaidkit-gui.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/frontend/frontend_gtk.py firstaidkit-plugin-freespace.noarch: W: spelling-error %description -l en_US checkes -> checked, checks, checkers firstaidkit-plugin-freespace.noarch: W: no-documentation firstaidkit-plugin-freespace.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/freespace.py firstaidkit-plugin-passwd.noarch: W: no-documentation firstaidkit-plugin-passwd.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/passwd.py firstaidkit-plugin-openscap.noarch: E: description-line-too-long C This FirstAidKit plugin interfaces the OpenSCAP library, which can be used to perform a security/configuration audit of running machine. firstaidkit-plugin-openscap.noarch: W: no-documentation firstaidkit-plugin-openscap.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/openscap_plugin.py firstaidkit-plugin-xserver.noarch: W: spelling-error %description -l en_US xorg -> xor, org, Borg firstaidkit-plugin-xserver.noarch: W: spelling-error %description -l en_US conf -> con, cone, cons firstaidkit-plugin-xserver.noarch: W: no-documentation firstaidkit-plugin-xserver.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/xserver.py firstaidkit-plugin-mdadm-conf.noarch: W: no-documentation firstaidkit-plugin-mdadm-conf.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/mdadm_conf.py firstaidkit-plugin-key-recovery.noarch: W: no-documentation firstaidkit-plugin-key-recovery.noarch: E: incorrect-fsf-address /usr/share/firstaidkit/plugins/key_recovery.py 11 packages and 0 specfiles checked; 41 errors, 20 warnings. Requires -------- firstaidkit-plugin-mdadm-conf (rpmlib, GLIBC filtered): firstaidkit mdadm firstaidkit-plugin-passwd (rpmlib, GLIBC filtered): firstaidkit firstaidkit-plugin-freespace (rpmlib, GLIBC filtered): firstaidkit firstaidkit-gui (rpmlib, GLIBC filtered): firstaidkit pygtk2 pygtk2-libglade zenity firstaidkit-engine (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(firstaidkit-engine) firstaidkit python(abi) firstaidkit-plugin-all (rpmlib, GLIBC filtered): firstaidkit firstaidkit-gui firstaidkit-plugin-freespace firstaidkit-plugin-key-recovery firstaidkit-plugin-mdadm-conf firstaidkit-plugin-openscap firstaidkit-plugin-passwd firstaidkit-plugin-xserver firstaidkit-plugin-openscap (rpmlib, GLIBC filtered): firstaidkit openscap-content openscap-python firstaidkit-devel (rpmlib, GLIBC filtered): /bin/bash firstaidkit firstaidkit-plugin-key-recovery (rpmlib, GLIBC filtered): firstaidkit python-nss python-volume_key firstaidkit (rpmlib, GLIBC filtered): firstaidkit-engine newt firstaidkit-plugin-xserver (rpmlib, GLIBC filtered): firstaidkit Provides -------- firstaidkit-plugin-mdadm-conf: firstaidkit-plugin-mdadm-conf firstaidkit-plugin-passwd: firstaidkit-plugin-passwd firstaidkit-plugin-freespace: firstaidkit-plugin-freespace firstaidkit-gui: firstaidkit-gui firstaidkit-engine: config(firstaidkit-engine) firstaidkit-engine firstaidkit-plugin-all: firstaidkit-plugin-all firstaidkit-plugin-all(x86-64) firstaidkit-plugin-openscap: firstaidkit-plugin-openscap firstaidkit-devel: firstaidkit-devel firstaidkit-plugin-key-recovery: firstaidkit-plugin-key-recovery firstaidkit: firstaidkit firstaidkit(x86-64) firstaidkit-plugin-xserver: firstaidkit-plugin-xserver Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn firstaidkit -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires