Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in fltk-fluid See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Large documentation must go in a -doc subpackage. Note: Documentation size is 1208320 bytes in 158 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fltk-static [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in fltk-fluid [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1259520 bytes in /usr/share 1013760 fltk-devel-1.3.0-9.fc19.x86_64.rpm 204800 fltk-1.3.0-9.fc19.x86_64.rpm 40960 fltk-fluid-1.3.0-9.fc19.x86_64.rpm Rpmlint ------- Checking: fltk-1.3.0-9.fc19.x86_64.rpm fltk-devel-1.3.0-9.fc19.x86_64.rpm fltk-static-1.3.0-9.fc19.x86_64.rpm fltk-fluid-1.3.0-9.fc19.x86_64.rpm fltk.x86_64: W: spelling-error %description -l en_US fulltick -> full tick, full-tick, fullback fltk.x86_64: W: shared-lib-calls-exit /usr/lib64/libfltk_forms.so.1.3 exit@GLIBC_2.2.5 fltk-devel.x86_64: W: no-manual-page-for-binary fltk-config-x86_64 fltk-static.x86_64: W: no-documentation fltk-static.x86_64: W: spurious-executable-perm /usr/lib64/libfltk_forms.a fltk-static.x86_64: W: spurious-executable-perm /usr/lib64/libfltk_gl.a fltk-static.x86_64: W: spurious-executable-perm /usr/lib64/libfltk.a fltk-static.x86_64: W: spurious-executable-perm /usr/lib64/libfltk_images.a fltk-fluid.x86_64: E: devel-dependency fltk-devel 4 packages and 0 specfiles checked; 1 errors, 8 warnings. Requires -------- fltk-devel (rpmlib, GLIBC filtered): /bin/bash /bin/sh fltk(x86-64) libfltk.so.1.3()(64bit) libfltk_forms.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libstdc++-devel pkgconfig(ice) pkgconfig(sm) pkgconfig(x11) pkgconfig(xft) pkgconfig(xt) fltk-static (rpmlib, GLIBC filtered): fltk-devel fltk-fluid (rpmlib, GLIBC filtered): /bin/sh fltk(x86-64) fltk-devel libX11.so.6()(64bit) libXcursor.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXft.so.2()(64bit) libXinerama.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_forms.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libfontconfig.so.1()(64bit) libgcc_s.so.1()(64bit) libjpeg.so.62()(64bit) libm.so.6()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) fltk (rpmlib, GLIBC filtered): /sbin/ldconfig libGL.so.1()(64bit) libGLU.so.1()(64bit) libX11.so.6()(64bit) libXcursor.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXft.so.2()(64bit) libXinerama.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfontconfig.so.1()(64bit) libgcc_s.so.1()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- fltk-devel: fltk-devel fltk-devel(x86-64) fltk-static: fltk-static fltk-static(x86-64) fltk-fluid: fltk-fluid fltk-fluid(x86-64) mimehandler(application/x-fluid) fltk: fltk fltk(x86-64) libfltk.so.1.3()(64bit) libfltk_forms.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) MD5-sum check ------------- http://ftp.easysw.com/pub/fltk/snapshots/fltk-1.3.x-r9671.tar.bz2 : CHECKSUM(SHA256) this package : cd90b89ed7689d97c53056d2b76f080ae71b0ea76a5c1cdfa79f83601a2d58bd CHECKSUM(SHA256) upstream package : cd90b89ed7689d97c53056d2b76f080ae71b0ea76a5c1cdfa79f83601a2d58bd Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn fltk -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires