Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in gedit See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gedit-devel , gedit-zeitgeist [ ]: glib-compile-schemas is run if required Note: gschema file(s) in gedit [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 3 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Test run failed [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define glib2_version 2.28.0 %define pygo_version 2.90 %define desktop_file_utils_version 0.9 %define gtksourceview_version 3.0.0 %define enchant_version 1.2.0 %define isocodes_version 0.35 %define libpeas_version 1.7.0 %define zeitgeist_version 0.3.2 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 13824000 bytes in /usr/share 542720 gedit-devel-3.7.3-1.fc19.x86_64.rpm 13281280 gedit-3.7.3-1.fc19.x86_64.rpm Rpmlint ------- Checking: gedit-3.7.3-1.fc19.x86_64.rpm gedit-devel-3.7.3-1.fc19.x86_64.rpm gedit-zeitgeist-3.7.3-1.fc19.x86_64.rpm gedit.x86_64: W: incoherent-version-in-changelog 2:3.7.3-2 ['2:3.7.3-1.fc19', '2:3.7.3-1'] gedit.x86_64: E: incorrect-fsf-address /usr/share/gedit/plugins/snippets/lang/snippets.lang gedit.x86_64: E: incorrect-fsf-address /usr/lib64/gedit/plugins/pythonconsole/__init__.py gedit.x86_64: E: incorrect-fsf-address /usr/lib64/gedit/plugins/quickopen/virtualdirs.py gedit.x86_64: E: incorrect-fsf-address /usr/share/doc/gedit-3.7.3/COPYING gedit.x86_64: E: incorrect-fsf-address /usr/lib64/gedit/plugins/quickopen/popup.py gedit.x86_64: E: incorrect-fsf-address /usr/lib64/gedit/plugins/pythonconsole/console.py gedit.x86_64: E: incorrect-fsf-address /usr/lib64/gedit/plugins/snippets/signals.py gedit.x86_64: E: incorrect-fsf-address /usr/lib64/gedit/plugins/quickopen/__init__.py gedit.x86_64: E: incorrect-fsf-address /usr/lib64/gedit/plugins/pythonconsole/config.py gedit.x86_64: W: no-manual-page-for-binary gnome-text-editor gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-progress-info-bar.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-encodings.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-app.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-statusbar.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-window.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-debug.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-encodings-combo-box.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-utils.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-window-activatable.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-app-activatable.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-view-activatable.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-document.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-view.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-commands.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-panel.h gedit-devel.x86_64: E: incorrect-fsf-address /usr/include/gedit-3.0/gedit/gedit-tab.h gedit-zeitgeist.x86_64: W: spelling-error %description -l en_US dataprovider -> data provider, data-provider, providential gedit-zeitgeist.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 25 errors, 4 warnings. Requires -------- gedit-zeitgeist (rpmlib, GLIBC filtered): gedit libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libgirepository-1.0.so.1()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtksourceview-3.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpeas-1.0.so.0()(64bit) libpeas-gtk-1.0.so.0()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libzeitgeist-1.0.so.1()(64bit) rtld(GNU_HASH) gedit-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gedit gtksourceview3-devel pkgconfig(gtksourceview-3.0) pkgconfig(libpeas-1.0) pkgconfig(libpeas-gtk-1.0) gedit (rpmlib, GLIBC filtered): /bin/sh desktop-file-utils gsettings-desktop-schemas gvfs libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libenchant.so.1()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgedit-private.so()(64bit) libgio-2.0.so.0()(64bit) libgirepository-1.0.so.1()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtksourceview-3.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpeas-1.0.so.0()(64bit) libpeas-gtk-1.0.so.0()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.0)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) python(abi) rtld(GNU_HASH) zenity Provides -------- gedit-zeitgeist: gedit-zeitgeist gedit-zeitgeist(x86-64) libzeitgeistplugin.so()(64bit) gedit-devel: gedit-devel gedit-devel(x86-64) pkgconfig(gedit) gedit: gedit gedit(x86-64) libchangecase.so()(64bit) libdocinfo.so()(64bit) libfilebrowser.so()(64bit) libgedit-private.so()(64bit) libmodelines.so()(64bit) libsort.so()(64bit) libspell.so()(64bit) libtime.so()(64bit) mimehandler(text/plain) Unversioned so-files -------------------- gedit: /usr/lib64/gedit/libgedit-private.so gedit: /usr/lib64/gedit/plugins/libchangecase.so gedit: /usr/lib64/gedit/plugins/libdocinfo.so gedit: /usr/lib64/gedit/plugins/libfilebrowser.so gedit: /usr/lib64/gedit/plugins/libmodelines.so gedit: /usr/lib64/gedit/plugins/libsort.so gedit: /usr/lib64/gedit/plugins/libspell.so gedit: /usr/lib64/gedit/plugins/libtime.so gedit-zeitgeist: /usr/lib64/gedit/plugins/libzeitgeistplugin.so MD5-sum check ------------- http://download.gnome.org/sources/gedit/3.7/gedit-3.7.3.tar.xz : CHECKSUM(SHA256) this package : eae93d2751eda8035bfc3d038d97f31797e123fec312f428a1d08d50e9722c35 CHECKSUM(SHA256) upstream package : eae93d2751eda8035bfc3d038d97f31797e123fec312f428a1d08d50e9722c35 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn gedit -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires