Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find license.page in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 40960 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Binary eggs must be removed in %prep Note: Test run failed [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: gnome-devel-docs-3.6.2-1.fc18.noarch.rpm gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/label.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/grid.c gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/messagedialog.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/el/samples/helloWorld/README ../../C/samples/helloWorld/README gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/03_getting_the_signal_01.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/el/samples/helloWorld/autogen.sh ../../C/samples/helloWorld/autogen.sh gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/guitar-tuner/guitar-tuner.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/fr/samples/helloWorld/configure.ac ../../C/samples/helloWorld/configure.ac gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/grid.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/gmenu.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/treeview_simple_liststore.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/image.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/fr/samples/helloWorld/Makefile.am ../../C/samples/helloWorld/Makefile.am gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/image-viewer/image-viewer.c gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/progressbar.c gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/textview.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/ca/samples/helloWorld/configure.ac ../../C/samples/helloWorld/configure.ac gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/de/samples/helloWorld/helloWorld ../../C/samples/helloWorld/helloWorld gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/03_getting_the_signal_03.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/button.c gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/scale.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/es/samples/helloWorld/README ../../C/samples/helloWorld/README gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/ca/samples/helloWorld/Makefile.am ../../C/samples/helloWorld/Makefile.am gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/el/samples/helloWorld/helloWorld.desktop.in ../../C/samples/helloWorld/helloWorld.desktop.in gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/checkbutton.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/gl/samples/helloWorld/helloWorld ../../C/samples/helloWorld/helloWorld gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/switch.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/ca/samples/helloWorld/helloWorld ../../C/samples/helloWorld/helloWorld gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/aboutdialog.c gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/image.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/gl/samples/helloWorld/configure.ac ../../C/samples/helloWorld/configure.ac gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/es/samples/helloWorld/helloWorld.desktop.in ../../C/samples/helloWorld/helloWorld.desktop.in gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/radiobutton.c gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/photo-wall/photo-wall.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/es/samples/helloWorld/helloWorld ../../C/samples/helloWorld/helloWorld gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/spinbutton.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/gl/samples/helloWorld/Makefile.am ../../C/samples/helloWorld/Makefile.am gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/ca/samples/helloWorld/helloWorld.desktop.in ../../C/samples/helloWorld/helloWorld.desktop.in gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/GtkApplicationWindow.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/entry.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/de/samples/helloWorld/configure.ac ../../C/samples/helloWorld/configure.ac gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/de/samples/helloWorld/README ../../C/samples/helloWorld/README gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/fr/samples/helloWorld/autogen.sh ../../C/samples/helloWorld/autogen.sh gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/switch.c gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/guitar-tuner/guitar-tuner.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/comboboxtext.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/button.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/toolbar.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/ca/samples/helloWorld/README ../../C/samples/helloWorld/README gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/window.c gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/label.c gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/dialog.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/es/samples/helloWorld/autogen.sh ../../C/samples/helloWorld/autogen.sh gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/de/samples/helloWorld/Makefile.am ../../C/samples/helloWorld/Makefile.am gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/gl/samples/helloWorld/helloWorld.desktop.in ../../C/samples/helloWorld/helloWorld.desktop.in gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/es/samples/helloWorld/configure.ac ../../C/samples/helloWorld/configure.ac gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/03_getting_the_signal_04.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/ca/samples/helloWorld/autogen.sh ../../C/samples/helloWorld/autogen.sh gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/dialog.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/radiobutton.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/guitar-tuner/guitar-tuner.py 0644L /usr/bin/python gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/combobox.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/GtkApplicationWindow.c gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/spinner.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/gl/samples/helloWorld/autogen.sh ../../C/samples/helloWorld/autogen.sh gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/progressbar.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/messagedialog.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/fr/samples/helloWorld/helloWorld ../../C/samples/helloWorld/helloWorld gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/statusbar.c gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/entry.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/el/samples/helloWorld/configure.ac ../../C/samples/helloWorld/configure.ac gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/fr/samples/helloWorld/helloWorld.desktop.in ../../C/samples/helloWorld/helloWorld.desktop.in gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/fr/samples/helloWorld/README ../../C/samples/helloWorld/README gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/de/samples/helloWorld/autogen.sh ../../C/samples/helloWorld/autogen.sh gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/window.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/togglebutton.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/02_welcome_to_the_grid.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/de/samples/helloWorld/helloWorld.desktop.in ../../C/samples/helloWorld/helloWorld.desktop.in gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/menubutton.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/helloWorld/helloWorld 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: incorrect-fsf-address /usr/share/doc/gnome-devel-docs-3.6.2/COPYING gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/gmenu.c gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/linkbutton.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/gl/samples/helloWorld/README ../../C/samples/helloWorld/README gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/spinbutton.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/el/samples/helloWorld/Makefile.am ../../C/samples/helloWorld/Makefile.am gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/helloWorld.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/checkbutton.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/scale.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/helloWorld/autogen.sh 0644L /bin/sh gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/message-board/message-board.c gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/hellognome.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/el/samples/helloWorld/helloWorld ../../C/samples/helloWorld/helloWorld gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/spinner.c gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/image-viewer/image-viewer.py 0644L /usr/bin/python gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/linkbutton.c gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/textview.c gnome-devel-docs.noarch: W: dangling-relative-symlink /usr/share/gnome/help/gnome-devel-demos/es/samples/helloWorld/Makefile.am ../../C/samples/helloWorld/Makefile.am gnome-devel-docs.noarch: W: devel-file-in-non-devel-package /usr/share/gnome/help/gnome-devel-demos/C/samples/togglebutton.c gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/03_getting_the_signal_02.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/aboutdialog.js 0644L /usr/bin/gjs gnome-devel-docs.noarch: E: non-executable-script /usr/share/gnome/help/gnome-devel-demos/C/samples/statusbar.js 0644L /usr/bin/gjs 1 packages and 0 specfiles checked; 40 errors, 62 warnings. Requires -------- gnome-devel-docs (rpmlib, GLIBC filtered): Provides -------- gnome-devel-docs: gnome-devel-docs MD5-sum check ------------- http://download.gnome.org/sources/gnome-devel-docs/3.6/gnome-devel-docs-3.6.2.tar.xz : CHECKSUM(SHA256) this package : 342ee059a2f15a9ef652e0ee7d452f78f6aa58db375a2f8e799c6fbed45841b3 CHECKSUM(SHA256) upstream package : 342ee059a2f15a9ef652e0ee7d452f78f6aa58db375a2f8e799c6fbed45841b3 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn gnome-devel-docs -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires