Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in gnome-disk-utility See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: glib-compile-schemas is run if required Note: gschema file(s) in gnome-disk-utility [ ]: Package complies to the Packaging Guidelines [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in gnome-disk-utility [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 4 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define glib2_version 2.31.0 %define gtk3_version 3.5.8 %define udisks_version 2.0.90 %define gnome_settings_daemon_version 3.7.3 %define enable_autoreconf 0 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5017600 bytes in /usr/share 5017600 gnome-disk-utility-3.7.1-1.fc19.x86_64.rpm Rpmlint ------- Checking: gnome-disk-utility-3.7.1-1.fc19.x86_64.rpm gnome-disk-utility.x86_64: W: spelling-error %description -l en_US fstab -> stab, f stab gnome-disk-utility.x86_64: W: spelling-error %description -l en_US crypttab -> crypt tab, crypt-tab, cryptic gnome-disk-utility.x86_64: W: obsolete-not-provided gnome-disk-utility-format gnome-disk-utility.x86_64: W: obsolete-not-provided nautilus-gdu gnome-disk-utility.x86_64: W: obsolete-not-provided gnome-disk-utility-libs gnome-disk-utility.x86_64: W: obsolete-not-provided gnome-disk-utility-devel gnome-disk-utility.x86_64: W: obsolete-not-provided gnome-disk-utility-ui-libs gnome-disk-utility.x86_64: W: obsolete-not-provided gnome-disk-utility-ui-devel gnome-disk-utility.x86_64: W: obsolete-not-provided gnome-disk-utility-nautilus 1 packages and 0 specfiles checked; 0 errors, 9 warnings. Requires -------- gnome-disk-utility (rpmlib, GLIBC filtered): /bin/sh libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libcanberra-gtk3.so.0()(64bit) libcanberra.so.0()(64bit) libdvdread.so.4()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libm.so.6()(64bit) libnotify.so.4()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpwquality.so.1()(64bit) libpwquality.so.1(LIBPWQUALITY_1.0)(64bit) libsecret-1.so.0()(64bit) libsystemd-login.so.0()(64bit) libsystemd-login.so.0(LIBSYSTEMD_LOGIN_31)(64bit) libudisks2.so.0()(64bit) rtld(GNU_HASH) udisks2 Provides -------- gnome-disk-utility: gnome-disk-utility gnome-disk-utility(x86-64) libgdu-sd.so()(64bit) mimehandler(application/x-cd-image) Unversioned so-files -------------------- gnome-disk-utility: /usr/lib64/gnome-settings-daemon-3.0/libgdu-sd.so Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn gnome-disk-utility -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires