Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Package does not contain any libtool archives (.la) Note: gnome-shell : /usr/lib64/gnome-shell/libgnome-shell-js.la gnome-shell : /usr/lib64/gnome-shell/libgnome-shell.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries - glib-compile-schemas is run if required Note: gschema file(s) in gnome-shell See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: The spec file handles locales properly. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: update-desktop-database is invoked when required Note: desktop file(s) in gnome-shell [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define clutter_version 1.13.2 %define gnome_bluetooth_version 3.5.5 %define gobject_introspection_version 0.10.1 %define gjs_version 1.35.4 %define mutter_version 3.7.4 %define eds_version 3.5.3 %define gnome_desktop_version 3.7.1 %define gnome_menus_version 3.5.3 %define json_glib_version 0.13.2 %define gsettings_desktop_schemas_version 3.7.4 %define libcroco_version 0.6.8 [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4372480 bytes in /usr/share 4372480 gnome-shell-3.7.4.1-1.fc19.x86_64.rpm Rpmlint ------- Checking: gnome-shell-3.7.4.1-1.fc19.x86_64.rpm gnome-shell.x86_64: E: explicit-lib-dependency librsvg2(x86-64) gnome-shell.x86_64: E: incorrect-fsf-address /usr/share/gnome-shell/js/ui/endSessionDialog.js gnome-shell.x86_64: E: incorrect-fsf-address /usr/share/gnome-shell/js/gdm/powerMenu.js gnome-shell.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-shell-3.7.4.1/COPYING gnome-shell.x86_64: E: incorrect-fsf-address /usr/share/gnome-shell/js/gdm/batch.js gnome-shell.x86_64: E: incorrect-fsf-address /usr/share/gnome-shell/js/gdm/loginDialog.js gnome-shell.x86_64: W: no-manual-page-for-binary gnome-shell-extension-tool gnome-shell.x86_64: W: no-manual-page-for-binary gnome-shell-extension-prefs 1 packages and 0 specfiles checked; 6 errors, 2 warnings. Requires -------- gnome-shell (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python accountsservice-libs(x86-64) at-spi2-atk(x86-64) caribou(x86-64) clutter(x86-64) gdm-libs(x86-64) gjs(x86-64) gnome-bluetooth(x86-64) gnome-desktop3 gnome-desktop3(x86-64) gnome-menus(x86-64) gobject-introspection(x86-64) gsettings-desktop-schemas(x86-64) json-glib(x86-64) libGL.so.1()(64bit) libX11.so.6()(64bit) libXcomposite.so.1()(64bit) libXdamage.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXi.so.6()(64bit) libatk-1.0.so.0()(64bit) libatk-bridge-2.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libcamel-1.2.so.43()(64bit) libcanberra.so.0()(64bit) libclutter-1.0.so.0()(64bit) libcogl-pango.so.0()(64bit) libcogl.so.11()(64bit) libcroco(x86-64) libcroco-0.6.so.3()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libdl.so.2()(64bit) libecal-1.2.so.15()(64bit) libedataserver-1.2.so.17()(64bit) libgck-1.so.0()(64bit) libgcr-3.so.1()(64bit) libgcr-base-3.so.1()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libgirepository-1.0.so.1()(64bit) libgjs.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgnome-bluetooth-applet.so.0()(64bit) libgnome-keyring.so.0()(64bit) libgnome-menu-3.so.0()(64bit) libgnome-shell-js.so()(64bit) libgnome-shell.so()(64bit) libgobject-2.0.so.0()(64bit) libgstbase-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libical.so.0()(64bit) libicalss.so.0()(64bit) libicalvcal.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libm.so.6()(64bit) libmozjs185.so.1.0()(64bit) libmutter.so.0()(64bit) libnm-glib.so.4()(64bit) libnm-gtk.so.0()(64bit) libnm-util.so.2()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnssutil3.so()(64bit) libp11-kit.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpolkit-agent-1.so.0()(64bit) libpolkit-gobject-1.so.0()(64bit) libpthread.so.0()(64bit) libpulse-mainloop-glib.so.0()(64bit) libpulse-mainloop-glib.so.0(PULSE_0)(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) librsvg2(x86-64) libsecret-1.so.0()(64bit) libsmime3.so()(64bit) libsoup-2.4.so.1()(64bit) libsqlite3.so.0()(64bit) libssl3.so()(64bit) libstartup-notification-1.so.0()(64bit) libtelepathy-glib.so.0()(64bit) libtelepathy-glib.so.0(TELEPATHY_GLIB_0.11.5)(64bit) libtelepathy-glib.so.0(TELEPATHY_GLIB_0.11.6)(64bit) libtelepathy-glib.so.0(TELEPATHY_GLIB_0.7.0)(64bit) libtelepathy-glib.so.0(TELEPATHY_GLIB_0.7.29)(64bit) libtelepathy-glib.so.0(TELEPATHY_GLIB_0.7.36)(64bit) libtelepathy-logger.so.3()(64bit) libxml2.so.2()(64bit) mozilla-filesystem(x86-64) mutter(x86-64) polkit(x86-64) rtld(GNU_HASH) upower(x86-64) Provides -------- gnome-shell: desktop-notification-daemon gnome-shell gnome-shell(x86-64) libgnome-shell-browser-plugin.so()(64bit) libgnome-shell-js.so()(64bit) libgnome-shell.so()(64bit) Unversioned so-files -------------------- gnome-shell: /usr/lib64/gnome-shell/libgnome-shell-js.so gnome-shell: /usr/lib64/gnome-shell/libgnome-shell.so gnome-shell: /usr/lib64/mozilla/plugins/libgnome-shell-browser-plugin.so MD5-sum check ------------- http://download.gnome.org/sources/gnome-shell/3.7/gnome-shell-3.7.4.1.tar.xz : CHECKSUM(SHA256) this package : 799f918b3a8da53e104057bd731aedb071c2f018faef571abe79212200bbf36d CHECKSUM(SHA256) upstream package : 799f918b3a8da53e104057bd731aedb071c2f018faef571abe79212200bbf36d Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn gnome-shell -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires