Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in gvfs-archive See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gvfs-devel [ ]: gio-querymodules is invoked as required Note: gio module file(s) in gvfs [ ]: glib-compile-schemas is run if required Note: gschema file(s) in gvfs [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 102400 bytes in 5 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3768320 bytes in /usr/share 10240 gvfs-archive-1.15.2-1.fc19.x86_64.rpm 10240 gvfs- smb-1.15.2-1.fc19.x86_64.rpm 10240 gvfs-fuse-1.15.2-1.fc19.x86_64.rpm 3686400 gvfs-1.15.2-1.fc19.x86_64.rpm 10240 gvfs- afc-1.15.2-1.fc19.x86_64.rpm 10240 gvfs-obexftp-1.15.2-1.fc19.x86_64.rpm 10240 gvfs-gphoto2-1.15.2-1.fc19.x86_64.rpm 10240 gvfs- afp-1.15.2-1.fc19.x86_64.rpm 10240 gvfs-mtp-1.15.2-1.fc19.x86_64.rpm Rpmlint ------- Checking: gvfs-1.15.2-1.fc19.x86_64.rpm gvfs-devel-1.15.2-1.fc19.x86_64.rpm gvfs-fuse-1.15.2-1.fc19.x86_64.rpm gvfs-smb-1.15.2-1.fc19.x86_64.rpm gvfs-archive-1.15.2-1.fc19.x86_64.rpm gvfs-obexftp-1.15.2-1.fc19.x86_64.rpm gvfs-gphoto2-1.15.2-1.fc19.x86_64.rpm gvfs-afc-1.15.2-1.fc19.x86_64.rpm gvfs-afp-1.15.2-1.fc19.x86_64.rpm gvfs-mtp-1.15.2-1.fc19.x86_64.rpm gvfs.x86_64: W: spelling-error Summary(en_US) Backends -> Back ends, Back-ends, Backhands gvfs.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end gvfs.x86_64: W: spelling-error %description -l en_US sftp -> ftp, ftps, s ftp gvfs.x86_64: W: spelling-error %description -l en_US cifs -> ifs, coifs, c ifs gvfs.x86_64: W: obsolete-not-provided gnome-mount gvfs.x86_64: W: obsolete-not-provided gnome-mount-nautilus-properties gvfs.x86_64: W: no-manual-page-for-binary gvfs-less gvfs-devel.x86_64: W: no-documentation gvfs-fuse.x86_64: W: spelling-error %description -l en_US gio -> goo, go, giro gvfs-fuse.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems gvfs-smb.x86_64: W: spelling-error Summary(en_US) fileshare -> file share, file-share, files hare gvfs-smb.x86_64: W: no-documentation gvfs-archive.x86_64: W: no-documentation gvfs-obexftp.x86_64: W: obsolete-not-provided gnome-vfs2-obexftp gvfs-obexftp.x86_64: W: no-documentation gvfs-gphoto2.x86_64: W: summary-not-capitalized C gphoto2 support for gvfs gvfs-gphoto2.x86_64: W: no-documentation gvfs-afc.x86_64: W: no-documentation gvfs-afp.x86_64: W: obsolete-not-provided gvfs gvfs-afp.x86_64: W: no-documentation gvfs-mtp.x86_64: W: no-documentation 10 packages and 0 specfiles checked; 0 errors, 21 warnings. Requires -------- gvfs-afp (rpmlib, GLIBC filtered): gvfs(x86-64) libbluray.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcrypt.so.11()(64bit) libgcrypt.so.11(GCRYPT_1.2)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgpg-error.so.0()(64bit) libgvfscommon.so.0()(64bit) libpthread.so.0()(64bit) libsecret-1.so.0()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) gvfs-smb (rpmlib, GLIBC filtered): /bin/sh gvfs(x86-64) libbluray.so.1()(64bit) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgvfscommon.so.0()(64bit) libpthread.so.0()(64bit) libsecret-1.so.0()(64bit) libsmbclient.so.0()(64bit) libsmbclient.so.0(SMBCLIENT_0.1.0)(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) gvfs-archive (rpmlib, GLIBC filtered): /bin/sh gvfs(x86-64) libarchive.so.13()(64bit) libbluray.so.1()(64bit) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgvfscommon.so.0()(64bit) libpthread.so.0()(64bit) libsecret-1.so.0()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) gvfs-gphoto2 (rpmlib, GLIBC filtered): /bin/sh gvfs(x86-64) libbluray.so.1()(64bit) libc.so.6()(64bit) libexif.so.12()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgphoto2.so.6()(64bit) libgphoto2_port.so.10()(64bit) libgphoto2_port.so.10(LIBGPHOTO2_5_0)(64bit) libgudev-1.0.so.0()(64bit) libgvfscommon.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libsecret-1.so.0()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) gvfs-afc (rpmlib, GLIBC filtered): /bin/sh gvfs(x86-64) libbluray.so.1()(64bit) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgnutls.so.26()(64bit) libgobject-2.0.so.0()(64bit) libgvfscommon.so.0()(64bit) libimobiledevice.so.3()(64bit) libplist.so.1()(64bit) libpthread.so.0()(64bit) libsecret-1.so.0()(64bit) libtasn1.so.3()(64bit) libusbmuxd.so.2()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) usbmuxd gvfs-fuse (rpmlib, GLIBC filtered): fuse gvfs(x86-64) libbluray.so.1()(64bit) libc.so.6()(64bit) libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.6)(64bit) libfuse.so.2(FUSE_2.8)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgvfscommon.so.0()(64bit) libpthread.so.0()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) gvfs (rpmlib, GLIBC filtered): /bin/sh desktop-file-utils glib2 libatk-1.0.so.0()(64bit) libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libavahi-glib.so.1()(64bit) libbluray.so.1()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libcdio.so.14()(64bit) libcdio.so.14(CDIO_14)(64bit) libcdio_cdda.so.1()(64bit) libcdio_cdda.so.1(CDIO_CDDA_1)(64bit) libcdio_paranoia.so.1()(64bit) libcdio_paranoia.so.1(CDIO_PARANOIA_1)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgudev-1.0.so.0()(64bit) libgvfscommon.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsecret-1.so.0()(64bit) libsoup-2.4.so.1()(64bit) libsoup-gnome-2.4.so.1()(64bit) libsystemd-login.so.0()(64bit) libsystemd-login.so.0(LIBSYSTEMD_LOGIN_31)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libudisks2.so.0()(64bit) libutil.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) udisks2 gvfs-mtp (rpmlib, GLIBC filtered): /bin/sh gvfs(x86-64) libbluray.so.1()(64bit) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgudev-1.0.so.0()(64bit) libgvfscommon.so.0()(64bit) libmtp.so.9()(64bit) libpthread.so.0()(64bit) libsecret-1.so.0()(64bit) libusb-1.0.so.0()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) gvfs-devel (rpmlib, GLIBC filtered): gvfs libgvfscommon.so.0()(64bit) gvfs-obexftp (rpmlib, GLIBC filtered): /bin/sh gvfs(x86-64) libbluetooth.so.3()(64bit) libbluray.so.1()(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libexpat.so.1()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgvfscommon.so.0()(64bit) libpthread.so.0()(64bit) libsecret-1.so.0()(64bit) libutil.so.1()(64bit) obex-data-server rtld(GNU_HASH) Provides -------- gvfs-afp: gvfs-afp gvfs-afp(x86-64) gvfs-smb: gvfs-smb gvfs-smb(x86-64) gvfs-archive: gvfs-archive gvfs-archive(x86-64) mimehandler(application/x-bzip-compressed-tar) mimehandler(application/x-cd-image) mimehandler(application/x-compressed-tar) mimehandler(application/x-cpio) mimehandler(application/x-lzma-compressed-tar) mimehandler(application/x-tar) mimehandler(application/x-xz-compressed-tar) mimehandler(application/x-zip) mimehandler(application/zip) gvfs-gphoto2: gvfs-gphoto2 gvfs-gphoto2(x86-64) gvfs-afc: gvfs-afc gvfs-afc(x86-64) gvfs-fuse: gvfs-fuse gvfs-fuse(x86-64) gvfs: gvfs gvfs(x86-64) libgioremote-volume-monitor.so()(64bit) libgvfscommon.so.0()(64bit) libgvfsdbus.so()(64bit) gvfs-mtp: gvfs-mtp gvfs-mtp(x86-64) gvfs-devel: gvfs-devel gvfs-devel(x86-64) gvfs-obexftp: gvfs-obexftp gvfs-obexftp(x86-64) Unversioned so-files -------------------- gvfs: /usr/lib64/gio/modules/libgioremote-volume-monitor.so gvfs: /usr/lib64/gio/modules/libgvfsdbus.so MD5-sum check ------------- http://download.gnome.org/sources/gvfs/1.15/gvfs-1.15.2.tar.xz : CHECKSUM(SHA256) this package : 2d8169c4d5e77cfdf0a22f805dc1592c1e66720477ee6bf9eafa49dcffdfb004 CHECKSUM(SHA256) upstream package : 2d8169c4d5e77cfdf0a22f805dc1592c1e66720477ee6bf9eafa49dcffdfb004 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn gvfs -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires