Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in hamcrest-demo See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java - Javadoc subpackages have Requires: jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hamcrest- javadoc , hamcrest-demo [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 1 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [ ]: Bundled jar/class files should be removed before build Note: Test run failed [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [ ]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define with() %{expand:%%{?with_%{1}:1}%%{!?with_%{1}:0}} %define without() %{expand:%%{?with_%{1}:0}%%{!?with_%{1}:1}} %define bcond_with() %{expand:%%{?_with_%{1}:%%global with_%{1} 1}} %define bcond_without() %{expand:%%{!?_without_%{1}:%%global with_%{1} 1}} [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: hamcrest-1.1-21.fc19.noarch.rpm hamcrest-javadoc-1.1-21.fc19.noarch.rpm hamcrest-demo-1.1-21.fc19.noarch.rpm hamcrest.noarch: W: spelling-error Summary(en_US) matchers -> marchers, matches, catchers hamcrest.noarch: W: spelling-error %description -l en_US matcher -> marcher, matches, catcher hamcrest.noarch: W: spelling-error %description -l en_US declaratively -> declarative, decoratively, relatively hamcrest-demo.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- hamcrest-demo (rpmlib, GLIBC filtered): hamcrest junit hamcrest-javadoc (rpmlib, GLIBC filtered): hamcrest (rpmlib, GLIBC filtered): easymock2 java osgi(org.hamcrest.core) osgi(org.hamcrest.library) qdox Provides -------- hamcrest-demo: hamcrest-demo hamcrest-javadoc: hamcrest-javadoc hamcrest: hamcrest mvn(org.hamcrest:hamcrest-all) mvn(org.hamcrest:hamcrest-core) mvn(org.hamcrest:hamcrest-generator) mvn(org.hamcrest:hamcrest-integration) mvn(org.hamcrest:hamcrest-library) mvn(org.hamcrest:hamcrest-parent) mvn(org.hamcrest:hamcrest-text) osgi(org.hamcrest.core) osgi(org.hamcrest.generator) osgi(org.hamcrest.integration) osgi(org.hamcrest.library) osgi(org.hamcrest.text) MD5-sum check ------------- http://repo1.maven.org/maven2/org/hamcrest/hamcrest-library/1.1/hamcrest-library-1.1.pom : CHECKSUM(SHA256) this package : 5c15836d51effb1ae6bc33559572e3757f34feee747bd1f4d680d789ccdde393 CHECKSUM(SHA256) upstream package : 5c15836d51effb1ae6bc33559572e3757f34feee747bd1f4d680d789ccdde393 http://repo1.maven.org/maven2/org/hamcrest/hamcrest-integration/1.1/hamcrest-integration-1.1.pom : CHECKSUM(SHA256) this package : 4b1f11938d8cb10d9637259ab7a796931a9c6b415c21deab7c0b1d5c6d6d231c CHECKSUM(SHA256) upstream package : 4b1f11938d8cb10d9637259ab7a796931a9c6b415c21deab7c0b1d5c6d6d231c http://hamcrest.googlecode.com/files/hamcrest-1.1.tgz : CHECKSUM(SHA256) this package : a76cca2dbb38ac185f51f8551c964a356009c7adf1a19b5407f87352e2e438c8 CHECKSUM(SHA256) upstream package : a76cca2dbb38ac185f51f8551c964a356009c7adf1a19b5407f87352e2e438c8 http://repo1.maven.org/maven2/org/hamcrest/hamcrest-parent/1.1/hamcrest-parent-1.1.pom : CHECKSUM(SHA256) this package : 14e6950a1a6298cbcb83cf9429cac415ff273167f6f15876859413b0d6c07e3a CHECKSUM(SHA256) upstream package : 14e6950a1a6298cbcb83cf9429cac415ff273167f6f15876859413b0d6c07e3a http://repo1.maven.org/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.pom : CHECKSUM(SHA256) this package : b95bf85cb0f3062ff89586f5f9137257f0fe5b37f1dfe46d07a9e479eadd611f CHECKSUM(SHA256) upstream package : b95bf85cb0f3062ff89586f5f9137257f0fe5b37f1dfe46d07a9e479eadd611f http://repo1.maven.org/maven2/org/hamcrest/hamcrest-generator/1.1/hamcrest-generator-1.1.pom : CHECKSUM(SHA256) this package : 5e892f610b27c75f9b2b952d17c2963b4279220d7449f5742700acff759e57c6 CHECKSUM(SHA256) upstream package : 5e892f610b27c75f9b2b952d17c2963b4279220d7449f5742700acff759e57c6 http://repo1.maven.org/maven2/org/hamcrest/hamcrest-core/1.1/hamcrest-core-1.1.pom : CHECKSUM(SHA256) this package : 397387f406c68ccb403f477ccbec1c818cfc6b8ff4fada5a33e26183a8417c83 CHECKSUM(SHA256) upstream package : 397387f406c68ccb403f477ccbec1c818cfc6b8ff4fada5a33e26183a8417c83 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn hamcrest -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires