Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 2549760 bytes in 18 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hdf5-devel , hdf5-static , hdf5-mpich2 , hdf5-mpich2-devel , hdf5-mpich2-static , hdf5-openmpi , hdf5-openmpi-devel , hdf5-openmpi-static [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3696640 bytes in /usr/share 849920 hdf5-1.8.10-1.fc19.x86_64.rpm 1146880 hdf5-devel-1.8.10-1.fc19.x86_64.rpm 849920 hdf5-mpich2-1.8.10-1.fc19.x86_64.rpm 849920 hdf5-openmpi-1.8.10-1.fc19.x86_64.rpm Rpmlint ------- Checking: hdf5-1.8.10-1.fc19.x86_64.rpm hdf5-devel-1.8.10-1.fc19.x86_64.rpm hdf5-static-1.8.10-1.fc19.x86_64.rpm hdf5-mpich2-1.8.10-1.fc19.x86_64.rpm hdf5-mpich2-devel-1.8.10-1.fc19.x86_64.rpm hdf5-mpich2-static-1.8.10-1.fc19.x86_64.rpm hdf5-openmpi-1.8.10-1.fc19.x86_64.rpm hdf5-openmpi-devel-1.8.10-1.fc19.x86_64.rpm hdf5-openmpi-static-1.8.10-1.fc19.x86_64.rpm hdf5.x86_64: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases hdf5.x86_64: W: spelling-error %description -l en_US dataset -> data set, data-set, database hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5mkgrp ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5import ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5dump ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/gif2h5 ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libhdf5_fortran.so.7.0.4 ['/usr/lib64'] hdf5.x86_64: W: shared-lib-calls-exit /usr/lib64/libhdf5_hl.so.7.0.4 exit@GLIBC_2.2.5 hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libhdf5_hl.so.7.0.4 ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5stat ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5repart ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5debug ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5unjam ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libhdf5hl_fortran.so.7.0.4 ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5repack ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5diff ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5copy ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libhdf5_cpp.so.7.0.4 ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5jam ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h52gif ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libhdf5_hl_cpp.so.7.0.4 ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5perf_serial ['/usr/lib64'] hdf5.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/h5ls ['/usr/lib64'] hdf5.x86_64: W: no-manual-page-for-binary h52gif hdf5.x86_64: W: no-manual-page-for-binary h5perf_serial hdf5.x86_64: W: no-manual-page-for-binary h5debug hdf5.x86_64: W: no-manual-page-for-binary h5import hdf5.x86_64: W: no-manual-page-for-binary h5repack hdf5.x86_64: W: no-manual-page-for-binary h5diff hdf5.x86_64: W: no-manual-page-for-binary h5copy hdf5.x86_64: W: no-manual-page-for-binary h5repart hdf5.x86_64: W: no-manual-page-for-binary h5ls hdf5.x86_64: W: no-manual-page-for-binary h5stat hdf5.x86_64: W: no-manual-page-for-binary h5mkgrp hdf5.x86_64: W: no-manual-page-for-binary h5jam hdf5.x86_64: W: no-manual-page-for-binary h5unjam hdf5.x86_64: W: no-manual-page-for-binary h5dump hdf5.x86_64: W: no-manual-page-for-binary gif2h5 hdf5-devel.x86_64: W: no-documentation hdf5-devel.x86_64: W: no-manual-page-for-binary h5fc-64 hdf5-devel.x86_64: W: no-manual-page-for-binary h5fc hdf5-devel.x86_64: W: no-manual-page-for-binary h5c++-64 hdf5-devel.x86_64: W: no-manual-page-for-binary h5cc hdf5-devel.x86_64: W: no-manual-page-for-binary h5cc-64 hdf5-devel.x86_64: W: no-manual-page-for-binary h5redeploy hdf5-devel.x86_64: W: no-manual-page-for-binary h5c++ hdf5-static.x86_64: W: no-documentation hdf5-mpich2.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich2/lib/libhdf5_hl.so.7.0.4 exit@GLIBC_2.2.5 hdf5-mpich2.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich2/lib/libhdf5hl_fortran.so.7.0.4 hdf5-mpich2.x86_64: E: library-without-ldconfig-postun /usr/lib64/mpich2/lib/libhdf5hl_fortran.so.7.0.4 hdf5-mpich2.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich2/lib/libhdf5_fortran.so.7.0.4 hdf5-mpich2.x86_64: E: library-without-ldconfig-postun /usr/lib64/mpich2/lib/libhdf5_fortran.so.7.0.4 hdf5-mpich2.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich2/lib/libhdf5.so.7.0.4 hdf5-mpich2.x86_64: E: library-without-ldconfig-postun /usr/lib64/mpich2/lib/libhdf5.so.7.0.4 hdf5-mpich2.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich2/lib/libhdf5_hl.so.7.0.4 hdf5-mpich2.x86_64: E: library-without-ldconfig-postun /usr/lib64/mpich2/lib/libhdf5_hl.so.7.0.4 hdf5-mpich2-devel.x86_64: W: only-non-binary-in-usr-lib hdf5-mpich2-devel.x86_64: W: no-documentation hdf5-mpich2-static.x86_64: W: no-documentation hdf5-openmpi.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/libhdf5_hl.so.7.0.4 exit@GLIBC_2.2.5 hdf5-openmpi.x86_64: E: library-without-ldconfig-postin /usr/lib64/openmpi/lib/libhdf5_hl.so.7.0.4 hdf5-openmpi.x86_64: E: library-without-ldconfig-postun /usr/lib64/openmpi/lib/libhdf5_hl.so.7.0.4 hdf5-openmpi.x86_64: E: library-without-ldconfig-postin /usr/lib64/openmpi/lib/libhdf5hl_fortran.so.7.0.4 hdf5-openmpi.x86_64: E: library-without-ldconfig-postun /usr/lib64/openmpi/lib/libhdf5hl_fortran.so.7.0.4 hdf5-openmpi.x86_64: E: library-without-ldconfig-postin /usr/lib64/openmpi/lib/libhdf5_fortran.so.7.0.4 hdf5-openmpi.x86_64: E: library-without-ldconfig-postun /usr/lib64/openmpi/lib/libhdf5_fortran.so.7.0.4 hdf5-openmpi.x86_64: E: library-without-ldconfig-postin /usr/lib64/openmpi/lib/libhdf5.so.7.0.4 hdf5-openmpi.x86_64: E: library-without-ldconfig-postun /usr/lib64/openmpi/lib/libhdf5.so.7.0.4 hdf5-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib hdf5-openmpi-devel.x86_64: W: no-documentation hdf5-openmpi-static.x86_64: W: no-documentation 9 packages and 0 specfiles checked; 36 errors, 35 warnings. Requires -------- hdf5-mpich2-devel (rpmlib, GLIBC filtered): /bin/sh hdf5-mpich2(x86-64) libhdf5.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libhdf5hl_fortran.so.7()(64bit) mpich2 hdf5 (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libhdf5.so.7()(64bit) libhdf5_cpp.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libm.so.6()(64bit) libquadmath.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) hdf5-openmpi-static (rpmlib, GLIBC filtered): hdf5-openmpi-devel(x86-64) hdf5-mpich2 (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libhdf5.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libm.so.6()(64bit) libmpich.so.8()(64bit) libmpichf90.so.8()(64bit) libmpl.so.1()(64bit) libopa.so.1()(64bit) libpthread.so.0()(64bit) libquadmath.so.0()(64bit) librt.so.1()(64bit) libz.so.1()(64bit) mpich2 rtld(GNU_HASH) hdf5-mpich2-static (rpmlib, GLIBC filtered): hdf5-mpich2-devel(x86-64) hdf5-devel (rpmlib, GLIBC filtered): /bin/bash /bin/sh config(hdf5-devel) hdf5 libhdf5.so.7()(64bit) libhdf5_cpp.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libhdf5_hl_cpp.so.7()(64bit) libhdf5hl_fortran.so.7()(64bit) zlib-devel hdf5-openmpi-devel (rpmlib, GLIBC filtered): /bin/sh hdf5-openmpi(x86-64) libhdf5.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libhdf5hl_fortran.so.7()(64bit) openmpi-devel hdf5-openmpi (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libhdf5.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libm.so.6()(64bit) libmpi.so.1()(64bit) libmpi_f77.so.1()(64bit) libmpi_f90.so.1()(64bit) libpthread.so.0()(64bit) libquadmath.so.0()(64bit) libz.so.1()(64bit) openmpi rtld(GNU_HASH) hdf5-static (rpmlib, GLIBC filtered): hdf5-devel Provides -------- hdf5-mpich2-devel: hdf5-mpich2-devel hdf5-mpich2-devel(x86-64) hdf5: hdf5 hdf5(x86-64) libhdf5.so.7()(64bit) libhdf5_cpp.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libhdf5_hl_cpp.so.7()(64bit) libhdf5hl_fortran.so.7()(64bit) hdf5-openmpi-static: hdf5-openmpi-static hdf5-openmpi-static(x86-64) hdf5-mpich2: hdf5-mpich2 hdf5-mpich2(x86-64) libhdf5.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libhdf5hl_fortran.so.7()(64bit) hdf5-mpich2-static: hdf5-mpich2-static hdf5-mpich2-static(x86-64) hdf5-devel: config(hdf5-devel) hdf5-devel hdf5-devel(x86-64) hdf5-openmpi-devel: hdf5-openmpi-devel hdf5-openmpi-devel(x86-64) hdf5-openmpi: hdf5-openmpi hdf5-openmpi(x86-64) libhdf5.so.7()(64bit) libhdf5_fortran.so.7()(64bit) libhdf5_hl.so.7()(64bit) libhdf5hl_fortran.so.7()(64bit) hdf5-static: hdf5-static hdf5-static(x86-64) Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn hdf5 -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires