Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find license.html in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in httpd-devel , httpd-manual , httpd-tools , mod_ssl , mod_proxy_html , mod_ldap [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Only use %_sourcedir in very specific situations. Note: %_sourcedir/$RPM_SOURCE_DIR is used. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 245760 bytes in 17 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Spec use %global instead of %define. Note: %define contentdir %{_datadir}/httpd %define docroot /var/www %define suexec_caller apache %define mmn 20120211 %define mmnisa %{mmn}-%{__isa_name}-%{__isa_bits} %define vstring Fedora %define sslcert %{_sysconfdir}/pki/tls/certs/localhost.crt %define sslkey %{_sysconfdir}/pki/tls/private/localhost.key [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: httpd-2.4.3-15.fc19.x86_64.rpm httpd-devel-2.4.3-15.fc19.x86_64.rpm httpd-manual-2.4.3-15.fc19.noarch.rpm httpd-tools-2.4.3-15.fc19.x86_64.rpm mod_ssl-2.4.3-15.fc19.x86_64.rpm mod_proxy_html-2.4.3-15.fc19.x86_64.rpm mod_ldap-2.4.3-15.fc19.x86_64.rpm httpd.x86_64: E: useless-provides httpd-mmn httpd.x86_64: W: self-obsoletion httpd-suexec obsoletes httpd-suexec = 2.4.3-15.fc19 httpd.x86_64: E: non-readable /usr/sbin/suexec 0510L httpd.x86_64: E: non-standard-executable-perm /usr/sbin/suexec 0510L httpd.x86_64: E: non-standard-dir-perm /var/cache/httpd 0700L httpd.x86_64: W: dangling-relative-symlink /usr/share/httpd/icons/poweredby.png ../../pixmaps/poweredby.png httpd.x86_64: E: non-standard-dir-perm /run/httpd 0710L httpd.x86_64: W: non-conffile-in-etc /etc/httpd/conf.d/README httpd.x86_64: E: non-standard-dir-perm /var/log/httpd 0700L httpd.x86_64: E: non-standard-dir-perm /var/lib/dav 0700L httpd.x86_64: E: non-standard-dir-perm /var/cache/httpd/proxy 0700L httpd.x86_64: E: non-standard-dir-perm /run/httpd/htcacheclean 0700L httpd-devel.x86_64: W: obsolete-not-provided secureweb-devel httpd-devel.x86_64: W: obsolete-not-provided apache-devel httpd-devel.x86_64: W: obsolete-not-provided stronghold-apache-devel httpd-devel.x86_64: W: only-non-binary-in-usr-lib httpd-devel.x86_64: W: non-conffile-in-etc /etc/rpm/macros.httpd httpd-devel.x86_64: W: hidden-file-or-dir /usr/include/httpd/.mmn httpd-manual.noarch: W: obsolete-not-provided secureweb-manual httpd-manual.noarch: W: obsolete-not-provided apache-manual httpd-manual.noarch: W: no-documentation httpd-tools.x86_64: W: no-manual-page-for-binary dbmmanage mod_ssl.x86_64: W: obsolete-not-provided stronghold-mod_ssl mod_ssl.x86_64: W: no-documentation mod_ssl.x86_64: E: non-standard-dir-perm /var/cache/httpd/ssl 0700L mod_proxy_html.x86_64: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml mod_proxy_html.x86_64: W: no-documentation mod_ldap.x86_64: W: spelling-error %description -l en_US ldap -> lap, leap, dapple mod_ldap.x86_64: W: spelling-error %description -l en_US authnz -> autobahn mod_ldap.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 10 errors, 20 warnings. Requires -------- mod_ldap (rpmlib, GLIBC filtered): apr-util-ldap httpd httpd-mmn libc.so.6()(64bit) liblber-2.4.so.2()(64bit) libldap_r-2.4.so.2()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) httpd (rpmlib, GLIBC filtered): /bin/sh /etc/mime.types /usr/sbin/useradd httpd-tools libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libcrypt.so.1()(64bit) libdb-5.3.so()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) liblua-5.1.so()(64bit) libm.so.6()(64bit) libpcre.so.1()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libsystemd-daemon.so.0()(64bit) libsystemd-daemon.so.0(LIBSYSTEMD_DAEMON_31)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) system-logos systemd-units httpd-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl apr-devel apr-util-devel httpd perl perl(strict) pkgconfig mod_ssl (rpmlib, GLIBC filtered): /bin/cat /bin/sh httpd httpd-mmn libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(OPENSSL_1.0.1)(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdl.so.2()(64bit) libpthread.so.0()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) openssl rtld(GNU_HASH) httpd-tools (rpmlib, GLIBC filtered): /usr/bin/perl libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdb-5.3.so()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libselinux.so.1()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) perl(AnyDBM_File) perl(Fcntl) perl(strict) rtld(GNU_HASH) mod_proxy_html (rpmlib, GLIBC filtered): httpd httpd-mmn libc.so.6()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) httpd-manual (rpmlib, GLIBC filtered): httpd Provides -------- mod_ldap: mod_ldap mod_ldap(x86-64) httpd: httpd httpd(x86-64) httpd-mmn httpd-suexec mod_dav webserver httpd-devel: httpd-devel httpd-devel(x86-64) mod_ssl: mod_ssl mod_ssl(x86-64) httpd-tools: httpd-tools httpd-tools(x86-64) mod_proxy_html: mod_proxy_html mod_proxy_html(x86-64) httpd-manual: httpd-manual Unversioned so-files -------------------- httpd: /usr/lib64/httpd/modules/mod_access_compat.so httpd: /usr/lib64/httpd/modules/mod_actions.so httpd: /usr/lib64/httpd/modules/mod_alias.so httpd: /usr/lib64/httpd/modules/mod_allowmethods.so httpd: /usr/lib64/httpd/modules/mod_asis.so httpd: /usr/lib64/httpd/modules/mod_auth_basic.so httpd: /usr/lib64/httpd/modules/mod_auth_digest.so httpd: /usr/lib64/httpd/modules/mod_auth_form.so httpd: /usr/lib64/httpd/modules/mod_authn_anon.so httpd: /usr/lib64/httpd/modules/mod_authn_core.so httpd: /usr/lib64/httpd/modules/mod_authn_dbd.so httpd: /usr/lib64/httpd/modules/mod_authn_dbm.so httpd: /usr/lib64/httpd/modules/mod_authn_file.so httpd: /usr/lib64/httpd/modules/mod_authn_socache.so httpd: /usr/lib64/httpd/modules/mod_authz_core.so httpd: /usr/lib64/httpd/modules/mod_authz_dbd.so httpd: /usr/lib64/httpd/modules/mod_authz_dbm.so httpd: /usr/lib64/httpd/modules/mod_authz_groupfile.so httpd: /usr/lib64/httpd/modules/mod_authz_host.so httpd: /usr/lib64/httpd/modules/mod_authz_owner.so httpd: /usr/lib64/httpd/modules/mod_authz_user.so httpd: /usr/lib64/httpd/modules/mod_autoindex.so httpd: /usr/lib64/httpd/modules/mod_buffer.so httpd: /usr/lib64/httpd/modules/mod_cache.so httpd: /usr/lib64/httpd/modules/mod_cache_disk.so httpd: /usr/lib64/httpd/modules/mod_cgi.so httpd: /usr/lib64/httpd/modules/mod_cgid.so httpd: /usr/lib64/httpd/modules/mod_charset_lite.so httpd: /usr/lib64/httpd/modules/mod_data.so httpd: /usr/lib64/httpd/modules/mod_dav.so httpd: /usr/lib64/httpd/modules/mod_dav_fs.so httpd: /usr/lib64/httpd/modules/mod_dav_lock.so httpd: /usr/lib64/httpd/modules/mod_dbd.so httpd: /usr/lib64/httpd/modules/mod_deflate.so httpd: /usr/lib64/httpd/modules/mod_dialup.so httpd: /usr/lib64/httpd/modules/mod_dir.so httpd: /usr/lib64/httpd/modules/mod_dumpio.so httpd: /usr/lib64/httpd/modules/mod_echo.so httpd: /usr/lib64/httpd/modules/mod_env.so httpd: /usr/lib64/httpd/modules/mod_expires.so httpd: /usr/lib64/httpd/modules/mod_ext_filter.so httpd: /usr/lib64/httpd/modules/mod_file_cache.so httpd: /usr/lib64/httpd/modules/mod_filter.so httpd: /usr/lib64/httpd/modules/mod_headers.so httpd: /usr/lib64/httpd/modules/mod_heartbeat.so httpd: /usr/lib64/httpd/modules/mod_heartmonitor.so httpd: /usr/lib64/httpd/modules/mod_include.so httpd: /usr/lib64/httpd/modules/mod_info.so httpd: /usr/lib64/httpd/modules/mod_lbmethod_bybusyness.so httpd: /usr/lib64/httpd/modules/mod_lbmethod_byrequests.so httpd: /usr/lib64/httpd/modules/mod_lbmethod_bytraffic.so httpd: /usr/lib64/httpd/modules/mod_lbmethod_heartbeat.so httpd: /usr/lib64/httpd/modules/mod_log_config.so httpd: /usr/lib64/httpd/modules/mod_log_debug.so httpd: /usr/lib64/httpd/modules/mod_log_forensic.so httpd: /usr/lib64/httpd/modules/mod_logio.so httpd: /usr/lib64/httpd/modules/mod_lua.so httpd: /usr/lib64/httpd/modules/mod_mime.so httpd: /usr/lib64/httpd/modules/mod_mime_magic.so httpd: /usr/lib64/httpd/modules/mod_mpm_event.so httpd: /usr/lib64/httpd/modules/mod_mpm_prefork.so httpd: /usr/lib64/httpd/modules/mod_mpm_worker.so httpd: /usr/lib64/httpd/modules/mod_negotiation.so httpd: /usr/lib64/httpd/modules/mod_proxy.so httpd: /usr/lib64/httpd/modules/mod_proxy_ajp.so httpd: /usr/lib64/httpd/modules/mod_proxy_balancer.so httpd: /usr/lib64/httpd/modules/mod_proxy_connect.so httpd: /usr/lib64/httpd/modules/mod_proxy_express.so httpd: /usr/lib64/httpd/modules/mod_proxy_fcgi.so httpd: /usr/lib64/httpd/modules/mod_proxy_fdpass.so httpd: /usr/lib64/httpd/modules/mod_proxy_ftp.so httpd: /usr/lib64/httpd/modules/mod_proxy_http.so httpd: /usr/lib64/httpd/modules/mod_proxy_scgi.so httpd: /usr/lib64/httpd/modules/mod_ratelimit.so httpd: /usr/lib64/httpd/modules/mod_reflector.so httpd: /usr/lib64/httpd/modules/mod_remoteip.so httpd: /usr/lib64/httpd/modules/mod_reqtimeout.so httpd: /usr/lib64/httpd/modules/mod_request.so httpd: /usr/lib64/httpd/modules/mod_rewrite.so httpd: /usr/lib64/httpd/modules/mod_sed.so httpd: /usr/lib64/httpd/modules/mod_setenvif.so httpd: /usr/lib64/httpd/modules/mod_slotmem_plain.so httpd: /usr/lib64/httpd/modules/mod_slotmem_shm.so httpd: /usr/lib64/httpd/modules/mod_socache_dbm.so httpd: /usr/lib64/httpd/modules/mod_socache_memcache.so httpd: /usr/lib64/httpd/modules/mod_socache_shmcb.so httpd: /usr/lib64/httpd/modules/mod_speling.so httpd: /usr/lib64/httpd/modules/mod_status.so httpd: /usr/lib64/httpd/modules/mod_substitute.so httpd: /usr/lib64/httpd/modules/mod_suexec.so httpd: /usr/lib64/httpd/modules/mod_systemd.so httpd: /usr/lib64/httpd/modules/mod_unique_id.so httpd: /usr/lib64/httpd/modules/mod_unixd.so httpd: /usr/lib64/httpd/modules/mod_userdir.so httpd: /usr/lib64/httpd/modules/mod_usertrack.so httpd: /usr/lib64/httpd/modules/mod_version.so httpd: /usr/lib64/httpd/modules/mod_vhost_alias.so httpd: /usr/lib64/httpd/modules/mod_watchdog.so mod_ssl: /usr/lib64/httpd/modules/mod_ssl.so mod_proxy_html: /usr/lib64/httpd/modules/mod_proxy_html.so mod_proxy_html: /usr/lib64/httpd/modules/mod_xml2enc.so mod_ldap: /usr/lib64/httpd/modules/mod_authnz_ldap.so mod_ldap: /usr/lib64/httpd/modules/mod_ldap.so MD5-sum check ------------- http://www.apache.org/dist/httpd/httpd-2.4.3.tar.bz2 : CHECKSUM(SHA256) this package : d82102b9c111f1892fb20a2bccf4370de579c6521b2f172ed0b36f2759fb249e CHECKSUM(SHA256) upstream package : d82102b9c111f1892fb20a2bccf4370de579c6521b2f172ed0b36f2759fb249e Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn httpd -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires