Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1290240 bytes in /usr/share 1290240 imake-1.0.5-5.fc18.x86_64.rpm Rpmlint ------- Checking: imake-1.0.5-5.fc18.x86_64.rpm imake.x86_64: W: summary-not-capitalized C imake source code configuration and build system imake.x86_64: W: name-repeated-in-summary C imake imake.x86_64: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, toadstools imake.x86_64: E: useless-provides imake imake.x86_64: E: zero-length /usr/share/X11/config/version.def imake.x86_64: E: zero-length /usr/share/X11/config/date.def imake.x86_64: E: zero-length /usr/share/X11/config/host.def 1 packages and 0 specfiles checked; 4 errors, 3 warnings. Requires -------- imake (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl libc.so.6()(64bit) rtld(GNU_HASH) Provides -------- imake: ccmakedep cleanlinks gccmakedep imake imake(x86-64) lndir makedepend makeg mergelib mkdirhier mkhtmlindex revpath xmkmf MD5-sum check ------------- ftp://ftp.x.org/pub/individual/util/gccmakedep-1.0.2.tar.bz2 : CHECKSUM(SHA256) this package : 063d49685b1002f3d0b89dfa730e9159f685bd51c277a39fc37b6e377a55ae11 CHECKSUM(SHA256) upstream package : 063d49685b1002f3d0b89dfa730e9159f685bd51c277a39fc37b6e377a55ae11 ftp://ftp.x.org/pub/individual/util/xorg-cf-files-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : 36e9ce83e4978f59909c6f44c43002d9b240ae66e23984ea1086f0b18c810669 CHECKSUM(SHA256) upstream package : 36e9ce83e4978f59909c6f44c43002d9b240ae66e23984ea1086f0b18c810669 ftp://ftp.x.org/pub/individual/util/imake-1.0.5.tar.bz2 : CHECKSUM(SHA256) this package : 99ce77ce73892d262522ee621032cef2fad2d30a36088b1305a156af4ee21cc1 CHECKSUM(SHA256) upstream package : 99ce77ce73892d262522ee621032cef2fad2d30a36088b1305a156af4ee21cc1 ftp://ftp.x.org/pub/individual/util/makedepend-1.0.4.tar.bz2 : CHECKSUM(SHA256) this package : ab56b8aeee00ed78d93c57d102e33ef4e6828ef5edd7108574966ed7d212f7fe CHECKSUM(SHA256) upstream package : ab56b8aeee00ed78d93c57d102e33ef4e6828ef5edd7108574966ed7d212f7fe ftp://ftp.x.org/pub/individual/util/lndir-1.0.3.tar.bz2 : CHECKSUM(SHA256) this package : 49f4fab0de8d418db4ce80dad34e9b879a4199f3e554253a8e1ab68f7c7cb65d CHECKSUM(SHA256) upstream package : 49f4fab0de8d418db4ce80dad34e9b879a4199f3e554253a8e1ab68f7c7cb65d Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn imake -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires