Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 4239360 bytes in 45 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in imsettings- libs , imsettings-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: update-desktop-database is invoked when required Note: desktop file(s) in imsettings [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5048320 bytes in /usr/share 471040 imsettings-gnome-1.5.1-2.fc19.x86_64.rpm 471040 imsettings- xfce-1.5.1-2.fc19.x86_64.rpm 471040 imsettings- lxde-1.5.1-2.fc19.x86_64.rpm 471040 imsettings-qt-1.5.1-2.fc19.x86_64.rpm 471040 imsettings-libs-1.5.1-2.fc19.x86_64.rpm 471040 imsettings- xim-1.5.1-2.fc19.x86_64.rpm 819200 imsettings- devel-1.5.1-2.fc19.x86_64.rpm 931840 imsettings-1.5.1-2.fc19.x86_64.rpm 471040 imsettings-mate-1.5.1-2.fc19.x86_64.rpm Rpmlint ------- Checking: imsettings-1.5.1-2.fc19.x86_64.rpm imsettings-libs-1.5.1-2.fc19.x86_64.rpm imsettings-devel-1.5.1-2.fc19.x86_64.rpm imsettings-xim-1.5.1-2.fc19.x86_64.rpm imsettings-gnome-1.5.1-2.fc19.x86_64.rpm imsettings-qt-1.5.1-2.fc19.x86_64.rpm imsettings-xfce-1.5.1-2.fc19.x86_64.rpm imsettings-lxde-1.5.1-2.fc19.x86_64.rpm imsettings-mate-1.5.1-2.fc19.x86_64.rpm imsettings.x86_64: W: non-conffile-in-etc /etc/X11/xinit/xinput.d/none.conf imsettings.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/imsettings-start.desktop imsettings.x86_64: W: non-conffile-in-etc /etc/X11/xinit/xinput.d/xim.conf imsettings.x86_64: W: non-conffile-in-etc /etc/X11/xinit/xinput.d/xcompose.conf imsettings.x86_64: W: no-manual-page-for-binary imsettings-reload imsettings.x86_64: W: no-manual-page-for-binary imsettings-list imsettings.x86_64: W: no-manual-page-for-binary imsettings-switch imsettings.x86_64: W: no-manual-page-for-binary imsettings-info imsettings-xim.x86_64: W: no-manual-page-for-binary imsettings-xim 9 packages and 0 specfiles checked; 0 errors, 9 warnings. Requires -------- imsettings-lxde (rpmlib, GLIBC filtered): /usr/bin/lxsession im-chooser imsettings(x86-64) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libimsettings.so.5()(64bit) libpthread.so.0()(64bit) lxde-settings-daemon lxsession rtld(GNU_HASH) imsettings-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) imsettings (rpmlib, GLIBC filtered): /bin/bash /bin/dbus-send /bin/sh /usr/sbin/alternatives imsettings-desktop-module(x86-64) imsettings-libs(x86-64) libX11.so.6()(64bit) libc.so.6()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libimsettings.so.5()(64bit) libnotify.so.4()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) xorg-x11-xinit imsettings-gnome (rpmlib, GLIBC filtered): dconf imsettings(x86-64) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libimsettings.so.5()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) imsettings-xim (rpmlib, GLIBC filtered): im-chooser imsettings(x86-64) libX11.so.6()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgxim.so.3()(64bit) libimsettings.so.5()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) imsettings-qt (rpmlib, GLIBC filtered): im-chooser imsettings(x86-64) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libimsettings.so.5()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) imsettings-xfce (rpmlib, GLIBC filtered): im-chooser-xfce imsettings(x86-64) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libimsettings.so.5()(64bit) libpthread.so.0()(64bit) libxfconf-0.so.2()(64bit) rtld(GNU_HASH) xfce4-settings imsettings-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config glib2-devel imsettings-libs(x86-64) libimsettings.so.5()(64bit) pkgconfig pkgconfig(gio-2.0) pkgconfig(gobject-2.0) imsettings-mate (rpmlib, GLIBC filtered): im-chooser imsettings(x86-64) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libimsettings.so.5()(64bit) libpthread.so.0()(64bit) mate-session-manager mate-settings-daemon rtld(GNU_HASH) Provides -------- imsettings-lxde: imsettings-desktop-module(x86-64) imsettings-lxde imsettings-lxde(x86-64) libimsettings-lxde.so()(64bit) imsettings-libs: imsettings-libs imsettings-libs(x86-64) libimsettings.so.5()(64bit) imsettings: imsettings imsettings(x86-64) imsettings-gnome: imsettings-desktop-module(x86-64) imsettings-gnome imsettings-gnome(x86-64) libimsettings-gsettings.so()(64bit) imsettings-xim: imsettings-xim imsettings-xim(x86-64) libimsettings-xim.so()(64bit) imsettings-qt: imsettings-desktop-module(x86-64) imsettings-qt imsettings-qt(x86-64) libimsettings-qt.so()(64bit) imsettings-xfce: imsettings-desktop-module(x86-64) imsettings-xfce imsettings-xfce(x86-64) libimsettings-xfce.so()(64bit) imsettings-devel: imsettings-devel imsettings-devel(x86-64) pkgconfig(imsettings) imsettings-mate: imsettings-desktop-module(x86-64) imsettings-mate imsettings-mate(x86-64) libimsettings-mate-gsettings.so()(64bit) Unversioned so-files -------------------- imsettings-xim: /usr/lib64/imsettings/libimsettings-xim.so imsettings-gnome: /usr/lib64/imsettings/libimsettings-gsettings.so imsettings-qt: /usr/lib64/imsettings/libimsettings-qt.so imsettings-xfce: /usr/lib64/imsettings/libimsettings-xfce.so imsettings-lxde: /usr/lib64/imsettings/libimsettings-lxde.so imsettings-mate: /usr/lib64/imsettings/libimsettings-mate-gsettings.so MD5-sum check ------------- https://bitbucket.org/tagoh/imsettings/downloads/imsettings-1.5.1.tar.bz2 : CHECKSUM(SHA256) this package : c6bc40933eef9fc3eabb040d76a893bd1f9e75746bef8996fe2fc28a0e3b7e9d CHECKSUM(SHA256) upstream package : c6bc40933eef9fc3eabb040d76a893bd1f9e75746bef8996fe2fc28a0e3b7e9d Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn imsettings -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires