Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/temp/rhel- reviews/initscripts-9.43-1.fc19/initscripts/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in debugmode [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 92160 bytes in 7 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5734400 bytes in /usr/share 5734400 initscripts-9.43-1.fc19.x86_64.rpm Rpmlint ------- Checking: initscripts-9.43-1.fc19.x86_64.rpm debugmode-9.43-1.fc19.x86_64.rpm initscripts.x86_64: W: spelling-error %description -l en_US runlevels -> run levels, run-levels, runnels initscripts.x86_64: W: obsolete-not-provided initscripts-legacy initscripts.x86_64: W: only-non-binary-in-usr-lib initscripts.x86_64: E: incorrect-fsf-address /etc/sysconfig/network-scripts/ifup-wireless initscripts.x86_64: E: setgid-binary /sbin/netreport root 02755L initscripts.x86_64: E: non-standard-executable-perm /sbin/netreport 02755L initscripts.x86_64: W: non-conffile-in-etc /etc/profile.d/term256.csh initscripts.x86_64: W: non-conffile-in-etc /etc/statetab initscripts.x86_64: E: non-readable /etc/crypttab 0600L initscripts.x86_64: W: non-conffile-in-etc /etc/profile.d/lang.csh initscripts.x86_64: E: incorrect-fsf-address /etc/sysconfig/network-scripts/ifdown-eth initscripts.x86_64: W: non-conffile-in-etc /etc/rc.d/init.d/functions initscripts.x86_64: E: script-without-shebang /etc/rc.d/init.d/functions initscripts.x86_64: E: non-executable-script /etc/rc.d/init.d/functions 0644L None initscripts.x86_64: W: dangling-relative-symlink /lib/systemd/system/ctrl-alt-del.target reboot.target initscripts.x86_64: E: setuid-binary /usr/sbin/usernetctl root 04755L initscripts.x86_64: E: non-standard-executable-perm /usr/sbin/usernetctl 04755L initscripts.x86_64: E: script-without-shebang /etc/sysconfig/network-scripts/ifup-post initscripts.x86_64: E: executable-marked-as-config-file /etc/rc.d/rc.local initscripts.x86_64: E: incorrect-fsf-address /etc/sysconfig/network-scripts/ifup-tunnel initscripts.x86_64: E: non-root-group-log-file /var/log/btmp utmp initscripts.x86_64: W: non-conffile-in-etc /etc/sysconfig/network-scripts/network-functions-ipv6 initscripts.x86_64: E: non-root-group-log-file /var/log/wtmp utmp initscripts.x86_64: E: non-standard-dir-perm /var/run/netreport 0775L initscripts.x86_64: W: non-conffile-in-etc /etc/sysconfig/network-scripts/network-functions initscripts.x86_64: E: incorrect-fsf-address /sbin/ifup initscripts.x86_64: W: non-conffile-in-etc /etc/profile.d/term256.sh initscripts.x86_64: W: non-conffile-in-etc /etc/rwtab initscripts.x86_64: W: non-conffile-in-etc /etc/profile.d/lang.sh initscripts.x86_64: E: incorrect-fsf-address /etc/sysconfig/network-scripts/ifup-eth initscripts.x86_64: E: incorrect-fsf-address /etc/sysconfig/network-scripts/ifdown-tunnel initscripts.x86_64: W: log-files-without-logrotate /var/log/wtmp initscripts.x86_64: W: dangerous-command-in-%post chown initscripts.x86_64: E: init-script-non-executable /etc/rc.d/init.d/functions initscripts.x86_64: W: incoherent-subsys /etc/rc.d/init.d/functions ${lock_file} initscripts.x86_64: W: incoherent-subsys /etc/rc.d/init.d/functions ${lock_file} initscripts.x86_64: E: no-chkconfig-line /etc/rc.d/init.d/functions initscripts.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/network initscripts.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/network initscripts.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/network debugmode.x86_64: W: no-documentation debugmode.x86_64: W: non-conffile-in-etc /etc/profile.d/debug.sh debugmode.x86_64: W: non-conffile-in-etc /etc/profile.d/debug.csh 2 packages and 0 specfiles checked; 20 errors, 23 warnings. Requires -------- initscripts (rpmlib, GLIBC filtered): /bin/awk /bin/bash /bin/sh /etc/system-release /sbin/arping /sbin/chkconfig /sbin/sysctl /usr/sbin/groupadd bash config(initscripts) coreutils cpio findutils grep hostname iproute libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libpopt.so.0()(64bit) libpopt.so.0(LIBPOPT_0)(64bit) module-init-tools rtld(GNU_HASH) sed systemd sysvinit-tools udev util-linux debugmode (rpmlib, GLIBC filtered): config(debugmode) initscripts Provides -------- initscripts: config(initscripts) initscripts initscripts(x86-64) debugmode: config(debugmode) debugmode debugmode(x86-64) MD5-sum check ------------- http://fedorahosted.org/releases/i/n/initscripts/initscripts-9.43.tar.bz2 : CHECKSUM(SHA256) this package : 9503c71e4f646f3fc5e7a10d5f4e6f5aea9275249fea596879b2513555d53867 CHECKSUM(SHA256) upstream package : 4fbfc664439f001ae9c5a7f84f4b2ec5036bf49311527337eee78d3f41129072 diff -r also reports differences Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn initscripts -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires