Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/temp/rhel- reviews/iproute-3.7.0-1.fc19/iproute/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Static libraries in -static subpackage, if present. Note: Archive *.a files found in iproute-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries - Large documentation must go in a -doc subpackage. Note: Documentation size is 2416640 bytes in 34 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in iproute-doc , iproute-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2631680 bytes in /usr/share 256000 iproute-3.7.0-1.fc19.x86_64.rpm 2344960 iproute- doc-3.7.0-1.fc19.x86_64.rpm 30720 iproute-devel-3.7.0-1.fc19.x86_64.rpm Rpmlint ------- Checking: iproute-3.7.0-1.fc19.x86_64.rpm iproute-doc-3.7.0-1.fc19.x86_64.rpm iproute-devel-3.7.0-1.fc19.x86_64.rpm iproute.x86_64: E: incorrect-fsf-address /usr/sbin/cbq iproute.x86_64: W: no-manual-page-for-binary ifstat iproute.x86_64: W: no-manual-page-for-binary genl iproute.x86_64: W: no-manual-page-for-binary rtpr iproute-doc.x86_64: W: spelling-error Summary(en_US) ip -> pi, up, op iproute-doc.x86_64: W: spelling-error Summary(en_US) tc -> ct, Tc, t iproute-doc.x86_64: W: summary-not-capitalized C ip and tc documentation with examples iproute-doc.x86_64: W: spelling-error %description -l en_US howtos -> kowtows iproute-doc.x86_64: E: incorrect-fsf-address /usr/share/doc/iproute-doc-3.7.0/examples/cbq.init-v0.7.3.fix_cbq iproute-doc.x86_64: E: incorrect-fsf-address /usr/share/doc/iproute-doc-3.7.0/examples/cbq.init-v0.7.3 iproute-devel.x86_64: W: summary-not-capitalized C iproute development files iproute-devel.x86_64: W: spelling-error %description -l en_US libnetlink -> libertine 3 packages and 0 specfiles checked; 3 errors, 9 warnings. Requires -------- iproute (rpmlib, GLIBC filtered): /bin/bash /bin/sh config(iproute) libatm.so.1()(64bit) libc.so.6()(64bit) libdb-5.3.so()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) iproute-devel (rpmlib, GLIBC filtered): iproute-doc (rpmlib, GLIBC filtered): Provides -------- iproute: /sbin/ip config(iproute) iproute iproute(x86-64) m_xt.so()(64bit) q_atm.so()(64bit) iproute-devel: iproute-devel iproute-devel(x86-64) iproute-static iproute-doc: iproute-doc iproute-doc(x86-64) Unversioned so-files -------------------- iproute: /usr/lib64/tc/m_ipt.so iproute: /usr/lib64/tc/m_xt.so iproute: /usr/lib64/tc/q_atm.so MD5-sum check ------------- http://kernel.org/pub/linux/utils/net/iproute2/iproute2-3.7.0.tar.gz : CHECKSUM(SHA256) this package : 164d137dd1ba394b37439b53824045cbeadaa0190320de1d47f2c728a8d9453c CHECKSUM(SHA256) upstream package : be9693828d8dd3cdfbaaab47ff4e2a4872c1237bdb25cfc5dbbd835d09d6b262 diff -r also reports differences Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn iproute -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires