Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Large documentation must go in a -doc subpackage. Note: Documentation size is 3153920 bytes in 102 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Static libraries in -static subpackage, if present. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in isdn4k- utils-devel , isdn4k-utils-static , isdn4k-utils-vboxgetty , xisdnload , isdn4k-utils-doc [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4433920 bytes in /usr/share 2508800 isdn4k-utils-doc-3.2-88.fc19.x86_64.rpm 1884160 isdn4k- utils-3.2-88.fc19.x86_64.rpm 20480 isdn4k-utils- vboxgetty-3.2-88.fc19.x86_64.rpm 20480 xisdnload-3.2-88.fc19.x86_64.rpm Rpmlint ------- Checking: isdn4k-utils-3.2-88.fc19.x86_64.rpm isdn4k-utils-devel-3.2-88.fc19.x86_64.rpm isdn4k-utils-static-3.2-88.fc19.x86_64.rpm isdn4k-utils-vboxgetty-3.2-88.fc19.x86_64.rpm xisdnload-3.2-88.fc19.x86_64.rpm isdn4k-utils-doc-3.2-88.fc19.x86_64.rpm isdn4k-utils.x86_64: E: shared-lib-without-dependency-information /usr/lib64/pppd/2.4.5/userpass.so isdn4k-utils.x86_64: E: non-readable /etc/ppp/peers/isdn/avm-ml 0600L isdn4k-utils.x86_64: E: non-readable /etc/isdn/vboxgetty.conf 0640L isdn4k-utils.x86_64: E: script-without-shebang /usr/lib/systemd/system/isdn.service isdn4k-utils.x86_64: E: non-readable /etc/ppp/peers/isdn/otelo 0600L isdn4k-utils.x86_64: E: incorrect-fsf-address /usr/share/doc/isdn4k-utils-3.2/COPYING isdn4k-utils.x86_64: E: non-readable /etc/ppp/peers/isdn/leased 0600L isdn4k-utils.x86_64: E: script-without-shebang /usr/lib/systemd/system/capi.service isdn4k-utils.x86_64: E: non-readable /etc/ppp/peers/isdn/arcor 0600L isdn4k-utils.x86_64: W: manual-page-warning /usr/share/man/man8/isdnctrl_conf.8.gz 1: warning: macro `TP' not defined isdn4k-utils.x86_64: W: manual-page-warning /usr/share/man/man8/isdnctrl_conf.8.gz 2: warning: macro `BI' not defined isdn4k-utils.x86_64: W: manual-page-warning /usr/share/man/man8/isdnctrl_conf.8.gz 4: warning: macro `I' not defined isdn4k-utils.x86_64: W: manual-page-warning /usr/share/man/man8/isdnctrl_conf.8.gz 6: warning: macro `B' not defined isdn4k-utils.x86_64: W: manual-page-warning /usr/share/man/man8/isdnctrl_conf.8.gz 16: warning: macro `SS' not defined isdn4k-utils.x86_64: W: manual-page-warning /usr/share/man/man8/isdnctrl_conf.8.gz 27: warning: macro `BR' not defined isdn4k-utils.x86_64: W: manual-page-warning /usr/share/man/man8/isdnctrl_conf.8.gz 78: warning: macro `IR' not defined isdn4k-utils.x86_64: W: manual-page-warning /usr/share/man/man8/isdnctrl_conf.8.gz 120: warning: macro `RB' not defined isdn4k-utils.x86_64: E: non-readable /etc/isdn/vboxd.conf 0640L isdn4k-utils.x86_64: E: non-readable /etc/ppp/peers/isdn/avm 0600L isdn4k-utils.x86_64: E: non-readable /etc/ppp/peers/isdn/talkline 0600L isdn4k-utils.x86_64: W: log-files-without-logrotate /var/log/vbox isdn4k-utils.x86_64: W: no-manual-page-for-binary rcapid isdn4k-utils.x86_64: W: no-manual-page-for-binary vboxcnvt isdn4k-utils.x86_64: W: no-manual-page-for-binary capifax isdn4k-utils.x86_64: W: no-manual-page-for-binary capifaxrcvd isdn4k-utils-devel.x86_64: W: spelling-error Summary(en_US) capi -> capo, cap, carpi isdn4k-utils-devel.x86_64: W: spelling-error %description -l en_US capi -> capo, cap, carpi isdn4k-utils-devel.x86_64: W: no-documentation isdn4k-utils-static.x86_64: W: spelling-error Summary(en_US) capi -> capo, cap, carpi isdn4k-utils-static.x86_64: W: spelling-error %description -l en_US devel -> delve, devil, revel isdn4k-utils-static.x86_64: W: spelling-error %description -l en_US capi -> capo, cap, carpi isdn4k-utils-static.x86_64: W: no-documentation isdn4k-utils-vboxgetty.x86_64: W: spelling-error Summary(en_US) getty -> Getty, gutty, petty 6 packages and 0 specfiles checked; 12 errors, 21 warnings. Requires -------- isdn4k-utils-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config isdn4k-utils libcapi20.so.3()(64bit) xisdnload (rpmlib, GLIBC filtered): isdn4k-utils libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXaw.so.7()(64bit) libXext.so.6()(64bit) libXmu.so.6()(64bit) libXpm.so.4()(64bit) libXt.so.6()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) isdn4k-utils-static (rpmlib, GLIBC filtered): isdn4k-utils isdn4k-utils-devel isdn4k-utils (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/service bzip2 chkconfig config(isdn4k-utils) coreutils hwdata initscripts libc.so.6()(64bit) libcapi20.so.3()(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libncurses.so.5()(64bit) libpanel.so.5()(64bit) libpcap.so.1()(64bit) libtinfo.so.5()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) systemd-units udev isdn4k-utils-vboxgetty (rpmlib, GLIBC filtered): isdn4k-utils libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libtcl8.5.so()(64bit) rtld(GNU_HASH) tcl isdn4k-utils-doc (rpmlib, GLIBC filtered): isdn4k-utils Provides -------- isdn4k-utils-devel: isdn4k-utils-devel isdn4k-utils-devel(x86-64) pkgconfig(capi20) xisdnload: xisdnload xisdnload(x86-64) isdn4k-utils-static: isdn4k-utils-static isdn4k-utils-static(x86-64) isdn4k-utils: capiplugin.so()(64bit) config(isdn4k-utils) isdn4k-utils isdn4k-utils(x86-64) lib_capi_mod_fritzbox.so.0()(64bit) lib_capi_mod_rcapi.so.0()(64bit) lib_capi_mod_std.so.0()(64bit) libcapi20.so.3()(64bit) userpass.so()(64bit) isdn4k-utils-vboxgetty: isdn4k-utils-vboxgetty isdn4k-utils-vboxgetty(x86-64) isdn4k-utils-doc: isdn4k-utils-doc isdn4k-utils-doc(x86-64) Unversioned so-files -------------------- isdn4k-utils: /usr/lib64/pppd/2.4.5/capiplugin.so isdn4k-utils: /usr/lib64/pppd/2.4.5/userpass.so Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn isdn4k-utils -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires