Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in javamail- javadoc [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 51200 bytes in 2 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. Java: [ ]: Bundled jar/class files should be removed before build Note: Test run failed [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Fully versioned dependency in subpackages, if present. [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [ ]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [ ]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [ ]: Package has BuildArch: noarch (if possible) [ ]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: javamail-1.4.3-12.fc18.noarch.rpm javamail-javadoc-1.4.3-12.fc18.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- javamail-javadoc (rpmlib, GLIBC filtered): jpackage-utils javamail (rpmlib, GLIBC filtered): jpackage-utils Provides -------- javamail-javadoc: javamail-javadoc javamail: javamail javamail-monolithic mvn(com.sun.mail:all) mvn(com.sun.mail:dsn) mvn(com.sun.mail:imap) mvn(com.sun.mail:parent-distrib) mvn(com.sun.mail:pop3) mvn(com.sun.mail:smtp) mvn(javax.mail:mail) mvn(javax.mail:mailapi) osgi(javax.mail) MD5-sum check ------------- http://download.java.net/maven/2/javax/mail/mail/1.4.3/mail-1.4.3.pom : CHECKSUM(SHA256) this package : f0c0dc378dcc81e082dd5e330e1240eee12ace965a18c7f54c7b4ee1d56ec2ca CHECKSUM(SHA256) upstream package : f0c0dc378dcc81e082dd5e330e1240eee12ace965a18c7f54c7b4ee1d56ec2ca http://download.java.net/maven/2/com/sun/mail/dsn/1.4.3/dsn-1.4.3-sources.jar : CHECKSUM(SHA256) this package : 115a46058327cc3f9044e232111704c6f2875dae7682909bce03ce23c21ce30f CHECKSUM(SHA256) upstream package : 115a46058327cc3f9044e232111704c6f2875dae7682909bce03ce23c21ce30f http://download.java.net/maven/2/com/sun/mail/all/1.4.3/all-1.4.3.pom : CHECKSUM(SHA256) this package : 6f37729b83d22e649c3d69540ce0fcf2e3d04e2d8f06e60c74a4e05c23862138 CHECKSUM(SHA256) upstream package : 6f37729b83d22e649c3d69540ce0fcf2e3d04e2d8f06e60c74a4e05c23862138 http://download.java.net/maven/2/javax/mail/mail/1.4.3/mail-1.4.3-sources.jar : CHECKSUM(SHA256) this package : 2d5026f15733f77431111366099e7cc0452eaa403064f58175c8338eed67e906 CHECKSUM(SHA256) upstream package : 2d5026f15733f77431111366099e7cc0452eaa403064f58175c8338eed67e906 http://download.java.net/maven/2/com/sun/mail/imap/1.4.3/imap-1.4.3.pom : CHECKSUM(SHA256) this package : 55748c0375e9ef64c453b274f0955ec72a8e8c1e1d4be89e3a6332bfa3918ea2 CHECKSUM(SHA256) upstream package : 55748c0375e9ef64c453b274f0955ec72a8e8c1e1d4be89e3a6332bfa3918ea2 http://download.java.net/maven/2/com/sun/mail/pop3/1.4.3/pop3-1.4.3.pom : CHECKSUM(SHA256) this package : fd272dfeb268aebb9f3630535edb742b2029a2ce90504ad7be1721ce262dcab9 CHECKSUM(SHA256) upstream package : fd272dfeb268aebb9f3630535edb742b2029a2ce90504ad7be1721ce262dcab9 http://download.java.net/maven/2/com/sun/mail/dsn/1.4.3/dsn-1.4.3.pom : CHECKSUM(SHA256) this package : c267c28871ee1e726ee55932b8f74801b24d5306c780be1c27e4368a3bc5f4e8 CHECKSUM(SHA256) upstream package : c267c28871ee1e726ee55932b8f74801b24d5306c780be1c27e4368a3bc5f4e8 http://download.java.net/maven/2/javax/mail/mailapi/1.4.3/mailapi-1.4.3.pom : CHECKSUM(SHA256) this package : 29824fefa51ad98b759f8a6949cfc09306d8bbb61d1bf381e1c2bc520118c020 CHECKSUM(SHA256) upstream package : 29824fefa51ad98b759f8a6949cfc09306d8bbb61d1bf381e1c2bc520118c020 http://download.java.net/maven/2/com/sun/mail/smtp/1.4.3/smtp-1.4.3.pom : CHECKSUM(SHA256) this package : e261fbd5bab22746738f945877151260cc0d93f9744f26d94163d0fbc29ff998 CHECKSUM(SHA256) upstream package : e261fbd5bab22746738f945877151260cc0d93f9744f26d94163d0fbc29ff998 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn javamail -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires