Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in kdeartwork, kdeartwork-screensavers, kdeartwork- wallpapers See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find LICENSE in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nuvola- icon-theme , kde-style-phase , kdeartwork-screensavers , kdeartwork-kxs , kdeartwork-wallpapers , kdeartwork-sounds , mono-icon-theme [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in nuvola-icon-theme, mono-icon-theme [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5529600 bytes in /usr/share 10240 kde- style-phase-4.9.98-1.fc19.x86_64.rpm 2652160 kdeartwork- screensavers-4.9.98-1.fc19.x86_64.rpm 2867200 kdeartwork-4.9.98-1.fc19.x86_64.rpm Rpmlint ------- Checking: kdeartwork-4.9.98-1.fc19.x86_64.rpm nuvola-icon-theme-4.9.98-1.fc19.noarch.rpm kde-style-phase-4.9.98-1.fc19.x86_64.rpm kdeartwork-screensavers-4.9.98-1.fc19.x86_64.rpm kdeartwork-kxs-4.9.98-1.fc19.x86_64.rpm kdeartwork-wallpapers-4.9.98-1.fc19.noarch.rpm kdeartwork-sounds-4.9.98-1.fc19.noarch.rpm mono-icon-theme-4.9.98-1.fc19.noarch.rpm nuvola-icon-theme.noarch: W: no-documentation kde-style-phase.x86_64: W: no-documentation kdeartwork-screensavers.x86_64: W: summary-not-capitalized C screensavers for KDE kdeartwork-screensavers.x86_64: W: no-documentation kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary klines.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kflux.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kblob.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kswarm.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kvm.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary krotation.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kgravity.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kbanner.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kfountain.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary klorenz.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kwave.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kpendulum.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kscience.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary ksolarwinds.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary keuphoria.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kpolygon.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kslideshow.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kpartsaver.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kdeasciiquarium.kss kdeartwork-screensavers.x86_64: W: no-manual-page-for-binary kclock.kss kdeartwork-kxs.x86_64: W: spelling-error Summary(en_US) xscreensaver -> screenwriter kdeartwork-kxs.x86_64: W: spelling-error Summary(en_US) screensavers -> screen savers, screen-savers, screens avers kdeartwork-kxs.x86_64: W: spelling-error %description -l en_US xscreensaver -> screenwriter kdeartwork-kxs.x86_64: W: spelling-error %description -l en_US screensavers -> screen savers, screen-savers, screens avers kdeartwork-kxs.x86_64: W: no-documentation kdeartwork-kxs.x86_64: W: no-manual-page-for-binary kxsrun kdeartwork-kxs.x86_64: W: no-manual-page-for-binary kxsconfig kdeartwork-wallpapers.noarch: W: no-documentation kdeartwork-sounds.noarch: W: no-documentation mono-icon-theme.noarch: W: no-documentation 8 packages and 0 specfiles checked; 0 errors, 34 warnings. Requires -------- kde-style-phase (rpmlib, GLIBC filtered): libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kdeartwork (rpmlib, GLIBC filtered): kde-workspace libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtSvg.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecorations.so.4()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kdeartwork-sounds (rpmlib, GLIBC filtered): kde-filesystem mono-icon-theme (rpmlib, GLIBC filtered): /bin/sh kdeartwork-kxs (rpmlib, GLIBC filtered): kde-workspace libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libX11.so.6()(64bit) libXt.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) xscreensaver-base nuvola-icon-theme (rpmlib, GLIBC filtered): /bin/sh kdeartwork-screensavers (rpmlib, GLIBC filtered): kdeartwork-kxs libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtOpenGL.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXau.so.6()(64bit) libXext.so.6()(64bit) libXft.so.2()(64bit) libXpm.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libkparts.so.4()(64bit) libkscreensaver.so.5()(64bit) libm.so.6()(64bit) libnepomuk.so.4()(64bit) libnepomukutils.so.4()(64bit) libpthread.so.0()(64bit) libsoprano.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) xscreensaver-extras xscreensaver-gl-extras kdeartwork-wallpapers (rpmlib, GLIBC filtered): kde-filesystem Provides -------- kde-style-phase: kde-style-phase kde-style-phase(x86-64) kstyle_phase_config.so()(64bit) phasestyle.so()(64bit) kdeartwork: kdeartwork kdeartwork(x86-64) kwin3_kde2.so()(64bit) kwin3_keramik.so()(64bit) kwin3_modernsys.so()(64bit) kwin3_quartz.so()(64bit) kwin3_redmond.so()(64bit) kwin3_web.so()(64bit) kwin_kde2_config.so()(64bit) kwin_keramik_config.so()(64bit) kwin_modernsys_config.so()(64bit) kwin_quartz_config.so()(64bit) kdeartwork-sounds: kdeartwork-sounds mono-icon-theme: mono-icon-theme kdeartwork-kxs: kdeartwork-kxs kdeartwork-kxs(x86-64) nuvola-icon-theme: nuvola-icon-theme kdeartwork-screensavers: kdeartwork-screensavers kdeartwork-screensavers(x86-64) kdeartwork-wallpapers: kdeartwork-wallpapers Unversioned so-files -------------------- kdeartwork: /usr/lib64/kde4/kwin3_kde2.so kdeartwork: /usr/lib64/kde4/kwin3_keramik.so kdeartwork: /usr/lib64/kde4/kwin3_modernsys.so kdeartwork: /usr/lib64/kde4/kwin3_quartz.so kdeartwork: /usr/lib64/kde4/kwin3_redmond.so kdeartwork: /usr/lib64/kde4/kwin3_web.so kdeartwork: /usr/lib64/kde4/kwin_kde2_config.so kdeartwork: /usr/lib64/kde4/kwin_keramik_config.so kdeartwork: /usr/lib64/kde4/kwin_modernsys_config.so kdeartwork: /usr/lib64/kde4/kwin_quartz_config.so kde-style-phase: /usr/lib64/kde4/kstyle_phase_config.so kde-style-phase: /usr/lib64/kde4/plugins/styles/phasestyle.so MD5-sum check ------------- http://download.kde.org/unstable/4.9.98/src/kdeartwork-4.9.98.tar.xz : CHECKSUM(SHA256) this package : 9764857f6ab1fe0c0d51748d8b19c84cde02e11bc069f97e8a4333018e08e22d CHECKSUM(SHA256) upstream package : 9764857f6ab1fe0c0d51748d8b19c84cde02e11bc069f97e8a4333018e08e22d Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn kdeartwork -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires