Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - update-desktop-database is invoked when required Note: desktop file(s) in kdegames, kdegames-minimal See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop - Large documentation must go in a -doc subpackage. Note: Documentation size is 9635840 bytes in 242 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package does not contain duplicates in %files. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kdegames- minimal , kdegames-libs , kdegames-devel [ ]: Package complies to the Packaging Guidelines [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in kdegames, kdegames-minimal [ ]: Useful -debuginfo package or justification otherwise. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? Python: [ ]: Binary eggs must be removed in %prep Note: Test run failed [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: update-mime-database is invoked as required Note: mimeinfo files in: kdegames, kdegames-minimal [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 127293440 bytes in /usr/share 45281280 kdegames-minimal-4.9.3-1.fc19.x86_64.rpm 81981440 kdegames-4.9.3-1.fc19.x86_64.rpm 30720 kdegames- libs-4.9.3-1.fc19.x86_64.rpm Rpmlint ------- Checking: kdegames-4.9.3-1.fc19.x86_64.rpm kdegames-minimal-4.9.3-1.fc19.x86_64.rpm kdegames-libs-4.9.3-1.fc19.x86_64.rpm kdegames-devel-4.9.3-1.fc19.x86_64.rpm kdegames.x86_64: W: spelling-error %description -l en_US ksame -> same, k same kdegames.x86_64: W: spelling-error %description -l en_US ksnakeduel -> snakelike kdegames.x86_64: W: spelling-error %description -l en_US ksnake -> snake, k snake, Snake kdegames.x86_64: E: non-executable-script /usr/share/kde4/apps/kajongg/deferredutil.py 0644L /usr/bin/env kdegames.x86_64: E: zero-length /usr/share/kde4/apps/kigo/kigo.notifyrc kdegames.x86_64: E: non-executable-script /usr/share/kde4/apps/kajongg/server.py 0644L /usr/bin/env kdegames.x86_64: W: no-manual-page-for-binary ksirkskineditor kdegames.x86_64: W: no-manual-page-for-binary ksirk kdegames.x86_64: W: no-manual-page-for-binary palapeli kdegames.x86_64: W: no-manual-page-for-binary kdiamond kdegames.x86_64: W: no-manual-page-for-binary kapman kdegames.x86_64: W: no-manual-page-for-binary knetwalk kdegames.x86_64: W: no-manual-page-for-binary kolf kdegames.x86_64: W: no-manual-page-for-binary kblocks kdegames.x86_64: W: no-manual-page-for-binary kshisen kdegames.x86_64: W: no-manual-page-for-binary bomber kdegames.x86_64: W: no-manual-page-for-binary ksudoku kdegames.x86_64: W: no-manual-page-for-binary klines kdegames.x86_64: W: no-manual-page-for-binary kbounce kdegames.x86_64: W: no-manual-page-for-binary kigo kdegames.x86_64: W: no-manual-page-for-binary granatier kdegames.x86_64: W: no-manual-page-for-binary kgoldrunner kdegames.x86_64: W: no-manual-page-for-binary kdesnake kdegames.x86_64: W: no-manual-page-for-binary kiriki kdegames.x86_64: W: no-manual-page-for-binary killbots kdegames.x86_64: W: no-manual-page-for-binary kreversi kdegames.x86_64: W: no-manual-page-for-binary kbattleship kdegames.x86_64: W: no-manual-page-for-binary ktuberling kdegames.x86_64: W: no-manual-page-for-binary kajongg kdegames.x86_64: W: no-manual-page-for-binary kjumpingcube kdegames.x86_64: W: no-manual-page-for-binary ktron kdegames.x86_64: W: no-manual-page-for-binary kollision kdegames.x86_64: W: no-manual-page-for-binary katomic kdegames.x86_64: W: no-manual-page-for-binary lskat kdegames.x86_64: W: no-manual-page-for-binary kspaceduel kdegames.x86_64: W: no-manual-page-for-binary bovo kdegames.x86_64: W: no-manual-page-for-binary konquest kdegames.x86_64: W: no-manual-page-for-binary kfourinlineproc kdegames.x86_64: W: no-manual-page-for-binary kbreakout kdegames.x86_64: W: no-manual-page-for-binary kfourinline kdegames.x86_64: W: no-manual-page-for-binary ksquares kdegames.x86_64: W: no-manual-page-for-binary kblackbox kdegames.x86_64: W: no-manual-page-for-binary kajonggserver kdegames.x86_64: W: no-manual-page-for-binary kubrick kdegames.x86_64: W: no-manual-page-for-binary klickety kdegames-minimal.x86_64: W: no-manual-page-for-binary kmahjongg kdegames-minimal.x86_64: W: no-manual-page-for-binary kpat kdegames-minimal.x86_64: W: no-manual-page-for-binary kmines kdegames-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment kdegames-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment kdegames-libs.x86_64: E: invalid-soname /usr/lib64/libkcardgame.so libkcardgame.so kdegames-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 4 errors, 48 warnings. Requires -------- kdegames-minimal (rpmlib, GLIBC filtered): /bin/sh kdegames-libs(x86-64) libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkcardgame.so()(64bit) libkdecore.so.5()(64bit) libkdegames.so.6()(64bit) libkdegamesprivate.so.1()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libkmahjongglib.so.4()(64bit) libm.so.6()(64bit) libphonon.so.4()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kdegames-devel (rpmlib, GLIBC filtered): kdegames-libs(x86-64) kdelibs4-devel libkdegames.so.6()(64bit) libkdegamesprivate.so.1()(64bit) libpala.so.0()(64bit) kdegames-libs (rpmlib, GLIBC filtered): /sbin/ldconfig kdelibs4(x86-64) libQt3Support.so.4()(64bit) libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libkdecore.so.5()(64bit) libkdegames.so.6()(64bit) libkdeui.so.5()(64bit) libkdnssd.so.4()(64bit) libkio.so.5()(64bit) libknewstuff3.so.4()(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libphonon.so.4()(64bit) libpthread.so.0()(64bit) libqca.so.2()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) kdegames (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env /usr/bin/perl PyKDE4 gnugo kde4-macros(api) kdegames-libs(x86-64) kdegames-minimal libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtOpenGL.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXau.so.6()(64bit) libXext.so.6()(64bit) libXft.so.2()(64bit) libXpm.so.4()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libiris_ksirk.so.2()(64bit) libkdecore.so.5()(64bit) libkdegames.so.6()(64bit) libkdegamesprivate.so.1()(64bit) libkdeui.so.5()(64bit) libkdnssd.so.4()(64bit) libkfile.so.4()(64bit) libkio.so.5()(64bit) libkmahjongglib.so.4()(64bit) libknewstuff3.so.4()(64bit) libknotifyconfig.so.4()(64bit) libkolfprivate.so.4()(64bit) libm.so.6()(64bit) libpala.so.0()(64bit) libphonon.so.4()(64bit) libpthread.so.0()(64bit) libqca.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) perl(File::Path) perl(strict) python-twisted-core qhull qt4-sqlite rtld(GNU_HASH) vorbis-tools Provides -------- kdegames-minimal: kdegames-minimal kdegames-minimal(x86-64) mimehandler(application/vnd.kde.kpatience.savedstate) kdegames-devel: kdegames-devel kdegames-devel(x86-64) kdegames4-devel kdegames-libs: kdegames-libs kdegames-libs(x86-64) libiris_ksirk.so.2()(64bit) libkcardgame.so()(64bit) libkdegames.so.6()(64bit) libkdegamesprivate.so.1()(64bit) libkmahjongglib.so.4()(64bit) libkolfprivate.so.4()(64bit) libpala.so.0()(64bit) kdegames: kdegames kdegames(x86-64) kdegames4 ksirk ksudoku mimehandler(application/x-go-sgf) mimehandler(application/x-kolf) mimehandler(application/x-kourse) mimehandler(application/x-palapeli-puzzle) mimehandler(application/x-tuberling) mimehandler(inode/vnd.kde.service.kbattleship) palapeli_goldbergslicer.so()(64bit) palapeli_jigsawslicer.so()(64bit) palapeli_rectslicer.so()(64bit) palathumbcreator.so()(64bit) Unversioned so-files -------------------- kdegames: /usr/lib64/kde4/palapeli_goldbergslicer.so kdegames: /usr/lib64/kde4/palapeli_jigsawslicer.so kdegames: /usr/lib64/kde4/palapeli_rectslicer.so kdegames: /usr/lib64/kde4/palathumbcreator.so kdegames-libs: /usr/lib64/libkcardgame.so MD5-sum check ------------- ftp://ftp.kde.org/pub/kde/stable/4.9.3/src/kdegames-4.9.3.tar.xz : CHECKSUM(SHA256) this package : 479a45cb6b5e9278c7a09bfcb6b025891fbadd0891e1431d4d77ea7aa5f6912b CHECKSUM(SHA256) upstream package : 479a45cb6b5e9278c7a09bfcb6b025891fbadd0891e1431d4d77ea7aa5f6912b Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -rpn kdegames -m fedora-rawhide-x86_64 -v -x CheckRpmlintInstalled,CheckApprovedLicense,CheckContainsLicenseText,CheckLicenseField,CheckLicenseUpstream,CheckReqPkgConfig,CheckBuildCompleted,CheckPackageInstalls,CheckNoNameConflict,CheckBuild,CheckBuildRequires